Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Jan 2, 2025

if we use ipv6_cidr_to_range function with nullable func which with invalid ipv6 will make be core

mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

if we use ipv6_cidr_to_range function with nullable func which with
invalid ipv6 will make be core
```
mysql> select id, ipv6_cidr_to_range(nullable(''), 32) from fn_test_ip_nullable order by id;
```
@Thearas
Copy link
Contributor

Thearas commented Jan 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan
Copy link
Contributor Author

amorynan commented Jan 2, 2025

run buildall

@amorynan
Copy link
Contributor Author

amorynan commented Jan 3, 2025

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.41% (9564/26269)
Line Coverage: 27.98% (79001/282391)
Region Coverage: 26.64% (40498/152006)
Branch Coverage: 23.40% (20525/87710)
Coverage Report: http://coverage.selectdb-in.cc/coverage/42babe4f0ed3e3e99ba1872bb2e81b6f58909f89_42babe4f0ed3e3e99ba1872bb2e81b6f58909f89/report/index.html

@yiguolei yiguolei merged commit 333b54e into apache:branch-2.1 Jan 3, 2025
17 of 19 checks passed
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants