Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 2, 2025

Cherry-picked from #45905

fix coredump with new_json_reader if we read invalid data will core
which source from #43469
@Thearas
Copy link
Contributor

Thearas commented Jan 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 2, 2025
@dataroaring dataroaring reopened this Jan 2, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 2, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41067 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ffd3ae7c96c35d0231eff311d42e0a354924e344, data reload: false

------ Round 1 ----------------------------------
q1	18843	7407	7264	7264
q2	2059	164	162	162
q3	10964	1088	1124	1088
q4	10988	765	723	723
q5	7842	2924	2883	2883
q6	239	151	151	151
q7	1014	626	621	621
q8	9580	2006	2038	2006
q9	6863	6510	6455	6455
q10	7092	2294	2353	2294
q11	467	278	284	278
q12	414	214	210	210
q13	18844	3023	3081	3023
q14	255	217	218	217
q15	577	549	540	540
q16	700	619	616	616
q17	975	574	553	553
q18	7234	6654	6583	6583
q19	1442	1039	1008	1008
q20	485	203	197	197
q21	3963	3198	3181	3181
q22	1125	1014	1019	1014
Total cold run time: 111965 ms
Total hot run time: 41067 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7263	7240	7187	7187
q2	335	248	250	248
q3	2995	2939	2938	2938
q4	2050	1796	1770	1770
q5	5682	5730	5756	5730
q6	224	140	136	136
q7	2241	1785	1786	1785
q8	3362	3457	3431	3431
q9	8798	8841	8832	8832
q10	3586	3557	3552	3552
q11	598	492	495	492
q12	847	620	626	620
q13	11344	3188	3119	3119
q14	303	267	272	267
q15	584	520	524	520
q16	740	691	641	641
q17	1841	1610	1581	1581
q18	8171	7820	7638	7638
q19	1675	1629	1568	1568
q20	2100	1852	1862	1852
q21	5645	5443	5572	5443
q22	1155	1103	1019	1019
Total cold run time: 71539 ms
Total hot run time: 60369 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197953 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ffd3ae7c96c35d0231eff311d42e0a354924e344, data reload: false

query1	1269	932	936	932
query2	6257	2114	2065	2065
query3	10974	4319	4428	4319
query4	67081	29271	23792	23792
query5	4942	480	463	463
query6	417	184	192	184
query7	5685	315	309	309
query8	314	241	240	240
query9	9474	2683	2680	2680
query10	485	261	270	261
query11	17957	15438	16023	15438
query12	161	101	103	101
query13	1610	448	433	433
query14	10430	8341	7305	7305
query15	218	181	181	181
query16	7438	485	490	485
query17	1090	587	591	587
query18	1397	306	315	306
query19	227	149	154	149
query20	120	114	114	114
query21	57	42	43	42
query22	4655	4613	4324	4324
query23	34824	33933	34487	33933
query24	6134	2977	2907	2907
query25	537	441	469	441
query26	677	175	174	174
query27	1748	312	313	312
query28	4673	2484	2448	2448
query29	709	468	481	468
query30	251	169	173	169
query31	1043	832	882	832
query32	70	60	58	58
query33	432	290	303	290
query34	938	513	515	513
query35	868	729	754	729
query36	1103	994	993	993
query37	127	76	78	76
query38	4154	4113	4004	4004
query39	1531	1487	1480	1480
query40	153	91	91	91
query41	52	50	52	50
query42	117	102	98	98
query43	546	501	509	501
query44	1235	845	855	845
query45	213	171	166	166
query46	1173	732	738	732
query47	1994	1927	1935	1927
query48	463	376	381	376
query49	727	412	407	407
query50	835	427	443	427
query51	7429	7183	7126	7126
query52	102	89	91	89
query53	255	176	179	176
query54	569	431	440	431
query55	76	76	72	72
query56	250	255	253	253
query57	1265	1108	1090	1090
query58	221	210	204	204
query59	3193	2892	2946	2892
query60	286	253	241	241
query61	123	115	110	110
query62	786	653	681	653
query63	220	182	194	182
query64	1456	694	647	647
query65	3299	3206	3224	3206
query66	704	332	298	298
query67	15959	15756	15547	15547
query68	4138	597	570	570
query69	435	276	268	268
query70	1193	1143	1132	1132
query71	352	254	272	254
query72	6470	4062	3986	3986
query73	764	346	349	346
query74	10085	9047	8951	8951
query75	3379	2689	2726	2689
query76	1843	1091	1114	1091
query77	505	287	270	270
query78	10616	9651	9608	9608
query79	2083	604	597	597
query80	1401	440	418	418
query81	546	241	242	241
query82	1207	116	117	116
query83	167	150	147	147
query84	286	81	79	79
query85	981	312	291	291
query86	406	311	296	296
query87	4505	4270	4207	4207
query88	3968	2382	2331	2331
query89	417	298	288	288
query90	1984	187	189	187
query91	181	147	145	145
query92	61	49	50	49
query93	2824	553	555	553
query94	886	306	293	293
query95	365	256	251	251
query96	649	288	274	274
query97	3353	3174	3175	3174
query98	218	200	199	199
query99	1598	1340	1278	1278
Total cold run time: 323644 ms
Total hot run time: 197953 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.78 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ffd3ae7c96c35d0231eff311d42e0a354924e344, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.61	0.10	0.11
query5	0.51	0.51	0.50
query6	1.14	0.74	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.02
query9	0.57	0.50	0.50
query10	0.56	0.54	0.54
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.60
query14	3.00	2.94	2.88
query15	0.90	0.84	0.83
query16	0.39	0.38	0.38
query17	1.04	1.07	1.06
query18	0.23	0.21	0.23
query19	1.94	1.91	2.04
query20	0.01	0.01	0.02
query21	15.35	0.59	0.60
query22	2.58	2.70	1.75
query23	16.95	1.00	0.88
query24	2.94	0.74	1.04
query25	0.24	0.14	0.07
query26	0.30	0.14	0.15
query27	0.04	0.04	0.05
query28	11.01	1.11	1.08
query29	12.53	3.28	3.24
query30	0.24	0.06	0.06
query31	2.85	0.38	0.38
query32	3.29	0.46	0.47
query33	3.01	2.99	3.01
query34	16.88	4.46	4.50
query35	4.54	4.51	4.55
query36	0.65	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.11	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 107.08 s
Total hot run time: 32.78 s

@eldenmoon eldenmoon merged commit b2d7554 into branch-3.0 Jan 2, 2025
20 of 21 checks passed
@github-actions github-actions bot deleted the auto-pick-45905-branch-3.0 branch January 2, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants