Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) support external table MODIFY_TABLE_PROPERTY_SYNC operation. #46324

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

Jibing-Li
Copy link
Contributor

What problem does this PR solve?

fix external_table_p0/hive/test_hive_statistics_p0.groovy
Nereids need to support external table MODIFY_TABLE_PROPERTY_SYNC operation.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review January 2, 2025 14:31
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32892 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f10deeb530588cdba5397239fe7b4980e593b772, data reload: false

------ Round 1 ----------------------------------
q1	17581	6154	6040	6040
q2	2054	303	180	180
q3	10406	1205	752	752
q4	10220	860	434	434
q5	7524	2165	2004	2004
q6	205	183	149	149
q7	880	739	615	615
q8	9238	1334	1214	1214
q9	5294	4905	4916	4905
q10	6771	2317	1863	1863
q11	490	288	257	257
q12	344	350	214	214
q13	17783	3807	3197	3197
q14	241	246	221	221
q15	563	514	500	500
q16	624	617	591	591
q17	600	872	355	355
q18	7025	6347	6347	6347
q19	2023	979	588	588
q20	318	321	194	194
q21	2891	2244	1959	1959
q22	378	338	313	313
Total cold run time: 103453 ms
Total hot run time: 32892 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6292	6191	6221	6191
q2	233	324	232	232
q3	2248	2644	2278	2278
q4	1411	1796	1384	1384
q5	4319	4755	4797	4755
q6	184	176	151	151
q7	2315	1981	1823	1823
q8	2657	2748	2684	2684
q9	7287	7286	7380	7286
q10	3107	3349	2836	2836
q11	565	506	494	494
q12	662	772	606	606
q13	3424	3783	3232	3232
q14	275	309	298	298
q15	572	506	501	501
q16	647	690	662	662
q17	1277	1746	1246	1246
q18	7659	7346	7260	7260
q19	929	1021	1191	1021
q20	2001	2036	1813	1813
q21	5776	5303	4837	4837
q22	628	591	628	591
Total cold run time: 54468 ms
Total hot run time: 52181 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197282 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f10deeb530588cdba5397239fe7b4980e593b772, data reload: false

query1	1312	952	926	926
query2	6521	2373	2396	2373
query3	11138	4686	4916	4686
query4	33130	23623	23121	23121
query5	3693	591	461	461
query6	270	194	192	192
query7	4003	488	303	303
query8	302	249	239	239
query9	9555	2673	2665	2665
query10	456	316	258	258
query11	17706	15522	15118	15118
query12	157	111	107	107
query13	1583	548	426	426
query14	9750	7105	8100	7105
query15	260	219	197	197
query16	8530	645	449	449
query17	1590	862	608	608
query18	2185	415	332	332
query19	218	209	177	177
query20	134	117	173	117
query21	212	130	104	104
query22	4749	4504	4464	4464
query23	34298	33892	34630	33892
query24	6703	2325	2403	2325
query25	478	485	399	399
query26	736	281	158	158
query27	2115	495	357	357
query28	5692	2482	2473	2473
query29	554	569	430	430
query30	207	186	161	161
query31	964	938	848	848
query32	80	60	59	59
query33	497	362	306	306
query34	779	855	543	543
query35	790	839	787	787
query36	1025	1070	994	994
query37	126	103	74	74
query38	4382	4238	4432	4238
query39	1531	1482	1492	1482
query40	207	119	100	100
query41	43	45	42	42
query42	123	107	104	104
query43	552	564	517	517
query44	1342	847	841	841
query45	177	177	177	177
query46	890	1069	675	675
query47	2023	2017	1963	1963
query48	383	399	327	327
query49	720	508	388	388
query50	667	674	408	408
query51	7136	7305	7213	7213
query52	106	104	92	92
query53	227	262	188	188
query54	487	497	416	416
query55	77	84	82	82
query56	262	259	256	256
query57	1282	1243	1147	1147
query58	232	227	229	227
query59	3380	3378	3228	3228
query60	288	272	258	258
query61	113	107	104	104
query62	871	822	762	762
query63	227	193	209	193
query64	3252	1084	718	718
query65	3376	3223	3222	3222
query66	787	426	303	303
query67	16410	15828	15617	15617
query68	9003	698	511	511
query69	473	295	251	251
query70	1215	1137	1122	1122
query71	480	291	245	245
query72	6484	3844	3911	3844
query73	648	742	357	357
query74	10223	9295	8885	8885
query75	4032	3124	2669	2669
query76	3611	1211	787	787
query77	762	349	271	271
query78	10628	10126	9578	9578
query79	4341	797	570	570
query80	729	525	418	418
query81	535	275	228	228
query82	565	152	125	125
query83	189	159	138	138
query84	285	86	66	66
query85	807	367	305	305
query86	361	322	309	309
query87	4663	4599	4474	4474
query88	4013	2164	2149	2149
query89	447	329	294	294
query90	1972	186	183	183
query91	205	135	103	103
query92	70	55	55	55
query93	2231	855	530	530
query94	676	412	295	295
query95	334	262	253	253
query96	492	609	275	275
query97	2942	2916	2848	2848
query98	224	199	195	195
query99	1700	1590	1427	1427
Total cold run time: 299391 ms
Total hot run time: 197282 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f10deeb530588cdba5397239fe7b4980e593b772, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.60	0.11	0.11
query5	0.42	0.43	0.41
query6	1.16	0.65	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.61	0.50	0.49
query10	0.55	0.56	0.56
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.59	0.59
query14	2.73	2.74	2.71
query15	0.89	0.83	0.83
query16	0.39	0.37	0.39
query17	1.03	1.03	0.98
query18	0.23	0.22	0.21
query19	1.93	1.84	2.02
query20	0.01	0.01	0.01
query21	15.36	0.92	0.62
query22	0.75	0.94	0.64
query23	15.19	1.43	0.58
query24	3.26	0.92	1.24
query25	0.15	0.16	0.06
query26	0.38	0.14	0.13
query27	0.07	0.04	0.04
query28	13.22	1.51	1.05
query29	12.60	3.92	3.27
query30	0.25	0.10	0.07
query31	2.81	0.60	0.40
query32	3.23	0.53	0.46
query33	3.20	3.09	3.14
query34	16.60	5.14	4.52
query35	4.52	4.46	4.55
query36	0.83	0.48	0.50
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 105.72 s
Total hot run time: 31.22 s

@Jibing-Li
Copy link
Contributor Author

run p0

1 similar comment
@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run feut

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Jan 3, 2025

PR approved by anyone and no changes requested.

Copy link
Contributor

@morrySnow morrySnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change title to reflect the code change

@Jibing-Li Jibing-Li changed the title [fix](regression)Fix set external auto analyze case. [fix](regression)Nereids support external table MODIFY_TABLE_PROPERTY_SYNC operation. Jan 3, 2025
@Jibing-Li
Copy link
Contributor Author

change title to reflect the code change

Done

@Jibing-Li Jibing-Li merged commit bfb7648 into apache:master Jan 3, 2025
27 of 30 checks passed
@morrySnow morrySnow changed the title [fix](regression)Nereids support external table MODIFY_TABLE_PROPERTY_SYNC operation. [fix](Nereids) support external table MODIFY_TABLE_PROPERTY_SYNC operation. Jan 3, 2025
@Jibing-Li Jibing-Li deleted the property branch January 6, 2025 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants