[Fix](recycler) Fix recycler Hdfs accessor list all bug #46393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Collaborator
Author
|
run buildall |
github-actions
bot
removed
the
approved
gavinchou
reviewed
Jan 3, 2025
gavinchou
reviewed
Jan 3, 2025
gavinchou
requested changes
Jan 3, 2025
Yukang-Lian
force-pushed
the
Fix-Recycler-Hdfs-List-All
branch
from
41f1142 to
52edc39
Compare
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
Collaborator
Author
|
run buildall |
gavinchou
reviewed
Jan 10, 2025
Collaborator
Author
|
run buildall |
gavinchou
approved these changes
Jan 13, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
luwei16
approved these changes
Jan 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
The HDFS accessor in the recycler currently lists all files from the root directory when deleting by prefix, and then matches and deletes files based on the prefix. This approach wastes significant time processing unrelated tablets. This PR fixes the issue by only listing files under the relevant tablet directories first, then matching them against the prefix for deletion.
dataroaring
pushed a commit
that referenced
this pull request
Jan 13, 2025
Closed
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
The HDFS accessor in the recycler currently lists all files from the root directory when deleting by prefix, and then matches and deletes files based on the prefix. This approach wastes significant time processing unrelated tablets. This PR fixes the issue by only listing files under the relevant tablet directories first, then matching them against the prefix for deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
The HDFS accessor in the recycler currently lists all files from the root directory when deleting by prefix, and then matches and deletes files based on the prefix. This approach wastes significant time processing unrelated tablets. This PR fixes the issue by only listing files under the relevant tablet directories first, then matching them against the prefix for deletion.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)