[fix](cloud) fix file cache potential leakage #46404
Closed
+89
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix compaction gc leakage by correcting use_count() of rowset shr_ptr 2. seperate monitoring and gc routine in blockfilecache backgroud thread to avoid interference 3. update BlockFileCache::recycle_deleted_blocks flow control for gc efficiency 4. refactor: unify stale async cache clean to orginal tag-and-deleting 5. fix leakage in remove_if_cached_async in case of !releasable 6. fix leakage in BlockFileCache::remove in case of FileBlock::State::DOWNLOADING 7. TODO: add more cases Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Contributor
Author
|
run buildall |
gavinchou
reviewed
Jan 3, 2025
gavinchou
reviewed
Jan 3, 2025
|
|
||
| LOG_INFO("Start clear file cache async").tag("path", _cache_base_path); | ||
| auto iter_queue = [&](LRUQueue& queue) { | ||
| bool end = false; |
Contributor
There was a problem hiding this comment.
where is end set to true?
gavinchou
reviewed
Jan 3, 2025
| void BlockFileCache::recycle_deleted_blocks() { | ||
| using namespace std::chrono; | ||
| static int remove_batch = 100; | ||
| static int remove_batch = 500; |
Contributor
There was a problem hiding this comment.
keep it 100, and make the cond.wait_for(cache_lock, std::chrono::microseconds(100)); configurable to do throttle.
gavinchou
requested changes
Jan 3, 2025
| bool end = false; | ||
| while (queue.get_capacity(cache_lock) != 0 && !end) { | ||
| std::vector<FileBlockCell*> cells; | ||
| for (const auto& [entry_key, entry_offset, _] : queue) { |
Contributor
There was a problem hiding this comment.
it seems that we should not iterate from the beginning again?
there may be performance penalty if there are lots of running query while we are deleting elements that are far from the head.
can we iterate from rbegin() to get better performance?
| return msg; | ||
| } | ||
|
|
||
| void BlockFileCache::recycle_deleted_blocks() { |
Contributor
There was a problem hiding this comment.
UT should be added to make it fully tested
Contributor
Author
|
updated in new PR: #46561 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)