Skip to content

[Bug](join) fix columnstr64's offset overflow on serialize_value_into_arena #46461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 3 commits into from
Jan 8, 2025
Merged

[Bug](join) fix columnstr64's offset overflow on serialize_value_into_arena #46461

BiteTheDDDDt merged 3 commits into from
Jan 8, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jan 6, 2025 •
edited
Loading

What problem does this PR solve?

mysql [test]>select /*+ LEADING(a,b) */ count(*) from d_table as a, d_table2 as b where a.k4=b.k4 and a.k1=b.k1;

+----------+
| count(*) |
+----------+
| 50000000 |
+----------+
1 row in set (4.87 sec)

mysql [test]>select /*+ LEADING(b,a) */ count(*) from d_table as a, d_table2 as b where a.k4=b.k4 and a.k1=b.k1;

+----------+
| count(*) |
+----------+
| 42949673 |
+----------+
1 row in set (21.32 sec)

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jan 6, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jan 6, 2025

run buildall

@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jan 6, 2025
Merged
@wm1581066 wm1581066 added p0_w usercase Important user case type label dev/2.1.x labels Jan 6, 2025
mrhhsg
mrhhsg previously approved these changes Jan 6, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

PR approved by anyone and no changes requested.

HappenLee
HappenLee reviewed Jan 7, 2025
View reviewed changes
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 7, 2025
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jan 7, 2025

run buildall

yiguolei pushed a commit that referenced this pull request Jan 7, 2025
@BiteTheDDDDt
[Bug](join) fix columnstr64's offset overflow on serialize_value_into…
2f98a62 
…_arena #46461  (#46462)

pick from #46461
HappenLee
HappenLee approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 8, 2025
mrhhsg
mrhhsg approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit b0da422 into apache:master Jan 8, 2025
29 of 31 checks passed
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDt
[Bug](join) fix columnstr64's offset overflow on serialize_value_into…
652f6a3 
…_arena (#46461)

```sql
mysql [test]>select /*+ LEADING(a,b) */ count(*) from d_table as a, d_table2 as b where a.k4=b.k4 and a.k1=b.k1;

+----------+
| count(*) |
+----------+
| 50000000 |
+----------+
1 row in set (4.87 sec)

mysql [test]>select /*+ LEADING(b,a) */ count(*) from d_table as a, d_table2 as b where a.k4=b.k4 and a.k1=b.k1;

+----------+
| count(*) |
+----------+
| 42949673 |
+----------+
1 row in set (21.32 sec)
```

None

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jan 14, 2025
Merged
29 tasks
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
@BiteTheDDDDt
[Bug](join) fix columnstr64's offset overflow on serialize_value_into… …
2b5b957 
…#46461 (#46939)

…_arena (#46461)

```sql
mysql [test]>select /*+ LEADING(a,b) */ count(*) from d_table as a, d_table2 as b where a.k4=b.k4 and a.k1=b.k1;

+----------+
| count(*) |
+----------+
| 50000000 |
+----------+
1 row in set (4.87 sec)

mysql [test]>select /*+ LEADING(b,a) */ count(*) from d_table as a, d_table2 as b where a.k4=b.k4 and a.k1=b.k1;

+----------+
| count(*) |
+----------+
| 42949673 |
+----------+
1 row in set (21.32 sec)
```

None

- Test <!-- At least one of them must be included. -->
    - [x] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change. - [ ] No code files have been
changed. - [ ] Other reason <!-- Add your reason? -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@HappenLee HappenLee HappenLee approved these changes

+1 more reviewer

@Besho777 Besho777 Besho777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged p0_w reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BiteTheDDDDt @Thearas @mrhhsg @HappenLee @Besho777 @yiguolei @wm1581066