Skip to content

branch-3.0: [fix](cloud-mow) Fix the issue of inaccurate estimation of txn size when updating delete bitmap #46969 #47046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 2 commits into from
Jan 17, 2025
Merged

branch-3.0: [fix](cloud-mow) Fix the issue of inaccurate estimation of txn size when updating delete bitmap #46969 #47046

zhannngchen merged 2 commits into from
Jan 17, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 16, 2025

Cherry-picked from #46969

@hust-hhb
[fix](cloud-mow) Fix the issue of inaccurate estimation of txn size w…
9162a85 
…hen updating delete bitmap (#46969)

fdb_txn_size is not key size+value size, actually txn size is the triple
of key size plus value size at least for writing, so use
txn->approximate_bytes() to calculating txn size is more accurate.
However, txn->approximate_bytes() is not 100% accurate either, in my
test, when txn->approximate_bytes() bingger than 8.3MB, it will meet
Transaction exceeds byte limit error.
@Thearas
Copy link
Contributor

Thearas commented Jan 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jan 16, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 16, 2025

run buildall

@CalvinKirs
Copy link
Member

CalvinKirs commented Jan 16, 2025

run buildall

@zhannngchen zhannngchen merged commit 415aa23 into branch-3.0 Jan 17, 2025
25 of 27 checks passed
@github-actions github-actions bot deleted the auto-pick-46969-branch-3.0 branch January 17, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring Awaiting requested review from dataroaring

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Thearas @CalvinKirs @zhannngchen @dataroaring @hust-hhb