Skip to content

[fix](schema-change) Fix single column table could not rename columns #47275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jan 24, 2025
Merged

[fix](schema-change) Fix single column table could not rename columns #47275

dataroaring merged 1 commit into from
Jan 24, 2025

Conversation

@Hastyshell
Copy link
Collaborator

@Hastyshell Hastyshell commented Jan 21, 2025

What problem does this PR solve?

Problem Summary:

Single column tables was not able to rename column due to light schema change check in error way.

Fix this problem in this PR.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Hastyshell
Copy link
Collaborator Author

Hastyshell commented Jan 21, 2025

run buildall

dataroaring
dataroaring approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hastyshell Hastyshell changed the title [fix](schema-change) Fix single column table could not rename [fix](schema-change) Fix single column table could not rename columns Jan 21, 2025
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Jan 21, 2025

TPC-H: Total hot run time: 32415 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 04f7068ad050dca5395899c2340c2419fe21a7bb, data reload: false

------ Round 1 ----------------------------------
q1	17603	5519	5378	5378
q2	2049	309	176	176
q3	10586	1337	752	752
q4	10279	966	516	516
q5	8633	2389	2202	2202
q6	204	171	140	140
q7	888	752	633	633
q8	9229	1349	1176	1176
q9	5289	4906	4879	4879
q10	6812	2341	1902	1902
q11	473	271	255	255
q12	348	365	221	221
q13	17782	3649	3103	3103
q14	232	241	212	212
q15	507	478	461	461
q16	621	591	598	591
q17	560	863	326	326
q18	7204	6519	6461	6461
q19	1883	976	538	538
q20	322	324	187	187
q21	2817	2221	1994	1994
q22	359	326	312	312
Total cold run time: 104680 ms
Total hot run time: 32415 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5538	5511	5488	5488
q2	241	324	240	240
q3	2277	2606	2348	2348
q4	1395	1831	1319	1319
q5	4298	4740	4673	4673
q6	179	170	135	135
q7	2156	1998	1873	1873
q8	2690	2816	2667	2667
q9	7313	7237	7236	7236
q10	2976	3291	2770	2770
q11	584	517	491	491
q12	655	749	608	608
q13	3541	3995	3176	3176
q14	270	298	274	274
q15	513	480	464	464
q16	660	701	647	647
q17	1206	1734	1253	1253
q18	7738	7484	7402	7402
q19	818	1143	1053	1053
q20	2006	2014	1898	1898
q21	5615	5230	5021	5021
q22	610	558	549	549
Total cold run time: 53279 ms
Total hot run time: 51585 ms

@doris-robot
Copy link

doris-robot commented Jan 21, 2025

TPC-DS: Total hot run time: 188016 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 04f7068ad050dca5395899c2340c2419fe21a7bb, data reload: false

query1	987	393	377	377
query2	6527	2093	2092	2092
query3	6798	215	216	215
query4	33504	23174	23055	23055
query5	4382	611	462	462
query6	296	222	183	183
query7	4605	482	297	297
query8	293	230	226	226
query9	9559	2580	2602	2580
query10	476	315	277	277
query11	17887	15157	15564	15157
query12	155	107	110	107
query13	1674	522	398	398
query14	10166	7070	6525	6525
query15	246	198	185	185
query16	8092	630	490	490
query17	1592	726	550	550
query18	2107	402	310	310
query19	196	181	150	150
query20	132	117	112	112
query21	211	122	107	107
query22	4448	4431	4253	4253
query23	33794	33101	33087	33087
query24	6583	2303	2285	2285
query25	504	457	381	381
query26	789	267	154	154
query27	2031	467	336	336
query28	5345	2450	2423	2423
query29	674	542	407	407
query30	235	185	165	165
query31	977	878	793	793
query32	128	62	59	59
query33	515	353	307	307
query34	757	861	504	504
query35	805	838	750	750
query36	1008	1040	942	942
query37	120	105	80	80
query38	4219	4190	4132	4132
query39	1469	1425	1427	1425
query40	206	127	105	105
query41	56	52	53	52
query42	118	103	101	101
query43	519	553	509	509
query44	1290	803	803	803
query45	186	175	174	174
query46	860	1061	650	650
query47	1888	1876	1816	1816
query48	389	401	314	314
query49	777	516	433	433
query50	644	658	406	406
query51	6947	6904	6922	6904
query52	107	109	95	95
query53	227	256	195	195
query54	500	510	429	429
query55	91	84	81	81
query56	288	290	291	290
query57	1202	1154	1085	1085
query58	249	236	254	236
query59	3033	3081	2972	2972
query60	279	272	262	262
query61	126	118	120	118
query62	786	722	635	635
query63	226	190	187	187
query64	3877	1039	676	676
query65	3228	3161	3163	3161
query66	877	404	307	307
query67	15848	15426	15387	15387
query68	4309	837	527	527
query69	476	303	261	261
query70	1209	1128	1137	1128
query71	372	300	259	259
query72	5935	3812	3895	3812
query73	639	749	360	360
query74	9914	9125	8816	8816
query75	3184	3266	2699	2699
query76	3131	1164	756	756
query77	455	364	284	284
query78	10144	10036	9324	9324
query79	2432	813	595	595
query80	1543	577	452	452
query81	573	276	234	234
query82	348	152	126	126
query83	185	178	147	147
query84	232	93	72	72
query85	766	357	308	308
query86	423	297	307	297
query87	4649	4496	4428	4428
query88	4013	2156	2153	2153
query89	386	326	295	295
query90	1657	196	195	195
query91	134	142	115	115
query92	65	59	54	54
query93	1645	870	537	537
query94	700	416	290	290
query95	348	280	267	267
query96	488	622	285	285
query97	2802	2906	2724	2724
query98	222	206	192	192
query99	1323	1408	1303	1303
Total cold run time: 283812 ms
Total hot run time: 188016 ms

@doris-robot
Copy link

doris-robot commented Jan 21, 2025

ClickBench: Total hot run time: 30.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 04f7068ad050dca5395899c2340c2419fe21a7bb, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.04	0.03
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.43	0.43	0.40
query6	1.16	0.65	0.67
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.50	0.52
query10	0.56	0.56	0.55
query11	0.14	0.11	0.10
query12	0.14	0.11	0.10
query13	0.61	0.60	0.60
query14	2.71	2.76	2.89
query15	0.89	0.84	0.82
query16	0.39	0.37	0.37
query17	1.07	1.04	1.00
query18	0.23	0.22	0.21
query19	1.87	1.75	1.99
query20	0.01	0.02	0.01
query21	15.35	0.95	0.59
query22	0.74	0.81	0.77
query23	15.13	1.43	0.64
query24	3.11	0.75	1.02
query25	0.18	0.20	0.10
query26	0.36	0.15	0.15
query27	0.05	0.04	0.04
query28	13.46	1.02	0.43
query29	12.59	3.97	3.27
query30	0.26	0.09	0.06
query31	2.83	0.61	0.37
query32	3.23	0.56	0.47
query33	2.99	3.04	3.06
query34	16.43	5.11	4.44
query35	4.49	4.51	4.46
query36	0.66	0.49	0.49
query37	0.10	0.06	0.05
query38	0.05	0.04	0.04
query39	0.04	0.02	0.02
query40	0.18	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 105.2 s
Total hot run time: 30.45 s

@dataroaring dataroaring merged commit 1d34eae into apache:master Jan 24, 2025
28 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 24, 2025
@Hastyshell
[fix](schema-change) Fix single column table could not rename columns (…
560706f 
…#47275)

Single column tables was not able to rename column due to light schema
change check in error way.
@github-actions github-actions bot mentioned this pull request Jan 24, 2025
Closed
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@Hastyshell @lzyy2024
[fix](schema-change) Fix single column table could not rename columns (…
efe1612 
…apache#47275)

Single column tables was not able to rename column due to light schema
change check in error way.
@gavinchou gavinchou added the p0_c label Feb 25, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Hastyshell @koarz
[fix](schema-change) Fix single column table could not rename columns (…
18a5651 
…apache#47275)

Single column tables was not able to rename column due to light schema
change check in error way.
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
@Hastyshell
[fix](schema-change) Fix single column table could not rename columns (…
baa09e5 
…#47275)

Single column tables was not able to rename column due to light schema
change check in error way.
@github-actions github-actions bot mentioned this pull request Jun 26, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Jun 26, 2025
@Hastyshell
[fix](schema-change) Fix single column table could not rename columns (…
5e2a483 
…#47275)

Single column tables was not able to rename column due to light schema
change check in error way.
@github-actions github-actions bot mentioned this pull request Jun 26, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jun 26, 2025
@github-actions @Hastyshell
branch-3.0: [fix](schema-change) Fix single column table could not re…
d1ecb32 
…name columns #47275 (#52340)

Cherry-picked from #47275

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
morrySnow pushed a commit that referenced this pull request Jun 27, 2025
@github-actions @Hastyshell
branch-3.1: [fix](schema-change) Fix single column table could not re…
3754ddd 
…name columns #47275 (#52341)

Cherry-picked from #47275

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@github-actions @Hastyshell @koarz
branch-3.0: [fix](schema-change) Fix single column table could not re…
0ee1004 
…name columns apache#47275 (apache#52340)

Cherry-picked from apache#47275

Co-authored-by: Siyang Tang <tangsiyang@selectdb.com>
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

@CalvinKirs CalvinKirs Awaiting requested review from CalvinKirs CalvinKirs is a code owner

@morningman morningman Awaiting requested review from morningman morningman is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Hastyshell @Thearas @doris-robot @gavinchou @dataroaring @morrySnow