-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [fix](merge-on-write) Remove pending delete bitmap check when commit_txn() #47136 #47283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41128 ms |
Contributor
Author
|
run cloud_p0 |
TPC-DS: Total hot run time: 198661 ms |
Contributor
Author
|
run p0 |
Contributor
Author
|
run performance |
1 similar comment
Contributor
Author
|
run performance |
TPC-H: Total hot run time: 40755 ms |
TPC-DS: Total hot run time: 198072 ms |
…_txn()` (apache#47136) Related PR: apache#46039 Problem Summary: apache#46039 introduce an defensive check when `commit_txn()`, but this may influence the commit process. This PR remove this check totally to eliminate this overhead.
021f60e to
01cc988
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40732 ms |
TPC-DS: Total hot run time: 197903 ms |
Contributor
Author
|
run performance |
TPC-H: Total hot run time: 41156 ms |
TPC-DS: Total hot run time: 191636 ms |
Contributor
Author
|
run performance |
TPC-H: Total hot run time: 41530 ms |
TPC-DS: Total hot run time: 192038 ms |
ClickBench: Total hot run time: 33.51 s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pick #47136