Skip to content

Conversation

@gavinchou
Copy link
Contributor

What problem does this PR solve?

ShowCacheHotSport is not supported by Nereids, use raw select stmt instead.

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32269 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6d66949d951035ff17aaea2b93f531514f58cecf, data reload: false

------ Round 1 ----------------------------------
q1	17587	5457	5355	5355
q2	2046	295	171	171
q3	10513	1226	740	740
q4	10205	998	527	527
q5	7546	2399	2141	2141
q6	187	169	138	138
q7	925	745	596	596
q8	9217	1344	1113	1113
q9	5138	4919	4903	4903
q10	6858	2311	1869	1869
q11	464	267	258	258
q12	352	361	213	213
q13	17782	3646	3089	3089
q14	230	235	208	208
q15	520	477	468	468
q16	627	609	581	581
q17	582	858	329	329
q18	7038	6545	6560	6545
q19	1520	960	532	532
q20	323	322	205	205
q21	2819	2221	1988	1988
q22	366	327	300	300
Total cold run time: 102845 ms
Total hot run time: 32269 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5467	5520	5461	5461
q2	240	336	251	251
q3	2222	2676	2291	2291
q4	1369	1814	1390	1390
q5	4315	4776	4696	4696
q6	162	161	124	124
q7	2035	1919	1836	1836
q8	2668	2802	2752	2752
q9	7330	7275	7240	7240
q10	3030	3282	2789	2789
q11	587	517	502	502
q12	668	725	604	604
q13	3501	3886	3248	3248
q14	283	304	275	275
q15	520	475	455	455
q16	641	680	642	642
q17	1261	1735	1280	1280
q18	7763	7395	7322	7322
q19	826	1157	1068	1068
q20	1994	2083	1926	1926
q21	5645	5280	4900	4900
q22	619	621	559	559
Total cold run time: 53146 ms
Total hot run time: 51611 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194662 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6d66949d951035ff17aaea2b93f531514f58cecf, data reload: false

query1	1313	970	919	919
query2	6303	2082	2062	2062
query3	10961	4370	4367	4367
query4	32472	23242	22860	22860
query5	3738	612	481	481
query6	274	200	209	200
query7	3994	493	296	296
query8	294	247	260	247
query9	9522	2695	2665	2665
query10	442	324	242	242
query11	17556	15271	15100	15100
query12	156	106	102	102
query13	1554	530	388	388
query14	9287	6821	7031	6821
query15	233	195	220	195
query16	7996	661	483	483
query17	1624	782	587	587
query18	2107	445	314	314
query19	192	192	158	158
query20	119	120	119	119
query21	206	127	105	105
query22	4471	4548	4381	4381
query23	34197	33398	33524	33398
query24	6991	2313	2284	2284
query25	506	484	396	396
query26	878	274	154	154
query27	2270	468	326	326
query28	5331	2514	2513	2513
query29	677	581	443	443
query30	208	194	165	165
query31	963	854	851	851
query32	93	69	62	62
query33	517	358	313	313
query34	763	886	515	515
query35	790	850	766	766
query36	1031	1061	973	973
query37	124	109	81	81
query38	4395	4345	4311	4311
query39	1532	1449	1452	1449
query40	199	114	100	100
query41	56	49	50	49
query42	136	108	104	104
query43	514	532	512	512
query44	1321	825	831	825
query45	190	180	178	178
query46	876	1069	658	658
query47	1952	1954	1908	1908
query48	382	406	323	323
query49	739	492	425	425
query50	635	668	395	395
query51	7193	7117	7016	7016
query52	101	102	93	93
query53	234	250	186	186
query54	479	492	425	425
query55	78	78	79	78
query56	271	274	255	255
query57	1240	1206	1142	1142
query58	251	229	230	229
query59	3090	3320	3278	3278
query60	286	273	262	262
query61	117	118	119	118
query62	825	758	679	679
query63	226	193	187	187
query64	4415	1027	671	671
query65	3355	3247	3175	3175
query66	1005	398	304	304
query67	15923	15799	15560	15560
query68	7562	807	541	541
query69	488	304	259	259
query70	1216	1159	1070	1070
query71	390	284	286	284
query72	6046	3907	3742	3742
query73	658	754	364	364
query74	10093	8956	8971	8956
query75	3168	3168	2638	2638
query76	3108	1173	774	774
query77	456	352	271	271
query78	10020	9955	9398	9398
query79	3407	802	582	582
query80	639	523	437	437
query81	528	278	241	241
query82	673	151	121	121
query83	169	173	156	156
query84	258	97	76	76
query85	787	418	304	304
query86	380	322	288	288
query87	4427	4505	4493	4493
query88	4786	2199	2202	2199
query89	408	318	291	291
query90	1786	188	190	188
query91	138	134	113	113
query92	65	59	52	52
query93	2061	894	535	535
query94	700	410	290	290
query95	333	336	253	253
query96	496	610	279	279
query97	2790	2843	2774	2774
query98	230	196	199	196
query99	1356	1335	1270	1270
Total cold run time: 291791 ms
Total hot run time: 194662 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6d66949d951035ff17aaea2b93f531514f58cecf, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.42	0.42	0.42
query6	1.19	0.66	0.67
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.59	0.51	0.51
query10	0.56	0.56	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.12
query13	0.61	0.60	0.60
query14	2.71	2.72	2.71
query15	0.88	0.82	0.83
query16	0.40	0.38	0.38
query17	1.01	1.02	1.03
query18	0.21	0.21	0.21
query19	1.93	1.85	2.02
query20	0.01	0.01	0.01
query21	15.37	0.93	0.59
query22	0.76	0.91	0.86
query23	14.99	1.42	0.63
query24	3.01	1.54	1.45
query25	0.24	0.14	0.16
query26	0.20	0.14	0.13
query27	0.06	0.06	0.05
query28	13.91	1.00	0.44
query29	12.55	3.94	3.31
query30	0.25	0.10	0.07
query31	2.80	0.59	0.39
query32	3.22	0.55	0.47
query33	2.98	3.13	3.07
query34	16.30	5.11	4.53
query35	4.53	4.55	4.53
query36	0.66	0.51	0.49
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.12 s
Total hot run time: 31.67 s

dataroaring
dataroaring previously approved these changes Jan 23, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 23, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jan 27, 2025
@doris-robot
Copy link

TPC-H: Total hot run time: 32480 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7f67e3d3818c921722a5ddbc1600a3ab1f1ed048, data reload: false

------ Round 1 ----------------------------------
q1	17589	5635	5510	5510
q2	2040	328	181	181
q3	10386	2158	712	712
q4	10217	986	530	530
q5	7565	2444	2223	2223
q6	219	178	134	134
q7	918	768	645	645
q8	9258	1510	1133	1133
q9	5362	4980	4929	4929
q10	6859	2342	1875	1875
q11	465	281	261	261
q12	352	365	212	212
q13	17762	3792	3052	3052
q14	226	234	212	212
q15	522	476	469	469
q16	624	618	590	590
q17	568	897	326	326
q18	6908	6558	6419	6419
q19	1225	1066	561	561
q20	320	336	192	192
q21	2923	2205	1990	1990
q22	371	336	324	324
Total cold run time: 102679 ms
Total hot run time: 32480 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5707	5699	5736	5699
q2	250	336	234	234
q3	2353	2665	2299	2299
q4	1380	1826	1366	1366
q5	4341	4805	4769	4769
q6	188	165	127	127
q7	2121	2005	1813	1813
q8	2697	2791	2778	2778
q9	7249	7248	7200	7200
q10	2991	3267	2778	2778
q11	588	532	491	491
q12	693	796	625	625
q13	3511	4049	3282	3282
q14	285	297	269	269
q15	529	456	466	456
q16	645	683	659	659
q17	1266	1747	1238	1238
q18	7543	7418	7325	7325
q19	822	1182	1244	1182
q20	2041	2034	1905	1905
q21	5770	5203	5031	5031
q22	596	590	542	542
Total cold run time: 53566 ms
Total hot run time: 52068 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184431 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7f67e3d3818c921722a5ddbc1600a3ab1f1ed048, data reload: false

query1	953	380	377	377
query2	6519	2061	2037	2037
query3	6790	220	216	216
query4	33270	23265	22942	22942
query5	4333	626	431	431
query6	286	203	186	186
query7	4593	478	305	305
query8	278	224	212	212
query9	9497	2671	2681	2671
query10	473	324	253	253
query11	17970	15343	14851	14851
query12	147	106	106	106
query13	1669	526	393	393
query14	8983	7625	7215	7215
query15	253	202	179	179
query16	8675	628	486	486
query17	1667	739	568	568
query18	2162	391	287	287
query19	228	177	153	153
query20	114	110	107	107
query21	207	120	101	101
query22	4349	4171	4171	4171
query23	33508	32853	32910	32853
query24	6399	2256	2255	2255
query25	491	452	388	388
query26	853	266	156	156
query27	1998	465	336	336
query28	5359	2461	2464	2461
query29	663	539	412	412
query30	231	192	164	164
query31	943	847	790	790
query32	90	62	69	62
query33	541	352	283	283
query34	753	864	490	490
query35	808	796	733	733
query36	984	1025	971	971
query37	113	101	73	73
query38	4156	4280	4089	4089
query39	1425	1366	1391	1366
query40	208	118	103	103
query41	54	53	50	50
query42	116	100	99	99
query43	506	515	483	483
query44	1302	808	805	805
query45	181	170	164	164
query46	843	1027	630	630
query47	1840	1855	1746	1746
query48	397	398	319	319
query49	743	491	395	395
query50	624	666	383	383
query51	4159	4171	4132	4132
query52	105	106	94	94
query53	223	251	196	196
query54	479	529	401	401
query55	87	86	82	82
query56	293	258	243	243
query57	1184	1149	1059	1059
query58	248	230	225	225
query59	3015	3116	2889	2889
query60	273	269	258	258
query61	119	117	113	113
query62	756	713	647	647
query63	221	186	186	186
query64	3378	1039	661	661
query65	3206	3187	3155	3155
query66	930	413	320	320
query67	15784	15344	15507	15344
query68	2369	829	546	546
query69	410	315	265	265
query70	1202	1162	1099	1099
query71	316	285	253	253
query72	5257	3927	3945	3927
query73	637	761	368	368
query74	9492	9104	8766	8766
query75	3153	3166	2642	2642
query76	2194	1160	767	767
query77	347	363	279	279
query78	10111	10190	9334	9334
query79	3395	789	589	589
query80	1906	521	429	429
query81	575	268	235	235
query82	846	148	122	122
query83	321	176	157	157
query84	242	87	71	71
query85	825	341	311	311
query86	494	306	292	292
query87	4447	4358	4337	4337
query88	3980	2203	2178	2178
query89	387	324	299	299
query90	1929	195	189	189
query91	131	143	106	106
query92	65	58	55	55
query93	2107	861	529	529
query94	747	404	294	294
query95	340	269	256	256
query96	485	618	285	285
query97	2751	2863	2704	2704
query98	217	210	199	199
query99	1281	1391	1237	1237
Total cold run time: 276964 ms
Total hot run time: 184431 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.84 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7f67e3d3818c921722a5ddbc1600a3ab1f1ed048, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.06	0.07
query4	1.62	0.10	0.10
query5	0.43	0.42	0.42
query6	1.17	0.67	0.64
query7	0.02	0.01	0.02
query8	0.04	0.03	0.02
query9	0.59	0.50	0.49
query10	0.57	0.57	0.55
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.75	2.82	2.84
query15	0.90	0.84	0.84
query16	0.38	0.40	0.38
query17	1.00	1.02	1.07
query18	0.23	0.20	0.20
query19	2.00	1.88	1.98
query20	0.01	0.01	0.01
query21	15.36	0.97	0.59
query22	0.76	0.73	0.60
query23	15.37	1.43	0.62
query24	3.25	2.05	0.95
query25	0.13	0.28	0.24
query26	0.30	0.15	0.14
query27	0.04	0.07	0.05
query28	13.57	1.03	0.43
query29	12.58	4.00	3.26
query30	0.25	0.09	0.06
query31	2.83	0.60	0.39
query32	3.22	0.55	0.46
query33	2.98	3.00	3.01
query34	16.70	5.20	4.48
query35	4.47	4.50	4.47
query36	0.65	0.49	0.51
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.92 s
Total hot run time: 30.84 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 3f33c5a into apache:master Feb 10, 2025
25 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
ShowCacheHotSport is not supported by Nereids, use raw select stmt
instead.
dataroaring pushed a commit that referenced this pull request Feb 11, 2025
#47713)

Cherry-picked from #47332

Co-authored-by: Gavin Chou <gavin@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
ShowCacheHotSport is not supported by Nereids, use raw select stmt
instead.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
ShowCacheHotSport is not supported by Nereids, use raw select stmt
instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants