Skip to content

[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling #47536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Feb 6, 2025
Merged

[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling #47536

gavinchou merged 1 commit into from
Feb 6, 2025

Conversation

@Yukang-Lian
Copy link
Collaborator

@Yukang-Lian Yukang-Lian commented Feb 6, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #47475 #47486

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

Yukang-Lian commented Feb 6, 2025

run buildall

@gavinchou
Copy link
Contributor

gavinchou commented Feb 6, 2025

Add UT in a new PR

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

PR approved by anyone and no changes requested.

Hastyshell
Hastyshell approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@Hastyshell Hastyshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

airborne12
airborne12 reviewed Feb 6, 2025
View reviewed changes
airborne12
airborne12 approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit 3fb37ce into apache:master Feb 6, 2025
32 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 6, 2025
@Yukang-Lian
[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling (#…
b89d55d 
…47536)

Related PR: #47475 #47486
@github-actions github-actions bot mentioned this pull request Feb 6, 2025
Merged
gavinchou pushed a commit that referenced this pull request Feb 7, 2025
@github-actions @Yukang-Lian
branch-3.0: [Fix](recycler) Fix retain inverted indexes in tmp rowset…
814e4d7 
… recycling #47536 (#47546)

Cherry-picked from #47536

Co-authored-by: abmdocrt <lianyukang@selectdb.com>
@gavinchou gavinchou mentioned this pull request Feb 18, 2025
Closed
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@Yukang-Lian @lzyy2024
[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling (a…
ec7c52c 
…pache#47536)

Related PR: apache#47475 apache#47486
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@Yukang-Lian @koarz
[Fix](recycler) Fix retain inverted indexes in tmp rowset recycling (a…
6206aac 
…pache#47536)

Related PR: apache#47475 apache#47486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airborne12 airborne12 airborne12 approved these changes

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring dataroaring is a code owner

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@Hastyshell Hastyshell Hastyshell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Yukang-Lian @hello-stephen @gavinchou @airborne12 @Hastyshell @wm1581066 @dataroaring