Skip to content

[fix](index compaction)Add column unique id check before use #47562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qidaye merged 2 commits into from
Feb 7, 2025
Merged

[fix](index compaction)Add column unique id check before use #47562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d744114
[opt](index compaction)Add column unique id check before use
Feb 6, 2025
54a26c6
opt
Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions be/src/olap/compaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,11 @@ void Compaction::construct_index_compaction_columns(RowsetWriterContext& ctx) {
continue;
}
auto col_unique_id = col_unique_ids[0];
if (!_cur_tablet_schema->has_column_unique_id(col_unique_id)) {
LOG(WARNING) << "tablet[" << _tablet->tablet_id() << "] column_unique_id["
<< col_unique_id << "] not found, will skip index compaction";
continue;
}
// Avoid doing inverted index compaction on non-slice type columns
if (!field_is_slice_type(_cur_tablet_schema->column_by_uid(col_unique_id).type())) {
continue;
Expand Down
4 changes: 4 additions & 0 deletions be/src/olap/tablet_schema.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,10 @@ bool TabletSchema::exist_column(const std::string& field_name) const {
return _field_name_to_index.contains(StringRef {field_name});
}

bool TabletSchema::has_column_unique_id(int32_t col_unique_id) const {
return _field_id_to_index.contains(col_unique_id);
}

Status TabletSchema::have_column(const std::string& field_name) const {
if (!_field_name_to_index.contains(StringRef(field_name))) {
return Status::Error<ErrorCode::INTERNAL_ERROR>(
Expand Down
1 change: 1 addition & 0 deletions be/src/olap/tablet_schema.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,7 @@ class TabletSchema : public MetadataAdder<TabletSchema> {
Result<const TabletColumn*> column(const std::string& field_name) const;
Status have_column(const std::string& field_name) const;
bool exist_column(const std::string& field_name) const;
bool has_column_unique_id(int32_t col_unique_id) const;
const TabletColumn& column_by_uid(int32_t col_unique_id) const;
TabletColumn& mutable_column_by_uid(int32_t col_unique_id);
TabletColumn& mutable_column(size_t ordinal);
Expand Down
Loading