Skip to content

Conversation

@freemandealer
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@Thearas
Copy link
Contributor

Thearas commented Feb 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 31571 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 00c6a67c94bddf56054f507e216e6bef5528c2ab, data reload: false

------ Round 1 ----------------------------------
q1	17602	5177	5087	5087
q2	2049	334	176	176
q3	10361	1229	759	759
q4	10239	1037	544	544
q5	7595	2377	2298	2298
q6	176	168	133	133
q7	890	729	596	596
q8	9305	1287	1091	1091
q9	4865	4729	4524	4524
q10	6872	2310	1916	1916
q11	481	271	249	249
q12	346	349	220	220
q13	18065	3631	3189	3189
q14	231	242	213	213
q15	499	473	470	470
q16	641	624	575	575
q17	577	853	335	335
q18	6555	6278	6194	6194
q19	1657	945	553	553
q20	303	326	189	189
q21	2751	2197	1962	1962
q22	364	332	298	298
Total cold run time: 102424 ms
Total hot run time: 31571 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5126	5056	5103	5056
q2	237	327	232	232
q3	2142	2722	2292	2292
q4	1464	1914	1422	1422
q5	4197	4127	4172	4127
q6	204	161	122	122
q7	1876	1817	1637	1637
q8	2556	2556	2554	2554
q9	7164	7143	7100	7100
q10	3031	3205	2743	2743
q11	580	526	483	483
q12	711	765	604	604
q13	3575	3844	3349	3349
q14	276	299	271	271
q15	509	485	470	470
q16	625	690	639	639
q17	1140	1590	1343	1343
q18	7563	7326	7366	7326
q19	793	860	1005	860
q20	1968	1999	1855	1855
q21	5429	5063	4776	4776
q22	605	573	545	545
Total cold run time: 51771 ms
Total hot run time: 49806 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190677 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 00c6a67c94bddf56054f507e216e6bef5528c2ab, data reload: false

query1	1296	973	934	934
query2	6234	1859	1887	1859
query3	11014	4457	4411	4411
query4	52087	24953	23194	23194
query5	5334	635	479	479
query6	337	190	208	190
query7	4912	559	315	315
query8	302	234	223	223
query9	5625	2494	2479	2479
query10	441	305	258	258
query11	15203	15257	14931	14931
query12	152	106	104	104
query13	1037	522	382	382
query14	10095	6862	6518	6518
query15	218	229	185	185
query16	7059	662	481	481
query17	1097	746	603	603
query18	1521	431	325	325
query19	210	220	175	175
query20	125	129	122	122
query21	210	130	117	117
query22	4384	4398	4240	4240
query23	34070	33432	33412	33412
query24	5678	2470	2460	2460
query25	510	516	490	490
query26	720	301	158	158
query27	1926	505	330	330
query28	2726	2424	2416	2416
query29	597	586	430	430
query30	212	187	154	154
query31	912	903	789	789
query32	80	62	62	62
query33	462	372	310	310
query34	779	907	518	518
query35	815	832	733	733
query36	1027	1001	918	918
query37	131	108	85	85
query38	4264	4359	4292	4292
query39	1492	1444	1442	1442
query40	216	118	111	111
query41	56	51	49	49
query42	135	112	108	108
query43	511	530	489	489
query44	1363	800	817	800
query45	182	172	175	172
query46	942	1145	676	676
query47	1840	1877	1843	1843
query48	392	424	316	316
query49	704	518	426	426
query50	796	808	430	430
query51	4227	4262	4286	4262
query52	107	111	97	97
query53	256	287	199	199
query54	508	500	430	430
query55	87	77	84	77
query56	265	294	275	275
query57	1160	1207	1117	1117
query58	247	257	255	255
query59	2795	2853	2695	2695
query60	305	288	267	267
query61	122	120	120	120
query62	760	793	691	691
query63	257	199	192	192
query64	1726	1066	743	743
query65	3338	3264	3165	3165
query66	791	402	299	299
query67	16049	15663	15640	15640
query68	6085	795	508	508
query69	537	315	267	267
query70	1236	1051	1103	1051
query71	429	299	282	282
query72	5986	3755	3875	3755
query73	1282	814	356	356
query74	9147	9184	8859	8859
query75	3291	3200	2721	2721
query76	3920	1238	778	778
query77	515	373	288	288
query78	10191	10056	9214	9214
query79	2794	834	608	608
query80	733	562	458	458
query81	520	286	247	247
query82	620	159	122	122
query83	180	174	155	155
query84	295	96	77	77
query85	771	367	314	314
query86	369	310	304	304
query87	4506	4468	4390	4390
query88	3594	2198	2151	2151
query89	430	325	277	277
query90	1654	194	193	193
query91	137	144	114	114
query92	75	65	64	64
query93	2466	1045	593	593
query94	740	423	300	300
query95	370	267	263	263
query96	489	618	270	270
query97	2783	2878	2732	2732
query98	232	209	207	207
query99	1334	1404	1291	1291
Total cold run time: 293142 ms
Total hot run time: 190677 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.06% (11016/26193)
Line Coverage: 32.34% (93012/287634)
Region Coverage: 31.51% (47696/151388)
Branch Coverage: 27.52% (24132/87674)
Coverage Report: http://coverage.selectdb-in.cc/coverage/00c6a67c94bddf56054f507e216e6bef5528c2ab_00c6a67c94bddf56054f507e216e6bef5528c2ab/report/index.html

@doris-robot
Copy link

ClickBench: Total hot run time: 30.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 00c6a67c94bddf56054f507e216e6bef5528c2ab, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.09	0.10
query5	0.40	0.42	0.40
query6	1.17	0.67	0.67
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.59	0.52	0.52
query10	0.59	0.58	0.56
query11	0.16	0.10	0.11
query12	0.14	0.11	0.11
query13	0.62	0.60	0.61
query14	2.79	2.70	2.80
query15	0.94	0.85	0.88
query16	0.38	0.38	0.37
query17	1.01	1.01	1.01
query18	0.22	0.20	0.20
query19	1.90	1.78	1.95
query20	0.02	0.01	0.01
query21	15.36	0.89	0.54
query22	0.75	1.12	0.57
query23	15.11	1.39	0.59
query24	6.68	1.55	0.90
query25	0.52	0.25	0.12
query26	0.66	0.16	0.14
query27	0.05	0.05	0.05
query28	10.38	0.91	0.45
query29	12.57	3.89	3.25
query30	0.25	0.09	0.07
query31	2.83	0.59	0.38
query32	3.22	0.55	0.48
query33	2.97	2.98	3.04
query34	15.74	5.12	4.46
query35	4.49	4.50	4.50
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.02	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.69 s
Total hot run time: 30.43 s

@freemandealer
Copy link
Contributor Author

run external

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit 809fae9 into apache:master Feb 7, 2025
25 of 28 checks passed
dataroaring pushed a commit that referenced this pull request Feb 8, 2025
 (#47615)

Cherry-picked from #47609

Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants