Skip to content

branch-3.0: [chore](file cache) Disable show cache hotspot stmt #47332 #47713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Feb 11, 2025
Merged

branch-3.0: [chore](file cache) Disable show cache hotspot stmt #47332 #47713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions fe/fe-common/src/main/java/org/apache/doris/common/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3233,6 +3233,10 @@ public static int metaServiceRpcRetryTimes() {
"Max retry times when schema change failed in cloud model, default is 3."})
public static int schema_change_max_retry_time = 3;

@ConfField(mutable = true, description = {"是否允许使用ShowCacheHotSpotStmt语句",
"Whether to enable the use of ShowCacheHotSpotStmt, default is false."})
public static boolean enable_show_file_cache_hotspot_stmt = false;

// ATTN: DONOT add any config not related to cloud mode here
// ATTN: DONOT add any config not related to cloud mode here
// ATTN: DONOT add any config not related to cloud mode here
Expand Down
5 changes: 5 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/ShowCacheHotSpotStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,11 @@ public void analyze(Analyzer analyzer) throws UserException {
whereExpr.add(String.format("%s = '%s' ", whereExprVariables.get(i - 1), whereExprValues.get(i)));
}
metaDataPos = whereExpr.size();
if (!Config.enable_show_file_cache_hotspot_stmt) {
LOG.info("show cache hotspot stmt is deprecated, use select stmt instead: " + generateQueryString());
throw new UserException("show cache hotspot stmt is deprecated, please use select stmt instead: "
+ generateQueryString());
}
}

@Override
Expand Down