[fix](Export) Fix the issue where the show export status stays stuck on EXPORTING. #47974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31573 ms |
TPC-DS: Total hot run time: 190806 ms |
ClickBench: Total hot run time: 30.36 s |
morningman
reviewed
Feb 18, 2025
|
|
||
| public void cancelMemoryTask(Long taskId) throws JobException { | ||
| try { | ||
| if (taskExecutorMap.containsKey(taskId)) { |
Contributor
There was a problem hiding this comment.
I suggest to get the task from map first, and then check if it is null and do the cancel.
Because the task may be removed after containsKey() and before get(),
this 2 methods are not atomic
| private void exportExportJob() { | ||
| private void exportExportJob() throws JobException { | ||
| if (getState() == ExportJobState.CANCELLED || getState() == ExportJobState.FINISHED) { | ||
| throw new JobException("export job has been cancelled or finished."); |
Contributor
There was a problem hiding this comment.
Print the job state in error msg.
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31625 ms |
TPC-DS: Total hot run time: 189967 ms |
ClickBench: Total hot run time: 30.03 s |
wuwenchi
approved these changes
Feb 19, 2025
hubgeter
approved these changes
Feb 19, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…on EXPORTING. (#47974) Problem Summary: Each Export task will be deleted after execution in the finally block of the TaskHandler#onTransientTaskHandle() method. Therefore, when removing a task in the TransientTaskManager#cancelMemoryTask method, there should be a check to see if the task exists. Otherwise, a null pointer exception may occur, causing the Export Job status update to fail.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 19, 2025
…on EXPORTING. (#47974) Problem Summary: Each Export task will be deleted after execution in the finally block of the TaskHandler#onTransientTaskHandle() method. Therefore, when removing a task in the TransientTaskManager#cancelMemoryTask method, there should be a check to see if the task exists. Otherwise, a null pointer exception may occur, causing the Export Job status update to fail.
lzyy2024
pushed a commit
to lzyy2024/doris
that referenced
this pull request
Feb 21, 2025
…on EXPORTING. (apache#47974) Problem Summary: Each Export task will be deleted after execution in the finally block of the TaskHandler#onTransientTaskHandle() method. Therefore, when removing a task in the TransientTaskManager#cancelMemoryTask method, there should be a check to see if the task exists. Otherwise, a null pointer exception may occur, causing the Export Job status update to fail.
3 tasks
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2025
### What problem does this PR solve? Related PR: #47974 Problem Summary: When cancel task, the task should be removed from `taskExecutorMap`, otherwise, if `tryPublishTask()` failed when `addMemoryTask`, the task will be leaked in `taskExecutorMap`
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…on EXPORTING. (apache#47974) Problem Summary: Each Export task will be deleted after execution in the finally block of the TaskHandler#onTransientTaskHandle() method. Therefore, when removing a task in the TransientTaskManager#cancelMemoryTask method, there should be a check to see if the task exists. Otherwise, a null pointer exception may occur, causing the Export Job status update to fail.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? Related PR: apache#47974 Problem Summary: When cancel task, the task should be removed from `taskExecutorMap`, otherwise, if `tryPublishTask()` failed when `addMemoryTask`, the task will be leaked in `taskExecutorMap`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Summary:
Each Export task will be deleted after execution in the finally block of the TaskHandler#onTransientTaskHandle() method. Therefore, when removing a task in the TransientTaskManager#cancelMemoryTask method, there should be a check to see if the task exists. Otherwise, a null pointer exception may occur, causing the Export Job status update to fail.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)