Skip to content

[optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms" #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
caiconghui merged 9 commits into from
Oct 30, 2020
Merged

[optimize] optimize default value for thriftserver's config key "thrift_client_timeout_ms" #4808

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c6404c1
Merge pull request #1 from apache/master
Jul 2, 2020
e90a783
Merge pull request #2 from apache/master
Aug 16, 2020
6e104ef
Merge pull request #3 from apache/master
Sep 30, 2020
dd2ed06
Merge pull request #4 from apache/master
Oct 6, 2020
7740c47
Merge pull request #5 from apache/master
Oct 14, 2020
95c2bd1
Merge pull request #7 from apache/master
Oct 27, 2020
e8330af
optimize default value for thrift server's config key "thrift_client…
Oct 27, 2020
f7537fb
update default value for thrift_client_timeout_ms
Oct 30, 2020
146a73b
update default value for thrift_client_timeout_ms
Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/common/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,10 +316,10 @@ public class Config extends ConfigBase {

/**
* The connection timeout and socket timeout config for thrift server
* The value for thrift_client_timeout_ms is set to be larger than zero to prevent
* some hang up problems in java.net.SocketInputStream.socketRead0
* The default value for thrift_client_timeout_ms is set to be zero to prevent readtimeout
*
Copy link
Contributor

@caiconghui caiconghui Oct 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

The connection timeout and socket timeout config for thrift server
The default value for thrift_client_timeout_ms is set to be zero to prevent readtimeout

@ConfField public static int thrift_client_timeout_ms = 0;

*/
@ConfField public static int thrift_client_timeout_ms = 30000;
Copy link
Contributor

@chaoyli chaoyli Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when will fe close the socket frequently?

Copy link
Member Author

@francisoliverlee francisoliverlee Oct 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in our case, query information_schema.tables. i find fe would send a TCP RST command(try tcpdump 9020 in fe) to be to close the socket becasuse of thrift_client_timeout_ms is meet, the be log comes "no more data to read", the be would retry in 1s(default).

@ConfField public static int thrift_client_timeout_ms = 0;

/**
* The backlog_num for thrift server
Expand Down