Skip to content

[enhance](mtmv)mtmv not refresh cache of external table before run task #48172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 3 commits into from
Mar 5, 2025
Merged

[enhance](mtmv)mtmv not refresh cache of external table before run task #48172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58ec4d5
1
zddr Feb 21, 2025
9d19dfc
1
zddr Feb 25, 2025
20357c2
Merge branch 'master' into mv_not_refresh_cache
zddr Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1072,8 +1072,6 @@ public boolean isPartitionedTable() {

@Override
public void beforeMTMVRefresh(MTMV mtmv) throws DdlException {
Env.getCurrentEnv().getRefreshManager()
.refreshTable(getCatalog().getName(), getDbName(), getName(), true);
}

public HoodieTableMetaClient getHudiClient() {
Expand Down
2 changes: 0 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergExternalTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,6 @@ private IcebergSnapshotCacheValue getIcebergSnapshotCacheValue() {

@Override
public void beforeMTMVRefresh(MTMV mtmv) throws DdlException {
Env.getCurrentEnv().getRefreshManager()
.refreshTable(getCatalog().getName(), getDbName(), getName(), true);
}

@Override
Expand Down
2 changes: 0 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonExternalTable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ public long fetchRowCount() {

@Override
public void beforeMTMVRefresh(MTMV mtmv) throws DdlException {
Env.getCurrentEnv().getRefreshManager()
.refreshTable(getCatalog().getName(), getDbName(), getName(), true);
}

@Override
Expand Down
12 changes: 12 additions & 0 deletions regression-test/suites/mtmv_p0/test_hive_refresh_mtmv.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke
// hive data change
logger.info("hive sql: " + insert_str)
hive_docker """ ${insert_str} """
sql """
REFRESH catalog ${catalog_name}
"""
sql """
REFRESH MATERIALIZED VIEW ${mvName} auto
"""
Expand All @@ -117,6 +120,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke
"""
logger.info("hive sql: " + add_partition2021_str)
hive_docker """ ${add_partition2021_str} """
sql """
REFRESH catalog ${catalog_name}
"""
sql """
REFRESH MATERIALIZED VIEW ${mvName} auto
"""
Expand All @@ -133,6 +139,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke
"""
logger.info("hive sql: " + drop_partition2021_str)
hive_docker """ ${drop_partition2021_str} """
sql """
REFRESH catalog ${catalog_name}
"""
sql """
REFRESH MATERIALIZED VIEW ${mvName} auto
"""
Expand All @@ -148,6 +157,9 @@ suite("test_hive_refresh_mtmv", "p0,external,hive,external_docker,external_docke
"""
logger.info("hive sql: " + rename_column_str)
hive_docker """ ${rename_column_str} """
sql """
REFRESH catalog ${catalog_name}
"""
sql """
REFRESH MATERIALIZED VIEW ${mvName} complete
"""
Expand Down
Loading