Skip to content

[fix](schema-change) Remove incorrect assertion for tablet state after committing sc job #48219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Feb 27, 2025
Merged

[fix](schema-change) Remove incorrect assertion for tablet state after committing sc job #48219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions be/src/cloud/cloud_schema_change_job.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,13 +415,6 @@ Status CloudSchemaChangeJob::_convert_historical_rowsets(const SchemaChangeParam
const auto& stats = finish_resp.stats();
{
std::unique_lock wlock(_new_tablet->get_header_lock());
// new_tablet's state MUST be `TABLET_NOTREADY`, because we won't sync a new tablet in schema change job
DCHECK(_new_tablet->tablet_state() == TABLET_NOTREADY);
if (_new_tablet->tablet_state() != TABLET_NOTREADY) [[unlikely]] {
LOG(ERROR) << "invalid tablet state, tablet_id=" << _new_tablet->tablet_id();
return Status::InternalError("invalid tablet state, tablet_id={}",
_new_tablet->tablet_id());
}
_new_tablet->add_rowsets(std::move(_output_rowsets), true, wlock);
_new_tablet->set_cumulative_layer_point(_output_cumulative_point);
_new_tablet->reset_approximate_stats(stats.num_rowsets(), stats.num_segments(),
Expand Down
Loading