Skip to content

[Improvement](column) add santy check and add some fix for ColumnString #47964 #48513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 5 commits into from
Mar 20, 2025
Merged

[Improvement](column) add santy check and add some fix for ColumnString #47964 #48513

dataroaring merged 5 commits into from
Mar 20, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Mar 2, 2025

pick part of #47964

@Thearas
Copy link
Contributor

Thearas commented Mar 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 2, 2025

run buildall

1 similar comment
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 5, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 5, 2025

run buildall

4 similar comments
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 6, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 7, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 10, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 13, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 13, 2025

BE UT Coverage Report

Increment line coverage 62.50% (30/48) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.90% (10162/26125)
Line Coverage 30.31% (86583/285672)
Region Coverage 29.35% (44481/151533)
Branch Coverage 25.87% (22621/87450)

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 14, 2025

run buildall

2 similar comments
@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 18, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Mar 19, 2025

run buildall

dataroaring
dataroaring approved these changes Mar 20, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 2b3f8ee into apache:branch-3.0 Mar 20, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BiteTheDDDDt @Thearas @hello-stephen @dataroaring