-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](Prepared Statment) Fix exec prepared insert stmt in non master error #48689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
594e881 to
bf60474
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32623 ms |
TPC-DS: Total hot run time: 185542 ms |
ClickBench: Total hot run time: 30.67 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
bf60474 to
0890506
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32943 ms |
TPC-DS: Total hot run time: 192046 ms |
ClickBench: Total hot run time: 31.41 s |
|
I test this pr, and it works well in my cluster. |
|
run beut |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add test case? example pick none master frontend and send insert/delete/update prepared requests
The pipeline doris cluster has only one FE. |
902b363 to
c5cbffc
Compare
|
run buildall |
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
…error (apache#48689) When client send a prepare command to non master frontend like `INSERT INTO xxxx VALUES(?)` and then execute it whith some params. The non master frontend will forward the origin stmt to master and analyze error will occur. In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
… non master error (apache#48689) (apache#52266) backport: apache#48689 Co-authored-by: Lijia Liu <liutang123@yeah.net>
What problem does this PR solve?
When client send a prepare command to non master frontend like
INSERT INTO xxxx VALUES(?)and then execute it whith some params.The non master frontend will forward the origin stmt to master and analyze error will occur.
In this PR, we forward the origin sql and param to master. Master prepare a logic plan with place holder and then use the param and logic plan to generate physical plan.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)