Skip to content

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Mar 6, 2025

What problem does this PR solve?

when nereids cast invalid date literal to date like type, it will throws exceptions:

select '' = cast('2020-10-20' as date);
(1105, 'errCode = 2, detailMessage = date/datetime literal [] is invalid')

But old planner will not throw exceptions, so let neredis don't throw exceptions too.

This PR is pick code from: #40202

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yujun777
Copy link
Contributor Author

yujun777 commented Mar 6, 2025

run buildall

@yujun777 yujun777 marked this pull request as ready for review March 10, 2025 10:10
@yujun777 yujun777 requested a review from yiguolei as a code owner March 10, 2025 10:10
@yujun777
Copy link
Contributor Author

run buildall

@yujun777 yujun777 changed the title branch-2.1: [fix] fix cast literal to date like throw exception branch-2.1: [fix] fix cast literal to date like throw exception #40202 Mar 10, 2025
@yujun777 yujun777 changed the title branch-2.1: [fix] fix cast literal to date like throw exception #40202 branch-2.1: [fix](nereids) fix cast literal to date like throw exception Mar 10, 2025
@wm1581066 wm1581066 added usercase Important user case type label dev/2.1.x dev/3.0.x and removed dev/3.0.x labels Mar 11, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 11, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 78c9f73 into apache:branch-2.1 Mar 11, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants