Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #48934

fix colocate agg + join compute wrong result, introduced by #41730
@github-actions github-actions bot requested a review from dataroaring as a code owner March 12, 2025 11:09
@Thearas
Copy link
Contributor

Thearas commented Mar 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 12, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 12, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40255 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 73d81dc1a1c2431e9ffe51ea81c447f502180e16, data reload: false

------ Round 1 ----------------------------------
q1	17576	6918	6598	6598
q2	2080	168	163	163
q3	10657	1086	1130	1086
q4	10557	742	724	724
q5	7775	2893	2859	2859
q6	232	142	135	135
q7	1026	631	640	631
q8	9370	2003	2082	2003
q9	6640	6407	6373	6373
q10	6996	2203	2309	2203
q11	474	269	258	258
q12	411	217	212	212
q13	17763	3020	3003	3003
q14	248	208	221	208
q15	510	465	480	465
q16	688	591	581	581
q17	986	562	520	520
q18	7398	6655	6595	6595
q19	1399	1135	1174	1135
q20	481	213	198	198
q21	4076	3383	3319	3319
q22	1108	1009	986	986
Total cold run time: 108451 ms
Total hot run time: 40255 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6615	6581	6565	6565
q2	355	233	230	230
q3	2914	2720	2944	2720
q4	2077	1825	1751	1751
q5	5774	5754	5735	5735
q6	216	131	130	130
q7	2209	1814	1821	1814
q8	3406	3597	3548	3548
q9	9044	8918	8926	8918
q10	3590	3566	3499	3499
q11	597	493	492	492
q12	843	608	586	586
q13	8882	3200	3208	3200
q14	317	278	284	278
q15	508	470	476	470
q16	688	641	658	641
q17	1864	1630	1628	1628
q18	8145	7881	7820	7820
q19	1700	1712	1488	1488
q20	2087	1832	1826	1826
q21	5464	5378	5345	5345
q22	1137	1014	1054	1014
Total cold run time: 68432 ms
Total hot run time: 59698 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198525 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 73d81dc1a1c2431e9ffe51ea81c447f502180e16, data reload: false

query1	1321	919	925	919
query2	6206	2065	2062	2062
query3	10767	4186	4402	4186
query4	62092	28846	23516	23516
query5	5213	477	473	473
query6	400	183	183	183
query7	5457	321	324	321
query8	308	230	239	230
query9	8483	2585	2591	2585
query10	476	280	264	264
query11	17580	15622	15684	15622
query12	164	108	104	104
query13	1421	453	431	431
query14	10467	7579	7449	7449
query15	199	186	186	186
query16	7373	502	493	493
query17	1129	592	604	592
query18	1878	339	333	333
query19	227	160	159	159
query20	119	112	110	110
query21	210	105	110	105
query22	4599	4306	4737	4306
query23	34753	34310	34222	34222
query24	6168	3022	3026	3022
query25	546	457	451	451
query26	669	174	173	173
query27	1738	359	358	358
query28	4310	2478	2414	2414
query29	694	441	431	431
query30	239	160	162	160
query31	1020	827	848	827
query32	67	54	63	54
query33	475	290	294	290
query34	941	513	520	513
query35	853	726	752	726
query36	1114	965	994	965
query37	118	69	74	69
query38	4118	4071	4072	4071
query39	1544	1441	1479	1441
query40	200	99	103	99
query41	52	49	52	49
query42	117	104	101	101
query43	531	489	491	489
query44	1253	825	819	819
query45	182	167	169	167
query46	1156	773	740	740
query47	2010	1923	1946	1923
query48	490	401	394	394
query49	724	392	398	392
query50	860	443	432	432
query51	7441	7197	7297	7197
query52	112	96	95	95
query53	269	197	192	192
query54	603	479	497	479
query55	84	77	83	77
query56	296	256	247	247
query57	1274	1176	1156	1156
query58	218	216	214	214
query59	3129	2939	3034	2939
query60	285	270	259	259
query61	117	124	120	120
query62	749	679	654	654
query63	223	191	191	191
query64	1417	663	638	638
query65	3273	3193	3219	3193
query66	700	294	301	294
query67	15945	15614	15596	15596
query68	4221	604	578	578
query69	433	266	265	265
query70	1165	1105	1131	1105
query71	350	267	259	259
query72	6368	3763	3967	3763
query73	763	354	354	354
query74	10535	9296	9158	9158
query75	3373	2683	2635	2635
query76	1940	1118	1163	1118
query77	529	273	283	273
query78	10539	9615	9536	9536
query79	1412	598	602	598
query80	879	446	438	438
query81	525	243	238	238
query82	1304	91	93	91
query83	254	149	147	147
query84	295	87	79	79
query85	903	306	293	293
query86	337	305	284	284
query87	4445	4248	4251	4248
query88	3894	2397	2393	2393
query89	422	292	297	292
query90	1989	186	201	186
query91	182	149	172	149
query92	65	51	51	51
query93	1944	560	555	555
query94	746	304	306	304
query95	356	261	266	261
query96	650	288	280	280
query97	3309	3123	3189	3123
query98	219	211	199	199
query99	1546	1336	1310	1310
Total cold run time: 315058 ms
Total hot run time: 198525 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.11 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 73d81dc1a1c2431e9ffe51ea81c447f502180e16, data reload: false

query1	0.03	0.02	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.51	0.50	0.51
query6	1.13	0.72	0.73
query7	0.02	0.02	0.01
query8	0.06	0.03	0.03
query9	0.56	0.50	0.51
query10	0.54	0.55	0.56
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.63	0.60	0.61
query14	2.87	2.76	2.70
query15	0.90	0.83	0.82
query16	0.38	0.39	0.38
query17	1.03	1.02	1.00
query18	0.24	0.22	0.20
query19	1.86	1.83	2.03
query20	0.01	0.01	0.02
query21	15.36	0.58	0.60
query22	2.67	2.02	1.84
query23	16.96	0.84	0.81
query24	3.57	1.38	1.05
query25	0.26	0.12	0.05
query26	0.54	0.14	0.13
query27	0.05	0.06	0.04
query28	9.72	0.48	0.45
query29	12.58	3.18	3.19
query30	0.24	0.06	0.07
query31	2.86	0.40	0.38
query32	3.23	0.48	0.46
query33	3.02	3.09	3.02
query34	17.02	4.51	4.47
query35	4.53	4.53	4.50
query36	0.70	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.76 s
Total hot run time: 32.11 s

@924060929 924060929 closed this Mar 12, 2025
@CalvinKirs CalvinKirs deleted the auto-pick-48934-branch-3.0 branch March 28, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants