[fix](nereids) fix generate column need add cast in stream load #49167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
feiniaofeiafei
force-pushed
the
fix_generated_column
branch
from
c1a6f62 to
a6c62b6
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32124 ms |
TPC-DS: Total hot run time: 185040 ms |
ClickBench: Total hot run time: 31.74 s |
morrySnow
reviewed
Mar 20, 2025
Comment on lines
+1036
to
+1043
| Expression expressionForLoad = expression.rewriteDownShortCircuit(e -> { | ||
| if (e instanceof SlotReference && !(e.getDataType() instanceof CharacterType)) { | ||
| return new Cast(e, e.getDataType()); | ||
| } | ||
| return e; | ||
| }); |
Contributor
There was a problem hiding this comment.
add comment to explain why need cast e to itself's type
feiniaofeiafei
force-pushed
the
fix_generated_column
branch
2 times, most recently
from
afcb04d to
09e59c1
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34082 ms |
TPC-DS: Total hot run time: 186288 ms |
ClickBench: Total hot run time: 31.05 s |
morrySnow
force-pushed
the
fix_generated_column
branch
from
09e59c1 to
35d36f1
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 34077 ms |
TPC-DS: Total hot run time: 192277 ms |
ClickBench: Total hot run time: 30.58 s |
morrySnow
force-pushed
the
fix_generated_column
branch
from
35d36f1 to
9e445b8
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 33953 ms |
TPC-DS: Total hot run time: 191908 ms |
ClickBench: Total hot run time: 31.42 s |
Contributor
Author
|
run feut |
starocean999
approved these changes
Apr 14, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Apr 14, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 14, 2025
### What problem does this PR solve? Related PR: #35284 Problem Summary: Generate column need add cast(casting slot to its own type) in stream load, because when loading data(stream load and other load), the slots reading from files are string type. So we need to cast it to its own type to avoid error.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 17, 2025
…he#49167) ### What problem does this PR solve? Related PR: apache#35284 Problem Summary: Generate column need add cast(casting slot to its own type) in stream load, because when loading data(stream load and other load), the slots reading from files are string type. So we need to cast it to its own type to avoid error.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…he#49167) ### What problem does this PR solve? Related PR: apache#35284 Problem Summary: Generate column need add cast(casting slot to its own type) in stream load, because when loading data(stream load and other load), the slots reading from files are string type. So we need to cast it to its own type to avoid error.
suxiaogang223
pushed a commit
to suxiaogang223/doris
that referenced
this pull request
Jul 15, 2025
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #35284
Problem Summary:
Generate column need add cast(casting slot to its own type) in stream load, because when loading data(stream load and other load), the slots reading from files are string type. So we need to cast it to its own type to avoid error.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)