[enhancement](hive)Initial support for Hive org.openx.data.jsonserde.JsonSerDe #49209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32970 ms |
TPC-DS: Total hot run time: 185231 ms |
ClickBench: Total hot run time: 31.05 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
added
dev/2.1.x
dev/3.0.x
dev/2.1.x-experimental
dev/3.0.x-experimental
and removed
dev/2.1.x
dev/3.0.x
labels
morningman
reviewed
Mar 19, 2025
| // in the data to lowercase,and use the last one as the insertion value | ||
|
|
||
| bool _openx_json_ignore_malformed = false; | ||
| // hive : org.openx.data.jsonserde.JsonSerDe, `ignore.malformed.json` prop. |
Contributor
There was a problem hiding this comment.
move comment before the field
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34703 ms |
TPC-DS: Total hot run time: 194406 ms |
ClickBench: Total hot run time: 31.92 s |
morningman
reviewed
Mar 24, 2025
| } | ||
|
|
||
| public boolean canReadHiveJsonInOneColumn() { | ||
| return ConnectContext.get().getSessionVariable().isReadHiveJsonInOneColumn() |
Contributor
There was a problem hiding this comment.
There is a sessionVariable instance in HiveScanNode. Use it instead of ConnectContext.get().getSessionVariable()
| || serDeLib.equals(HiveMetaStoreClientHelper.LEGACY_HIVE_JSON_SERDE)) { | ||
| type = TFileFormatType.FORMAT_JSON; | ||
| } else if (serDeLib.equals(HiveMetaStoreClientHelper.OPENX_JSON_SERDE)) { | ||
| if (hmsTable.canReadHiveJsonInOneColumn()) { |
Contributor
There was a problem hiding this comment.
I think we should return error if READ_HIVE_JSON_IN_ONE_COLUMN is true but the first column is not string?
morningman
added
usercase
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
|
TeamCity cloud ut coverage result: |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
wuwenchi
approved these changes
Apr 9, 2025
suxiaogang223
approved these changes
Apr 9, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…JsonSerDe (apache#49209) ### What problem does this PR solve? Problem Summary: Initial support for Hive `org.openx.data.jsonserde.JsonSerDe`(https://github.com/rcongiu/Hive-JSON-Serde). The specific behavior of read is similar to pr apache#43469. By referring to the description in the link, here are some explanations: Support: 1. Querying Complex Fields 2. Importing Malformed Data (serde prop: ignore.malformed.json) Not supported, this parameter will not affect the query results 1. dots.in.keys 2. Case Sensitivity in mappings 3. Mapping Hive Keywords Not supported, but will report an error: 1. Using Arrays 2. Promoting a Scalar to an Array error : [DATA_QUALITY_ERROR]JSON data is array-object, `strip_outer_array` must be TRUE. In order to allow some json strings that do not support parsing to be processed by users, a session variable is introduced: `read_hive_json_in_one_column` (default is false). When this variable is true, a whole line of json is read into the first column, and users can choose to process a whole line of json, such as JSON_PARSE. The data type of the first column of the table needs to be string. Currently only valid for org.openx.data.jsonserde.JsonSerDe.
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…onserde.JsonSerDe" (apache#49928) Reverts apache#49209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Initial support for Hive
org.openx.data.jsonserde.JsonSerDe(https://github.com/rcongiu/Hive-JSON-Serde).The specific behavior of read is similar to pr #43469.
By referring to the description in the link, here are some explanations:
Support:
Not supported, this parameter will not affect the query results
Not supported, but will report an error:
error : [DATA_QUALITY_ERROR]JSON data is array-object,
strip_outer_arraymust be TRUE.In order to allow some json strings that do not support parsing to be processed by users, a session variable is introduced:
read_hive_json_in_one_column(default is false). When this variable is true, a whole line of json is read into the first column, and users can choose to process a whole line of json, such as JSON_PARSE. The data type of the first column of the table needs to be string. Currently only valid for org.openx.data.jsonserde.JsonSerDe.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)