-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](cast) support time cast to date/datetime #49483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34165 ms |
TPC-DS: Total hot run time: 186367 ms |
ClickBench: Total hot run time: 31.22 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
3cff231 to
587c8e4
Compare
|
run buildall |
TPC-H: Total hot run time: 34128 ms |
TPC-DS: Total hot run time: 192502 ms |
ClickBench: Total hot run time: 31.15 s |
|
run buildall |
TPC-H: Total hot run time: 34414 ms |
TPC-DS: Total hot run time: 185826 ms |
ClickBench: Total hot run time: 31.15 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 34147 ms |
TPC-DS: Total hot run time: 186048 ms |
ClickBench: Total hot run time: 31.4 s |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
### What problem does this PR solve?
In the past, we did not support time cast to datetime/date.
Here we add the support because time cast to date involves the current
date, so most of the tests are BEUT.
1. Support casting the time type to date/datetime.
2. The time type can be implicitly converted to date/datetime.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
In the past, we did not support time cast to datetime/date.
Here we add the support because time cast to date involves the current
date, so most of the tests are BEUT.
1. Support casting the time type to date/datetime.
2. The time type can be implicitly converted to date/datetime.
None
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
What problem does this PR solve?
In the past, we did not support time cast to datetime/date.
Here we add the support because time cast to date involves the current date, so most of the tests are BEUT.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)