branch-2.1: [fix](meta) do not check replica allocation when replay #49569 #49604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
### What problem does this PR solve? Problem Summary: ``` 2025-03-27 11:35:33,694 ERROR (stateListener|95) [EditLog.loadJournal():1231] Operation Type 142 org.apache.doris.common.DdlException: errCode = 2, detailMessage = Failed to find enough backend for ssd storage medium. When setting dynamic_partition.hot_partition_num>0, the hot partitions will store in ssd. Please check the replication num, replication tag and storage medium. at org.apache.doris.common.util.DynamicPartitionUtil.checkReplicaAllocation(DynamicPartitionUtil.java:254) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.DynamicPartitionUtil.checkDynamicPartition(DynamicPartitionUtil.java:190) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.ColocateTableIndex.replayModifyReplicaAlloc(ColocateTableIndex.java:914) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.ColocateTableIndex.replayModifyReplicaAlloc(ColocateTableIndex.java:655) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.replayJournal(Env.java:2759) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env$JournalObserver.runOneCycle(Env.java:116) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.Daemon.run(Daemon.java:116) [doris-fe.jar:1.2-SNAPSHOT] ``` We should not throw any exception when checking the properties in replay logic. This PR skip the checking logic when replay. But I am not sure how to reproduce this situation, l can just guess that after user modify the colocation property of a table, but some properties of backends are changed, then this issue may happen. This PR has been tested by user and it can solve the problem.
yiguolei
force-pushed
the
auto-pick-49569-branch-2.1
branch
from
7586a95 to
288a18f
Compare
Contributor
|
run buildall |
yiguolei
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #49569