[fix](group commit) reduce cpu cost for group_commit get_block #49822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
mymeiyi
force-pushed
the
group-commit-get-block
branch
2 times, most recently
from
a2f90ac to
3da47f3
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34367 ms |
TPC-DS: Total hot run time: 192238 ms |
ClickBench: Total hot run time: 31.65 s |
Contributor
Author
|
run p0 |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
mymeiyi
force-pushed
the
group-commit-get-block
branch
from
3da47f3 to
5103a6e
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34214 ms |
TPC-DS: Total hot run time: 193538 ms |
ClickBench: Total hot run time: 30.91 s |
Gabriel39
reviewed
Apr 7, 2025
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
mymeiyi
force-pushed
the
group-commit-get-block
branch
2 times, most recently
from
ba2cbcb to
a023e77
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35526 ms |
TPC-DS: Total hot run time: 193284 ms |
ClickBench: Total hot run time: 31.18 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run cloud_p0 |
1 similar comment
Contributor
Author
|
run cloud_p0 |
yiguolei
reviewed
Apr 27, 2025
| _runtime_filter_timer = std::make_shared<pipeline::RuntimeFilterTimer>( | ||
| MonotonicMillis(), load_block_queue->get_group_commit_interval_ms(), | ||
| _timer_dependency); | ||
| std::vector<std::shared_ptr<pipeline::RuntimeFilterTimer>> timers; |
Contributor
Author
There was a problem hiding this comment.
group commit需要按照提交时间被唤醒，现在只有runtime filter支持这种
Contributor
There was a problem hiding this comment.
这种地方都得用注释写清楚，否则，别人还以为我们的group commit 跟runtime filter 有啥关联
mymeiyi
force-pushed
the
group-commit-get-block
branch
from
a023e77 to
18509ef
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33561 ms |
TPC-DS: Total hot run time: 192651 ms |
ClickBench: Total hot run time: 28.74 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
May 20, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
dataroaring
added
dev/3.0.x
dev/2.1.x
usercase
dataroaring
pushed a commit
that referenced
this pull request
May 21, 2025
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
May 28, 2025
…mit get_block apache#49822 (apache#51079)" This reverts commit 212cd8f.
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
May 28, 2025
…roup_commit get_block apache#49822 (apache#51079)"" This reverts commit e79a574.
16 tasks
dataroaring
pushed a commit
that referenced
this pull request
May 30, 2025
### What problem does this PR solve? 1. after #49822, the group_commit_scan_operator is blocked by time dependency until timeout, this pr fix it 2. modify some debug log 3. print the create plan error to client
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
May 30, 2025
1. after apache#49822, the group_commit_scan_operator is blocked by time dependency until timeout, this pr fix it 2. modify some debug log 3. print the create plan error to client
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? 1. after apache#49822, the group_commit_scan_operator is blocked by time dependency until timeout, this pr fix it 2. modify some debug log 3. print the create plan error to client
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)