Skip to content

[Refactor](lock) Remove SpinLock compeletely #49872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 10, 2025
Merged

[Refactor](lock) Remove SpinLock compeletely #49872

dataroaring merged 1 commit into from
Apr 10, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Apr 8, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Apr 8, 2025

run buildall

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Apr 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 8, 2025

TPC-H: Total hot run time: 34413 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 310cbd56af11eb7ea82649f407fdd14c1de613cf, data reload: false

------ Round 1 ----------------------------------
q1	26457	5020	5075	5020
q2	2057	291	180	180
q3	10382	1277	696	696
q4	10231	1056	541	541
q5	7552	2394	2371	2371
q6	186	167	130	130
q7	946	746	616	616
q8	9333	1259	1165	1165
q9	6861	5110	5161	5110
q10	6835	2297	1889	1889
q11	497	278	262	262
q12	365	371	219	219
q13	17778	3661	3102	3102
q14	246	241	207	207
q15	532	492	496	492
q16	641	631	579	579
q17	608	871	367	367
q18	7686	7367	7235	7235
q19	2279	981	591	591
q20	336	341	217	217
q21	4295	3390	2440	2440
q22	1025	1014	984	984
Total cold run time: 117128 ms
Total hot run time: 34413 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5289	5113	5133	5113
q2	233	323	232	232
q3	2188	2655	2274	2274
q4	1441	1946	1496	1496
q5	4505	4375	4442	4375
q6	220	167	130	130
q7	1993	1948	1733	1733
q8	2623	2547	2647	2547
q9	7292	6987	7232	6987
q10	2978	3200	2763	2763
q11	590	514	500	500
q12	682	754	615	615
q13	3659	3919	3373	3373
q14	278	305	268	268
q15	528	481	480	480
q16	650	681	674	674
q17	1167	1620	1368	1368
q18	7986	7648	7670	7648
q19	868	846	972	846
q20	1922	2003	1862	1862
q21	5313	4933	4743	4743
q22	1125	1064	1042	1042
Total cold run time: 53530 ms
Total hot run time: 51069 ms

@doris-robot
Copy link

doris-robot commented Apr 8, 2025

TPC-DS: Total hot run time: 191370 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 310cbd56af11eb7ea82649f407fdd14c1de613cf, data reload: false

query1	1401	1084	1035	1035
query2	6150	1982	1972	1972
query3	11018	4501	4463	4463
query4	53351	25329	23148	23148
query5	5138	553	480	480
query6	340	192	200	192
query7	4863	515	292	292
query8	315	256	251	251
query9	5461	2634	2635	2634
query10	436	327	270	270
query11	14997	15061	14771	14771
query12	163	111	103	103
query13	1037	533	405	405
query14	10128	6325	6402	6325
query15	203	197	179	179
query16	7094	651	514	514
query17	1083	772	613	613
query18	1577	425	330	330
query19	209	199	178	178
query20	140	134	122	122
query21	208	124	114	114
query22	4578	4402	4340	4340
query23	33918	33410	33265	33265
query24	6722	2455	2451	2451
query25	452	465	407	407
query26	721	285	155	155
query27	2322	519	333	333
query28	3077	2464	2460	2460
query29	596	574	462	462
query30	278	223	190	190
query31	888	887	818	818
query32	70	70	63	63
query33	473	383	299	299
query34	815	889	538	538
query35	821	851	764	764
query36	956	1001	903	903
query37	122	104	75	75
query38	4214	4365	4275	4275
query39	1541	1462	1486	1462
query40	208	127	111	111
query41	54	55	52	52
query42	122	109	106	106
query43	517	524	488	488
query44	1411	853	828	828
query45	188	185	174	174
query46	897	1058	650	650
query47	1864	1889	1827	1827
query48	401	425	321	321
query49	687	526	436	436
query50	699	701	402	402
query51	4304	4267	4220	4220
query52	110	111	98	98
query53	241	270	185	185
query54	623	594	526	526
query55	83	86	87	86
query56	324	330	290	290
query57	1197	1178	1118	1118
query58	272	254	267	254
query59	2820	2896	2832	2832
query60	349	326	319	319
query61	132	133	126	126
query62	731	751	676	676
query63	237	193	186	186
query64	2040	1056	742	742
query65	4437	4350	4310	4310
query66	733	406	310	310
query67	15991	15733	15429	15429
query68	7757	901	526	526
query69	542	303	267	267
query70	1221	1078	1094	1078
query71	511	343	302	302
query72	5964	2348	5150	2348
query73	1465	795	436	436
query74	8954	9096	8963	8963
query75	3911	3197	2742	2742
query76	4261	1214	773	773
query77	632	386	289	289
query78	10046	10259	9297	9297
query79	1945	810	569	569
query80	767	514	448	448
query81	485	265	225	225
query82	458	129	100	100
query83	401	253	237	237
query84	296	102	85	85
query85	787	344	300	300
query86	386	275	299	275
query87	4432	4406	4333	4333
query88	3477	2238	2256	2238
query89	405	315	281	281
query90	1920	216	217	216
query91	141	140	109	109
query92	78	65	58	58
query93	1453	984	585	585
query94	679	409	293	293
query95	364	299	289	289
query96	503	563	273	273
query97	3140	3220	3182	3182
query98	228	205	203	203
query99	1457	1418	1297	1297
Total cold run time: 298614 ms
Total hot run time: 191370 ms

@doris-robot
Copy link

doris-robot commented Apr 8, 2025

ClickBench: Total hot run time: 31.01 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 310cbd56af11eb7ea82649f407fdd14c1de613cf, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.10
query3	0.24	0.20	0.19
query4	1.60	0.18	0.20
query5	0.59	0.56	0.61
query6	1.20	0.74	0.73
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.58	0.53	0.53
query10	0.57	0.58	0.57
query11	0.15	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.61
query14	2.64	2.66	2.70
query15	0.92	0.85	0.87
query16	0.38	0.36	0.37
query17	1.05	1.00	1.01
query18	0.21	0.20	0.19
query19	1.92	1.82	1.93
query20	0.02	0.01	0.01
query21	15.35	0.89	0.55
query22	0.75	1.04	0.64
query23	15.12	1.36	0.60
query24	7.85	0.87	0.98
query25	0.46	0.13	0.08
query26	0.59	0.17	0.13
query27	0.05	0.05	0.05
query28	9.44	0.88	0.42
query29	12.57	4.00	3.27
query30	0.25	0.10	0.06
query31	2.83	0.61	0.39
query32	3.25	0.56	0.46
query33	3.06	3.05	3.14
query34	15.72	5.10	4.50
query35	4.49	4.54	4.49
query36	0.68	0.50	0.48
query37	0.10	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.01 s
Total hot run time: 31.01 s

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Apr 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 8, 2025

TPC-H: Total hot run time: 34469 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f1b5fa885499f18476f5b0dcfa397285fae672e0, data reload: false

------ Round 1 ----------------------------------
q1	26200	5123	5097	5097
q2	2103	282	187	187
q3	10520	1282	711	711
q4	10237	1040	551	551
q5	7839	2425	2304	2304
q6	195	167	134	134
q7	900	759	614	614
q8	9324	1305	1149	1149
q9	6838	5141	5150	5141
q10	6825	2301	1899	1899
q11	480	293	270	270
q12	347	365	223	223
q13	17778	3705	3111	3111
q14	241	229	208	208
q15	538	490	497	490
q16	636	622	596	596
q17	614	876	388	388
q18	7651	7169	7196	7169
q19	1552	966	552	552
q20	330	358	223	223
q21	4076	3619	2504	2504
q22	1037	1013	948	948
Total cold run time: 116261 ms
Total hot run time: 34469 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5172	5098	5106	5098
q2	237	328	237	237
q3	2147	2631	2286	2286
q4	1409	1788	1382	1382
q5	4274	4126	4143	4126
q6	225	163	122	122
q7	1857	1880	1656	1656
q8	2501	2486	2442	2442
q9	6807	6785	6809	6785
q10	2875	3094	2657	2657
q11	567	501	478	478
q12	667	709	568	568
q13	3360	3682	3214	3214
q14	258	284	250	250
q15	507	485	465	465
q16	628	674	627	627
q17	1104	1472	1357	1357
q18	7149	7168	7092	7092
q19	785	792	856	792
q20	1908	2000	1847	1847
q21	5259	4744	4613	4613
q22	1051	1023	976	976
Total cold run time: 50747 ms
Total hot run time: 49070 ms

@doris-robot
Copy link

doris-robot commented Apr 8, 2025

TPC-DS: Total hot run time: 186878 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f1b5fa885499f18476f5b0dcfa397285fae672e0, data reload: false

query1	995	500	476	476
query2	6552	1923	1904	1904
query3	6745	225	217	217
query4	25950	23720	23216	23216
query5	5726	659	472	472
query6	314	218	198	198
query7	4630	491	295	295
query8	325	257	246	246
query9	8659	2573	2577	2573
query10	549	345	275	275
query11	15729	14982	14976	14976
query12	161	111	109	109
query13	1672	538	404	404
query14	11005	6182	6320	6182
query15	200	184	171	171
query16	7673	620	446	446
query17	1568	717	567	567
query18	2021	402	299	299
query19	221	183	152	152
query20	125	118	116	116
query21	212	122	103	103
query22	4229	4259	4097	4097
query23	33909	32977	32932	32932
query24	8049	2375	2392	2375
query25	526	452	396	396
query26	726	274	154	154
query27	2635	540	328	328
query28	4296	2432	2381	2381
query29	630	583	433	433
query30	284	214	220	214
query31	918	864	763	763
query32	70	64	66	64
query33	543	373	341	341
query34	776	865	510	510
query35	791	816	751	751
query36	933	991	902	902
query37	118	102	77	77
query38	4151	4213	4119	4119
query39	1445	1409	1429	1409
query40	217	121	108	108
query41	54	54	53	53
query42	119	102	109	102
query43	493	516	464	464
query44	1347	795	802	795
query45	182	176	166	166
query46	838	1030	633	633
query47	1765	1816	1745	1745
query48	372	415	313	313
query49	712	509	440	440
query50	663	670	405	405
query51	4134	4225	4079	4079
query52	104	109	97	97
query53	238	256	179	179
query54	582	567	502	502
query55	82	77	80	77
query56	310	310	284	284
query57	1120	1154	1116	1116
query58	264	268	262	262
query59	2546	2680	2762	2680
query60	322	327	308	308
query61	133	135	133	133
query62	775	756	660	660
query63	239	188	185	185
query64	3103	1017	690	690
query65	4290	4225	4249	4225
query66	831	464	312	312
query67	15678	15473	15318	15318
query68	7890	885	520	520
query69	482	314	266	266
query70	1240	1139	1105	1105
query71	426	317	298	298
query72	5557	4729	4751	4729
query73	683	617	341	341
query74	8918	9091	9039	9039
query75	3291	3202	2692	2692
query76	3087	1186	784	784
query77	488	389	303	303
query78	9897	10012	9239	9239
query79	2001	828	564	564
query80	582	520	450	450
query81	457	265	220	220
query82	204	123	94	94
query83	251	319	241	241
query84	241	114	87	87
query85	747	361	308	308
query86	320	308	293	293
query87	4524	4494	4369	4369
query88	3495	2229	2203	2203
query89	388	314	289	289
query90	2128	219	214	214
query91	146	140	110	110
query92	87	64	57	57
query93	1238	967	584	584
query94	696	419	316	316
query95	375	298	294	294
query96	498	562	282	282
query97	3081	3253	3119	3119
query98	228	209	205	205
query99	1340	1374	1289	1289
Total cold run time: 272560 ms
Total hot run time: 186878 ms

@doris-robot
Copy link

doris-robot commented Apr 8, 2025

ClickBench: Total hot run time: 30.64 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f1b5fa885499f18476f5b0dcfa397285fae672e0, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.10
query3	0.23	0.19	0.19
query4	1.59	0.19	0.20
query5	0.62	0.59	0.59
query6	1.18	0.72	0.71
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.58	0.53	0.51
query10	0.59	0.57	0.56
query11	0.16	0.11	0.10
query12	0.15	0.12	0.12
query13	0.61	0.59	0.60
query14	2.79	2.73	2.81
query15	0.93	0.86	0.84
query16	0.40	0.39	0.37
query17	1.02	1.00	1.04
query18	0.22	0.20	0.20
query19	1.86	1.98	1.82
query20	0.01	0.01	0.01
query21	15.35	0.93	0.54
query22	0.77	1.34	0.68
query23	14.78	1.38	0.59
query24	6.85	2.35	0.34
query25	0.33	0.19	0.06
query26	0.51	0.15	0.14
query27	0.05	0.06	0.05
query28	9.69	0.88	0.43
query29	12.53	4.11	3.35
query30	0.25	0.09	0.06
query31	2.82	0.58	0.39
query32	3.23	0.53	0.46
query33	3.10	3.03	3.12
query34	15.80	5.08	4.48
query35	4.49	4.50	4.52
query36	0.65	0.50	0.49
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.88 s
Total hot run time: 30.64 s

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Apr 9, 2025

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-H: Total hot run time: 34898 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6584092249e24dff099d2e933cb7525f0b3b2dba, data reload: false

------ Round 1 ----------------------------------
q1	26313	5027	5002	5002
q2	2072	278	181	181
q3	10399	1241	695	695
q4	10240	1042	525	525
q5	7541	2502	2326	2326
q6	185	161	134	134
q7	949	740	622	622
q8	9325	1337	1091	1091
q9	6739	5119	5091	5091
q10	6811	2321	1882	1882
q11	482	283	273	273
q12	356	358	216	216
q13	17796	3661	3101	3101
q14	228	230	208	208
q15	527	490	477	477
q16	628	616	573	573
q17	611	845	419	419
q18	7595	7266	7113	7113
q19	1397	975	565	565
q20	329	337	236	236
q21	4419	3418	3213	3213
q22	1085	1040	955	955
Total cold run time: 116027 ms
Total hot run time: 34898 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5154	5104	5497	5104
q2	239	331	234	234
q3	2156	2690	2292	2292
q4	1408	1904	1456	1456
q5	4469	4516	4407	4407
q6	218	176	129	129
q7	2001	1922	1756	1756
q8	2624	2655	2587	2587
q9	7361	7062	7223	7062
q10	2950	3189	2785	2785
q11	574	517	486	486
q12	685	755	598	598
q13	3506	3903	3320	3320
q14	271	295	261	261
q15	530	470	473	470
q16	649	685	637	637
q17	1156	1607	1397	1397
q18	7855	7713	7654	7654
q19	814	830	896	830
q20	1935	1969	1880	1880
q21	5407	4891	4733	4733
q22	1139	1072	1018	1018
Total cold run time: 53101 ms
Total hot run time: 51096 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-DS: Total hot run time: 192940 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6584092249e24dff099d2e933cb7525f0b3b2dba, data reload: false

query1	1455	1069	1054	1054
query2	6228	2012	1951	1951
query3	11163	4658	4739	4658
query4	25902	23644	23006	23006
query5	4194	627	432	432
query6	292	207	194	194
query7	4000	514	284	284
query8	286	243	221	221
query9	8487	2576	2546	2546
query10	464	307	255	255
query11	15301	15221	14773	14773
query12	158	112	110	110
query13	1573	522	396	396
query14	8457	6057	6162	6057
query15	199	190	172	172
query16	7247	643	491	491
query17	1203	720	601	601
query18	2013	427	360	360
query19	214	198	174	174
query20	132	128	120	120
query21	217	127	113	113
query22	4721	4884	4380	4380
query23	34512	33742	33256	33256
query24	8494	2438	2426	2426
query25	518	477	412	412
query26	1297	276	154	154
query27	2978	498	337	337
query28	4554	2428	2435	2428
query29	761	558	441	441
query30	278	226	193	193
query31	916	883	791	791
query32	73	63	70	63
query33	546	362	310	310
query34	827	880	520	520
query35	847	858	773	773
query36	959	999	926	926
query37	127	107	78	78
query38	4231	4267	4168	4168
query39	1493	1445	1445	1445
query40	211	121	104	104
query41	54	54	52	52
query42	123	106	108	106
query43	512	521	490	490
query44	1333	828	815	815
query45	185	181	173	173
query46	851	1035	648	648
query47	1846	1939	1835	1835
query48	393	415	311	311
query49	808	508	440	440
query50	664	708	405	405
query51	4297	4289	4171	4171
query52	111	108	104	104
query53	241	283	190	190
query54	596	578	529	529
query55	85	80	86	80
query56	327	331	293	293
query57	1181	1220	1141	1141
query58	263	255	264	255
query59	2904	2910	2676	2676
query60	335	315	325	315
query61	131	152	134	134
query62	765	741	663	663
query63	220	193	189	189
query64	4069	1035	725	725
query65	4415	4402	4373	4373
query66	1062	416	321	321
query67	16273	15808	15541	15541
query68	8538	890	528	528
query69	499	307	266	266
query70	1251	1120	1114	1114
query71	462	326	288	288
query72	5850	4770	4834	4770
query73	806	656	350	350
query74	8921	9143	8892	8892
query75	3949	3187	2705	2705
query76	3755	1187	772	772
query77	798	380	279	279
query78	10106	10240	9324	9324
query79	2226	837	558	558
query80	644	505	452	452
query81	489	254	224	224
query82	504	129	101	101
query83	287	255	239	239
query84	282	112	91	91
query85	787	361	318	318
query86	378	279	299	279
query87	4424	4456	4284	4284
query88	3542	2205	2195	2195
query89	404	309	273	273
query90	1840	213	214	213
query91	160	142	114	114
query92	82	63	55	55
query93	1716	972	571	571
query94	645	405	312	312
query95	372	287	297	287
query96	491	564	271	271
query97	3194	3219	3150	3150
query98	229	210	203	203
query99	1424	1411	1314	1314
Total cold run time: 280627 ms
Total hot run time: 192940 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

ClickBench: Total hot run time: 30.64 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6584092249e24dff099d2e933cb7525f0b3b2dba, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.10
query3	0.24	0.20	0.20
query4	1.61	0.19	0.11
query5	0.57	0.54	0.54
query6	1.17	0.72	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.57	0.52	0.52
query10	0.61	0.59	0.58
query11	0.16	0.11	0.10
query12	0.15	0.12	0.11
query13	0.61	0.60	0.61
query14	2.67	2.67	2.68
query15	0.92	0.85	0.84
query16	0.39	0.38	0.39
query17	1.01	1.04	1.01
query18	0.21	0.20	0.20
query19	1.98	1.86	1.85
query20	0.01	0.01	0.01
query21	15.37	0.89	0.54
query22	0.76	1.24	0.59
query23	14.97	1.41	0.63
query24	7.46	1.64	0.42
query25	0.50	0.13	0.21
query26	0.60	0.16	0.15
query27	0.05	0.04	0.04
query28	9.17	0.87	0.44
query29	12.55	4.01	3.29
query30	0.26	0.09	0.06
query31	2.81	0.62	0.39
query32	3.25	0.56	0.46
query33	2.99	3.11	3.09
query34	15.73	5.18	4.49
query35	4.53	4.58	4.52
query36	0.68	0.50	0.48
query37	0.09	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.14	0.13
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 105.29 s
Total hot run time: 30.64 s

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

BE UT Coverage Report

Increment line coverage 48.72% (19/39) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.26% (14028/26845)
Line Coverage 41.02% (121026/295070)
Region Coverage 39.77% (61616/154918)
Branch Coverage 34.44% (30843/89550)

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Apr 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-H: Total hot run time: 34111 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6584092249e24dff099d2e933cb7525f0b3b2dba, data reload: false

------ Round 1 ----------------------------------
q1	25462	5034	5019	5019
q2	2069	287	181	181
q3	10412	1240	685	685
q4	10238	1032	544	544
q5	7634	2394	2328	2328
q6	184	160	131	131
q7	905	750	611	611
q8	9311	1287	1085	1085
q9	6823	5143	5087	5087
q10	6873	2305	1888	1888
q11	488	288	264	264
q12	358	360	222	222
q13	17792	3694	3111	3111
q14	224	231	207	207
q15	531	486	494	486
q16	624	614	596	596
q17	596	855	371	371
q18	7685	7215	7036	7036
q19	1658	960	566	566
q20	335	342	225	225
q21	4210	3381	2508	2508
q22	1043	1034	960	960
Total cold run time: 115455 ms
Total hot run time: 34111 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5575	5142	5190	5142
q2	240	329	236	236
q3	2171	2635	2298	2298
q4	1417	1834	1479	1479
q5	4473	4420	4379	4379
q6	217	174	133	133
q7	1981	1895	1787	1787
q8	2592	2576	2543	2543
q9	7222	7177	7131	7131
q10	2941	3151	2741	2741
q11	619	523	492	492
q12	678	743	624	624
q13	3482	3923	3334	3334
q14	306	285	284	284
q15	528	484	483	483
q16	664	676	660	660
q17	1161	1532	1412	1412
q18	7725	7468	7467	7467
q19	813	798	832	798
q20	1890	1967	1858	1858
q21	5413	5046	4850	4850
q22	1116	1076	1031	1031
Total cold run time: 53224 ms
Total hot run time: 51162 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

TPC-DS: Total hot run time: 191212 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6584092249e24dff099d2e933cb7525f0b3b2dba, data reload: false

query1	1410	1075	1044	1044
query2	6362	1985	2020	1985
query3	11175	4826	4705	4705
query4	25105	23637	22805	22805
query5	4243	618	466	466
query6	298	198	196	196
query7	3976	493	280	280
query8	309	262	287	262
query9	8498	2598	2605	2598
query10	474	333	275	275
query11	15723	15132	14830	14830
query12	164	108	106	106
query13	1558	527	393	393
query14	9316	6334	6368	6334
query15	222	200	171	171
query16	7588	650	493	493
query17	1226	747	611	611
query18	2020	417	334	334
query19	202	194	171	171
query20	128	131	122	122
query21	227	129	110	110
query22	4597	4735	4342	4342
query23	34027	33324	33406	33324
query24	8696	2435	2416	2416
query25	528	474	445	445
query26	1282	273	145	145
query27	2982	507	331	331
query28	4988	2480	2424	2424
query29	702	569	465	465
query30	282	235	191	191
query31	924	850	789	789
query32	74	64	66	64
query33	533	364	319	319
query34	791	890	532	532
query35	821	871	793	793
query36	1006	1017	900	900
query37	125	98	75	75
query38	4266	4440	4283	4283
query39	1542	1441	1440	1440
query40	223	121	108	108
query41	52	51	52	51
query42	124	108	121	108
query43	528	548	491	491
query44	1342	821	823	821
query45	181	182	170	170
query46	845	1041	652	652
query47	1814	1882	1796	1796
query48	389	421	326	326
query49	811	526	431	431
query50	660	686	404	404
query51	4430	4293	4224	4224
query52	115	114	102	102
query53	231	253	195	195
query54	600	589	520	520
query55	89	85	79	79
query56	320	300	309	300
query57	1178	1180	1119	1119
query58	277	297	272	272
query59	2873	3048	2859	2859
query60	344	310	321	310
query61	137	141	129	129
query62	767	744	682	682
query63	229	196	187	187
query64	3997	1085	702	702
query65	4534	4349	4388	4349
query66	1001	411	306	306
query67	16182	15855	15412	15412
query68	8909	904	519	519
query69	489	299	272	272
query70	1180	1125	1107	1107
query71	457	320	283	283
query72	5842	2342	5061	2342
query73	773	750	349	349
query74	9330	9093	9022	9022
query75	4096	3196	2725	2725
query76	3402	1192	786	786
query77	765	382	289	289
query78	9830	11570	9263	9263
query79	1897	841	561	561
query80	648	518	464	464
query81	483	255	233	233
query82	313	126	101	101
query83	290	254	245	245
query84	294	100	77	77
query85	758	349	312	312
query86	341	286	305	286
query87	4581	4391	4321	4321
query88	2882	2244	2239	2239
query89	399	314	283	283
query90	2128	211	222	211
query91	145	143	111	111
query92	74	60	56	56
query93	1092	913	578	578
query94	676	412	311	311
query95	374	294	292	292
query96	485	571	270	270
query97	3143	3237	3134	3134
query98	230	276	197	197
query99	1417	1406	1299	1299
Total cold run time: 280386 ms
Total hot run time: 191212 ms

@doris-robot
Copy link

doris-robot commented Apr 9, 2025

ClickBench: Total hot run time: 30.9 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6584092249e24dff099d2e933cb7525f0b3b2dba, data reload: false

query1	0.03	0.03	0.03
query2	0.12	0.10	0.10
query3	0.24	0.20	0.20
query4	1.59	0.20	0.19
query5	0.58	0.57	0.59
query6	1.19	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.57	0.52	0.51
query10	0.58	0.59	0.57
query11	0.15	0.12	0.10
query12	0.14	0.11	0.11
query13	0.61	0.61	0.60
query14	2.85	2.72	2.79
query15	0.93	0.86	0.84
query16	0.39	0.39	0.39
query17	1.01	1.04	1.04
query18	0.21	0.20	0.20
query19	1.86	1.95	1.90
query20	0.01	0.01	0.01
query21	15.35	0.86	0.53
query22	0.74	1.20	0.75
query23	14.82	1.37	0.62
query24	7.51	0.96	0.35
query25	0.46	0.18	0.15
query26	0.52	0.16	0.12
query27	0.05	0.05	0.06
query28	9.54	0.91	0.46
query29	12.56	3.95	3.33
query30	0.25	0.09	0.06
query31	2.84	0.60	0.38
query32	3.22	0.55	0.46
query33	3.01	3.03	3.07
query34	15.82	5.10	4.49
query35	4.60	4.58	4.48
query36	0.68	0.50	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.14	0.13
query41	0.09	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.6 s
Total hot run time: 30.9 s

liaoxin01
liaoxin01 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a13d8a9 into apache:master Apr 10, 2025
29 of 32 checks passed
@zclllyybb zclllyybb mentioned this pull request Apr 10, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Apr 22, 2025
@zclllyybb
[branch-3.0](lock) Remove SpinLock compeletely (#49972)
e450a7d 
### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #49872

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [x] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@zclllyybb @koarz
[Refactor](lock) Remove SpinLock compeletely (apache#49872)
f68aa26
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025
opt(lock): remove SpinLock compeletely (apache#49872)
078bfdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zclllyybb @hello-stephen @doris-robot @yiguolei @liaoxin01 @dataroaring