Skip to content

[enhancement](memoryfailed) throw exception instead of log fatal during memory allocate failed #49876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 3 commits into from
Apr 9, 2025
Merged

[enhancement](memoryfailed) throw exception instead of log fatal during memory allocate failed #49876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd1ca5a
[enhancement](memoryfailed) throw exception instead of log fatal duri…
yiguolei Apr 8, 2025
7b688f7
f
yiguolei Apr 8, 2025
eec0e33
f
yiguolei Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion be/src/vec/aggregate_functions/aggregate_function_sort.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@ struct AggregateFunctionSortData {
PBlock pblock;
pblock.ParseFromString(data);
auto st = block.deserialize(pblock);
CHECK(st.ok());
// If memory allocate failed during deserialize, st is not ok, throw exception here to
// stop the query.
if (!st.ok()) {
throw doris::Exception(st);
}
}

void add(const IColumn** columns, size_t columns_num, size_t row_num) {
Expand Down
4 changes: 3 additions & 1 deletion be/src/vec/aggregate_functions/aggregate_function_window_funnel.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,10 @@ struct WindowFunnelState {
}
Block block;
auto status = block.deserialize(pblock);
// If memory allocate failed during deserialize, st is not ok, throw exception here to
// stop the query.
if (!status.ok()) {
throw doris::Exception(ErrorCode::INTERNAL_ERROR, status.to_string());
throw doris::Exception(status);
}
mutable_block = MutableBlock(std::move(block));
_reset_columns_ptr();
Expand Down
Loading