Skip to content

branch-3.0: [feature](function) support utf8 input in initcap #49846 #49933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 22, 2025
Merged

branch-3.0: [feature](function) support utf8 input in initcap #49846 #49933

dataroaring merged 1 commit into from
Apr 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 10, 2025

Cherry-picked from #49846

@Mryange
[feature](function) support utf8 input in initcap (#49846)
9f38d20 
### What problem does this PR solve?


Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [x] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [x] Confirm the release note
- [x] Confirm test cases
- [x] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@github-actions github-actions bot requested a review from dataroaring as a code owner April 10, 2025 02:24
@Thearas
Copy link
Contributor

Thearas commented Apr 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 10, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 10, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 10, 2025

BE UT Coverage Report

Increment line coverage 100.00% (39/39) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.05% (10492/26199)
Line Coverage 30.73% (88199/286990)
Region Coverage 29.84% (45453/152305)
Branch Coverage 26.22% (23047/87908)

dataroaring
dataroaring approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 35548b4 into branch-3.0 Apr 22, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49846-branch-3.0 branch April 22, 2025 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @hello-stephen @dataroaring @Mryange