Skip to content

Conversation

@Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 35162 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 03d156cfb2844f139e76a0a4be38ad1fc90fda1f, data reload: false

------ Round 1 ----------------------------------
q1	26087	5043	5067	5043
q2	2076	279	186	186
q3	10380	1255	700	700
q4	10227	1011	551	551
q5	7551	2466	2349	2349
q6	192	160	134	134
q7	919	734	634	634
q8	9333	1277	1104	1104
q9	6779	5127	5145	5127
q10	6809	2309	1908	1908
q11	483	282	285	282
q12	356	347	219	219
q13	17768	3665	3102	3102
q14	242	230	216	216
q15	541	497	486	486
q16	633	620	587	587
q17	608	866	385	385
q18	7579	7256	7106	7106
q19	1218	954	563	563
q20	358	345	240	240
q21	4352	3374	3274	3274
q22	1075	993	966	966
Total cold run time: 115566 ms
Total hot run time: 35162 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5114	5094	5103	5094
q2	238	330	224	224
q3	2133	2644	2287	2287
q4	1430	1820	1513	1513
q5	4559	4441	4377	4377
q6	206	163	124	124
q7	1942	1873	1743	1743
q8	2582	2499	2557	2499
q9	7184	7166	7141	7141
q10	3031	3187	2731	2731
q11	577	508	522	508
q12	708	745	630	630
q13	3547	3839	3253	3253
q14	279	311	284	284
q15	524	477	475	475
q16	637	690	635	635
q17	1157	1553	1378	1378
q18	7591	7350	7332	7332
q19	811	899	1030	899
q20	1961	1939	1795	1795
q21	5097	4703	4513	4513
q22	1059	1029	950	950
Total cold run time: 52367 ms
Total hot run time: 50385 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187821 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 03d156cfb2844f139e76a0a4be38ad1fc90fda1f, data reload: false

query1	1017	488	475	475
query2	6577	1975	1970	1970
query3	6758	228	219	219
query4	26243	23287	23459	23287
query5	4787	635	472	472
query6	328	216	202	202
query7	4631	501	283	283
query8	285	244	242	242
query9	8649	2575	2595	2575
query10	479	321	288	288
query11	15544	15199	14977	14977
query12	160	109	105	105
query13	1647	523	399	399
query14	9454	6453	6438	6438
query15	210	190	175	175
query16	7232	638	491	491
query17	1163	726	601	601
query18	1984	409	330	330
query19	195	192	171	171
query20	130	133	123	123
query21	212	124	107	107
query22	3962	4083	4098	4083
query23	33921	33185	33151	33151
query24	8475	2427	2394	2394
query25	535	452	406	406
query26	1233	271	152	152
query27	2756	506	342	342
query28	4368	2437	2414	2414
query29	806	552	430	430
query30	287	222	196	196
query31	939	867	752	752
query32	72	66	64	64
query33	565	354	327	327
query34	795	862	505	505
query35	791	810	748	748
query36	1026	999	911	911
query37	127	106	76	76
query38	4171	4206	4088	4088
query39	1448	1425	1432	1425
query40	210	118	105	105
query41	56	52	52	52
query42	124	107	112	107
query43	507	524	491	491
query44	1359	820	813	813
query45	179	173	173	173
query46	862	1010	633	633
query47	1733	1785	1693	1693
query48	369	431	303	303
query49	790	513	404	404
query50	666	671	395	395
query51	4155	4198	4141	4141
query52	114	104	100	100
query53	231	266	193	193
query54	570	573	503	503
query55	82	86	84	84
query56	325	297	303	297
query57	1156	1138	1085	1085
query58	269	267	273	267
query59	2585	2843	2546	2546
query60	334	328	303	303
query61	131	141	126	126
query62	799	745	673	673
query63	228	191	191	191
query64	4372	1062	698	698
query65	4322	4248	4279	4248
query66	1146	420	316	316
query67	15883	15311	15390	15311
query68	7755	882	523	523
query69	483	306	268	268
query70	1256	1106	1114	1106
query71	397	323	292	292
query72	5691	4931	4787	4787
query73	677	615	356	356
query74	9167	9274	8966	8966
query75	3205	3217	2723	2723
query76	3274	1186	764	764
query77	588	373	302	302
query78	9967	10220	9336	9336
query79	1484	832	577	577
query80	614	544	453	453
query81	510	257	224	224
query82	229	126	100	100
query83	276	260	247	247
query84	259	107	90	90
query85	748	357	325	325
query86	377	315	300	300
query87	4463	4530	4415	4415
query88	3005	2236	2249	2236
query89	391	316	291	291
query90	1905	232	222	222
query91	149	142	112	112
query92	76	64	59	59
query93	1134	955	611	611
query94	670	428	295	295
query95	390	293	293	293
query96	496	570	284	284
query97	3155	3246	3111	3111
query98	243	212	211	211
query99	1326	1419	1297	1297
Total cold run time: 271879 ms
Total hot run time: 187821 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 03d156cfb2844f139e76a0a4be38ad1fc90fda1f, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.24	0.19	0.19
query4	1.59	0.20	0.11
query5	0.56	0.55	0.56
query6	1.22	0.71	0.71
query7	0.03	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.52	0.52
query10	0.63	0.60	0.56
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.61	0.61
query14	2.79	2.71	2.75
query15	0.92	0.83	0.86
query16	0.38	0.37	0.37
query17	1.00	1.04	1.03
query18	0.22	0.20	0.20
query19	2.04	1.85	1.82
query20	0.02	0.02	0.01
query21	15.34	0.88	0.53
query22	0.76	1.15	0.98
query23	14.70	1.37	0.62
query24	6.64	1.91	0.66
query25	0.52	0.16	0.15
query26	0.62	0.16	0.14
query27	0.06	0.04	0.04
query28	9.67	0.91	0.44
query29	12.54	3.95	3.29
query30	0.25	0.09	0.06
query31	2.82	0.59	0.40
query32	3.23	0.54	0.48
query33	3.03	3.05	3.15
query34	15.76	5.08	4.54
query35	4.57	4.55	4.56
query36	0.66	0.50	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.13	0.13
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.98 s
Total hot run time: 31.35 s

@Yukang-Lian
Copy link
Collaborator Author

run beut

@Yukang-Lian
Copy link
Collaborator Author

run external

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.15% (14423/27137)
Line Coverage 42.01% (124966/297470)
Region Coverage 40.82% (63834/156377)
Branch Coverage 35.45% (32095/90532)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 21, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@gavinchou gavinchou self-requested a review April 22, 2025 07:27
@gavinchou gavinchou merged commit 77879b9 into apache:master Apr 22, 2025
26 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 22, 2025
dataroaring pushed a commit that referenced this pull request Apr 23, 2025
…here is a delete rowset #49953 (#50291)

Cherry-picked from #49953

Co-authored-by: abmdocrt <lianyukang@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants