Skip to content

[opt](Nereids) aggregate function sum support string type as parameter #49954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Apr 18, 2025
Merged

[opt](Nereids) aggregate function sum support string type as parameter #49954

morrySnow merged 1 commit into from
Apr 18, 2025

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Apr 10, 2025

What problem does this PR solve?

will cast string to double

Release note

aggregate function sum support string type as parameter

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 10, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow force-pushed the sum_support_string branch from d6bae2e to 5e471a0 Compare April 10, 2025 07:59
@morrySnow
Copy link
Contributor Author

morrySnow commented Apr 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

TPC-H: Total hot run time: 34186 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5e471a02507a0d9837523863d6944bf7e4225eb1, data reload: false

------ Round 1 ----------------------------------
q1	25987	5020	5000	5000
q2	2067	279	178	178
q3	10392	1269	673	673
q4	10220	987	525	525
q5	7527	2376	2313	2313
q6	197	173	137	137
q7	904	733	616	616
q8	9327	1304	1055	1055
q9	6911	5233	5110	5110
q10	6818	2302	1910	1910
q11	481	289	266	266
q12	346	353	221	221
q13	17779	3662	3058	3058
q14	228	216	209	209
q15	526	499	482	482
q16	627	629	575	575
q17	600	869	384	384
q18	7708	7203	7140	7140
q19	1227	949	588	588
q20	341	331	223	223
q21	4086	3422	2532	2532
q22	1033	1014	991	991
Total cold run time: 115332 ms
Total hot run time: 34186 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5128	5037	5093	5037
q2	234	325	226	226
q3	2138	2658	2313	2313
q4	1465	1885	1422	1422
q5	4563	4504	4401	4401
q6	212	164	126	126
q7	1961	1901	1761	1761
q8	2616	2506	2456	2456
q9	7240	7156	7121	7121
q10	2973	3173	2790	2790
q11	573	506	481	481
q12	728	764	590	590
q13	3554	3886	3307	3307
q14	297	289	272	272
q15	518	473	474	473
q16	656	675	614	614
q17	1143	1535	1431	1431
q18	7674	7359	7353	7353
q19	814	803	1026	803
q20	1987	2025	1875	1875
q21	5208	4694	4691	4691
q22	1084	1040	1002	1002
Total cold run time: 52766 ms
Total hot run time: 50545 ms

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

TPC-DS: Total hot run time: 187381 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5e471a02507a0d9837523863d6944bf7e4225eb1, data reload: false

query1	1011	487	491	487
query2	6560	1958	1927	1927
query3	6745	225	221	221
query4	25897	23533	23517	23517
query5	4343	609	471	471
query6	320	222	210	210
query7	4631	493	296	296
query8	294	239	236	236
query9	8626	2587	2586	2586
query10	487	318	268	268
query11	15434	15053	14847	14847
query12	159	113	109	109
query13	1659	511	400	400
query14	8766	6253	6348	6253
query15	207	196	171	171
query16	7127	665	462	462
query17	940	730	579	579
query18	1992	404	310	310
query19	196	192	161	161
query20	122	118	115	115
query21	214	137	109	109
query22	4096	4383	4114	4114
query23	33947	33152	33139	33139
query24	8517	2356	2329	2329
query25	536	473	392	392
query26	1239	261	157	157
query27	2757	504	334	334
query28	4311	2435	2384	2384
query29	804	547	429	429
query30	283	227	194	194
query31	936	854	748	748
query32	73	73	66	66
query33	569	350	316	316
query34	810	851	515	515
query35	771	832	752	752
query36	961	963	904	904
query37	119	100	72	72
query38	4263	4187	4087	4087
query39	1448	1432	1395	1395
query40	224	122	121	121
query41	57	55	55	55
query42	119	105	111	105
query43	498	506	494	494
query44	1305	802	805	802
query45	175	177	173	173
query46	844	1020	617	617
query47	1740	1799	1695	1695
query48	381	415	295	295
query49	786	503	421	421
query50	638	675	391	391
query51	4167	4201	4167	4167
query52	109	105	100	100
query53	230	256	184	184
query54	572	565	512	512
query55	89	81	84	81
query56	309	295	327	295
query57	1139	1185	1071	1071
query58	276	261	257	257
query59	2628	2731	2649	2649
query60	330	308	305	305
query61	134	158	128	128
query62	796	748	660	660
query63	243	188	183	183
query64	4361	1008	698	698
query65	4384	4264	4221	4221
query66	1153	422	316	316
query67	15880	15391	15405	15391
query68	7979	889	522	522
query69	467	301	269	269
query70	1214	1186	1140	1140
query71	451	324	307	307
query72	5769	4883	4767	4767
query73	721	639	346	346
query74	9338	9115	8899	8899
query75	3791	3258	2728	2728
query76	3649	1187	757	757
query77	802	393	289	289
query78	10102	10002	9333	9333
query79	2481	812	555	555
query80	579	502	459	459
query81	509	271	215	215
query82	468	125	99	99
query83	295	260	240	240
query84	300	112	90	90
query85	776	350	306	306
query86	382	305	279	279
query87	4480	4516	4398	4398
query88	3468	2202	2225	2202
query89	380	326	282	282
query90	1827	210	211	210
query91	142	144	114	114
query92	79	68	64	64
query93	1845	1010	586	586
query94	660	401	317	317
query95	383	300	282	282
query96	489	561	272	272
query97	3206	3190	3138	3138
query98	230	208	201	201
query99	1437	1391	1266	1266
Total cold run time: 274436 ms
Total hot run time: 187381 ms

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

ClickBench: Total hot run time: 31.02 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5e471a02507a0d9837523863d6944bf7e4225eb1, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.11
query3	0.26	0.20	0.20
query4	1.58	0.20	0.11
query5	0.56	0.56	0.57
query6	1.17	0.71	0.72
query7	0.03	0.02	0.01
query8	0.04	0.04	0.03
query9	0.57	0.53	0.51
query10	0.61	0.59	0.58
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	2.83	2.72	2.84
query15	0.92	0.86	0.85
query16	0.38	0.37	0.37
query17	1.04	1.06	1.02
query18	0.21	0.19	0.20
query19	2.08	1.85	1.81
query20	0.01	0.01	0.01
query21	15.35	0.87	0.53
query22	0.77	1.17	0.63
query23	14.98	1.36	0.58
query24	7.05	1.57	0.85
query25	0.46	0.12	0.06
query26	0.60	0.16	0.14
query27	0.06	0.05	0.05
query28	9.64	0.90	0.42
query29	12.52	3.90	3.30
query30	0.24	0.08	0.06
query31	2.83	0.61	0.39
query32	3.23	0.54	0.46
query33	2.99	3.11	3.02
query34	15.95	5.12	4.51
query35	4.58	4.58	4.58
query36	0.67	0.49	0.49
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.18	0.13	0.12
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.81 s
Total hot run time: 31.02 s

@morrySnow morrySnow force-pushed the sum_support_string branch from 5e471a0 to f9567af Compare April 10, 2025 10:10
@morrySnow
Copy link
Contributor Author

morrySnow commented Apr 10, 2025

run buildall

@morrySnow morrySnow requested review from 924060929 and Copilot April 10, 2025 10:11
Copilot AI reviewed Apr 10, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • regression-test/suites/nereids_function_p0/agg_function/agg.groovy: Language not supported
Comments suppressed due to low confidence (2)

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Sum0.java:124

  • The searchSignature method does not explicitly handle string-like types. Consider adding an explicit else-if branch for string-like parameters to ensure consistent signature resolution for inputs that are cast from strings.
if (getArgument(0).getDataType() instanceof NullType) {

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/Sum.java:126

  • Similar to Sum0, the searchSignature method in Sum does not explicitly address string-like types. Adding a dedicated branch for string-like inputs could improve clarity and maintain consistent type handling.
if (getArgument(0).getDataType() instanceof NullType) {

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

TPC-H: Total hot run time: 34500 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f9567af8bb044bf61ba70563d59e77e22739dc8a, data reload: false

------ Round 1 ----------------------------------
q1	26202	5092	5074	5074
q2	2075	296	185	185
q3	10385	1275	711	711
q4	10234	1015	534	534
q5	7562	2429	2354	2354
q6	189	163	133	133
q7	900	743	608	608
q8	9320	1331	1133	1133
q9	6947	5125	5151	5125
q10	6822	2307	1918	1918
q11	489	294	269	269
q12	357	365	225	225
q13	17766	3693	3121	3121
q14	232	232	207	207
q15	531	481	490	481
q16	643	629	606	606
q17	625	873	380	380
q18	7513	7306	7203	7203
q19	1218	947	569	569
q20	343	339	227	227
q21	4350	3487	2506	2506
q22	1056	1013	931	931
Total cold run time: 115759 ms
Total hot run time: 34500 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5204	5146	5282	5146
q2	249	326	226	226
q3	2157	2663	2264	2264
q4	1428	1887	1486	1486
q5	4616	4443	4344	4344
q6	215	171	129	129
q7	1976	1957	1767	1767
q8	2632	2679	2534	2534
q9	7118	7132	7155	7132
q10	2969	3239	2745	2745
q11	572	514	482	482
q12	698	787	628	628
q13	3505	3981	3400	3400
q14	292	282	262	262
q15	512	496	470	470
q16	639	703	677	677
q17	1151	1538	1383	1383
q18	7742	7538	7316	7316
q19	843	828	1034	828
q20	1931	2070	1805	1805
q21	5295	4722	4550	4550
q22	1071	1000	974	974
Total cold run time: 52815 ms
Total hot run time: 50548 ms

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

TPC-DS: Total hot run time: 186316 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f9567af8bb044bf61ba70563d59e77e22739dc8a, data reload: false

query1	1020	491	472	472
query2	6575	1974	1929	1929
query3	6767	222	218	218
query4	26263	23637	22906	22906
query5	4345	623	469	469
query6	312	219	197	197
query7	4632	487	287	287
query8	306	256	238	238
query9	8627	2583	2579	2579
query10	468	344	257	257
query11	15682	15015	14987	14987
query12	159	109	103	103
query13	1642	493	396	396
query14	8767	6166	6215	6166
query15	228	192	168	168
query16	7134	643	479	479
query17	1162	692	563	563
query18	1950	385	311	311
query19	186	189	158	158
query20	115	116	112	112
query21	213	119	101	101
query22	4061	4136	4092	4092
query23	33935	32888	33091	32888
query24	8433	2408	2344	2344
query25	555	439	391	391
query26	1242	267	151	151
query27	2762	502	324	324
query28	4401	2441	2384	2384
query29	781	560	422	422
query30	290	219	187	187
query31	928	874	800	800
query32	69	65	68	65
query33	564	366	311	311
query34	784	862	505	505
query35	781	812	734	734
query36	958	989	892	892
query37	124	101	74	74
query38	4141	4180	4106	4106
query39	1442	1411	1584	1411
query40	210	123	108	108
query41	59	56	54	54
query42	124	107	101	101
query43	499	523	471	471
query44	1295	815	813	813
query45	182	177	178	177
query46	835	1019	615	615
query47	1744	1829	1695	1695
query48	379	429	319	319
query49	828	505	414	414
query50	632	688	393	393
query51	4179	4259	4163	4163
query52	104	101	101	101
query53	230	258	182	182
query54	572	563	498	498
query55	85	83	83	83
query56	321	307	290	290
query57	1135	1151	1078	1078
query58	267	264	259	259
query59	2777	2822	2695	2695
query60	350	320	303	303
query61	129	130	185	130
query62	806	730	646	646
query63	228	185	189	185
query64	4371	1024	696	696
query65	4357	4272	4283	4272
query66	1137	429	310	310
query67	15793	15670	15180	15180
query68	5490	902	527	527
query69	487	306	268	268
query70	1199	1114	1107	1107
query71	401	316	295	295
query72	5630	4766	4850	4766
query73	671	640	344	344
query74	9212	9072	8660	8660
query75	3206	3194	2720	2720
query76	3155	1183	756	756
query77	490	388	282	282
query78	9962	10144	9383	9383
query79	1088	805	570	570
query80	701	514	452	452
query81	471	256	221	221
query82	200	128	100	100
query83	265	260	243	243
query84	258	108	90	90
query85	756	344	310	310
query86	327	299	289	289
query87	4545	4490	4517	4490
query88	2771	2253	2236	2236
query89	386	316	281	281
query90	1772	219	206	206
query91	137	139	115	115
query92	69	61	60	60
query93	1006	931	595	595
query94	631	416	309	309
query95	383	300	300	300
query96	480	581	279	279
query97	3184	3224	3146	3146
query98	233	209	211	209
query99	1351	1390	1299	1299
Total cold run time: 267349 ms
Total hot run time: 186316 ms

@doris-robot
Copy link

doris-robot commented Apr 10, 2025

ClickBench: Total hot run time: 30.87 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f9567af8bb044bf61ba70563d59e77e22739dc8a, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.25	0.20	0.19
query4	1.59	0.20	0.11
query5	0.58	0.56	0.55
query6	1.20	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.58	0.52	0.52
query10	0.58	0.59	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	2.69	2.72	2.84
query15	0.95	0.85	0.85
query16	0.38	0.39	0.39
query17	1.01	1.03	1.02
query18	0.21	0.19	0.20
query19	2.08	1.85	1.82
query20	0.02	0.01	0.01
query21	15.36	0.91	0.54
query22	0.75	1.17	0.63
query23	15.02	1.37	0.63
query24	6.79	2.04	0.66
query25	0.49	0.24	0.13
query26	0.62	0.16	0.13
query27	0.05	0.06	0.05
query28	9.22	0.90	0.45
query29	12.55	3.93	3.25
query30	0.25	0.09	0.06
query31	2.83	0.60	0.39
query32	3.25	0.55	0.46
query33	3.00	3.08	3.11
query34	15.86	5.09	4.44
query35	4.55	4.53	4.51
query36	0.64	0.50	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.99 s
Total hot run time: 30.87 s

@morrySnow morrySnow force-pushed the sum_support_string branch from f9567af to 910efa0 Compare April 11, 2025 06:26
morningman
morningman previously approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

PR approved by anyone and no changes requested.

@morrySnow
Copy link
Contributor Author

morrySnow commented Apr 15, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 15, 2025

TPC-H: Total hot run time: 34331 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 910efa0ec871e4cdf6ff3e4e4bef1f01266d1882, data reload: false

------ Round 1 ----------------------------------
q1	26219	5176	5045	5045
q2	2067	284	188	188
q3	10390	1233	686	686
q4	10219	1039	540	540
q5	7528	2356	2294	2294
q6	182	173	136	136
q7	918	750	616	616
q8	9306	1288	1083	1083
q9	6814	5035	5082	5035
q10	6848	2283	1876	1876
q11	487	281	272	272
q12	356	348	215	215
q13	17763	3764	3104	3104
q14	230	225	208	208
q15	532	493	498	493
q16	644	615	577	577
q17	586	850	349	349
q18	7700	7484	7315	7315
q19	1288	977	597	597
q20	333	335	224	224
q21	4452	3458	2500	2500
q22	1085	1031	978	978
Total cold run time: 115947 ms
Total hot run time: 34331 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5198	5096	5135	5096
q2	242	330	234	234
q3	2133	2600	2310	2310
q4	1371	1805	1474	1474
q5	4468	4403	4369	4369
q6	224	174	130	130
q7	1946	1904	1771	1771
q8	2583	2494	2547	2494
q9	7199	7222	7180	7180
q10	2987	3179	2748	2748
q11	577	523	491	491
q12	704	761	610	610
q13	3502	3942	3365	3365
q14	278	280	272	272
q15	533	508	490	490
q16	664	719	676	676
q17	1158	1516	1422	1422
q18	7771	7598	7555	7555
q19	790	805	850	805
q20	1907	1981	1832	1832
q21	5318	4936	4673	4673
q22	1076	1067	1015	1015
Total cold run time: 52629 ms
Total hot run time: 51012 ms

@doris-robot
Copy link

doris-robot commented Apr 15, 2025

TPC-DS: Total hot run time: 192075 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 910efa0ec871e4cdf6ff3e4e4bef1f01266d1882, data reload: false

query1	1387	1083	1061	1061
query2	6346	1885	1873	1873
query3	11020	4576	4519	4519
query4	53769	26101	23104	23104
query5	4826	500	453	453
query6	318	194	181	181
query7	4891	500	279	279
query8	304	236	236	236
query9	5482	2591	2594	2591
query10	434	311	254	254
query11	15205	14979	14892	14892
query12	155	112	101	101
query13	1022	503	389	389
query14	10208	6357	6452	6357
query15	205	199	186	186
query16	7083	662	516	516
query17	1093	730	604	604
query18	1648	424	329	329
query19	205	197	164	164
query20	134	139	122	122
query21	207	129	110	110
query22	4387	4476	4186	4186
query23	34346	33500	33418	33418
query24	6619	2387	2420	2387
query25	465	469	406	406
query26	713	280	152	152
query27	2489	511	340	340
query28	3056	2443	2403	2403
query29	581	569	438	438
query30	299	226	194	194
query31	876	909	763	763
query32	71	62	61	61
query33	452	369	303	303
query34	779	878	509	509
query35	822	843	764	764
query36	941	1019	896	896
query37	121	103	77	77
query38	4211	4239	4193	4193
query39	1508	1419	1418	1418
query40	223	127	113	113
query41	52	50	51	50
query42	126	114	110	110
query43	491	491	480	480
query44	1373	804	812	804
query45	185	176	166	166
query46	853	1038	637	637
query47	1834	1873	1772	1772
query48	381	407	301	301
query49	717	502	444	444
query50	657	697	406	406
query51	4261	4272	4203	4203
query52	115	108	99	99
query53	234	260	183	183
query54	576	561	498	498
query55	83	84	81	81
query56	303	303	288	288
query57	1160	1208	1108	1108
query58	264	250	253	250
query59	2630	2776	2642	2642
query60	329	315	306	306
query61	155	126	122	122
query62	753	749	692	692
query63	227	190	196	190
query64	2085	1064	753	753
query65	4631	4300	4248	4248
query66	716	405	311	311
query67	15843	15521	15383	15383
query68	7201	940	512	512
query69	542	314	262	262
query70	1173	1103	1062	1062
query71	504	327	303	303
query72	5914	4639	4479	4479
query73	1476	568	347	347
query74	8969	9170	8727	8727
query75	3834	3169	2719	2719
query76	4184	1194	752	752
query77	624	377	294	294
query78	10179	10170	9373	9373
query79	2399	815	578	578
query80	770	496	428	428
query81	487	259	217	217
query82	459	124	96	96
query83	381	242	230	230
query84	295	103	91	91
query85	771	348	313	313
query86	391	298	278	278
query87	4540	4462	4273	4273
query88	3512	2214	2214	2214
query89	409	311	284	284
query90	1805	211	212	211
query91	141	151	107	107
query92	76	59	65	59
query93	2021	961	571	571
query94	646	406	287	287
query95	355	285	279	279
query96	485	563	268	268
query97	3200	3236	3108	3108
query98	233	203	205	203
query99	1441	1421	1281	1281
Total cold run time: 299352 ms
Total hot run time: 192075 ms

@doris-robot
Copy link

doris-robot commented Apr 15, 2025

ClickBench: Total hot run time: 31.37 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 910efa0ec871e4cdf6ff3e4e4bef1f01266d1882, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.25	0.19	0.20
query4	1.60	0.19	0.21
query5	0.62	0.59	0.61
query6	1.20	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.59	0.53	0.51
query10	0.56	0.58	0.57
query11	0.15	0.11	0.10
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	2.71	2.69	2.68
query15	0.92	0.85	0.85
query16	0.41	0.40	0.38
query17	1.06	1.04	1.01
query18	0.21	0.20	0.20
query19	1.94	2.01	1.85
query20	0.01	0.01	0.01
query21	15.36	0.89	0.54
query22	0.74	1.35	0.78
query23	14.73	1.39	0.58
query24	7.04	1.31	0.84
query25	0.49	0.12	0.15
query26	0.72	0.16	0.15
query27	0.05	0.04	0.05
query28	8.95	0.92	0.45
query29	12.52	3.99	3.35
query30	0.26	0.09	0.06
query31	2.81	0.62	0.38
query32	3.22	0.54	0.47
query33	2.99	3.06	3.12
query34	15.83	5.26	4.51
query35	4.57	4.52	4.51
query36	0.67	0.51	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.63 s
Total hot run time: 31.37 s

@morrySnow morrySnow force-pushed the sum_support_string branch from 910efa0 to efdd39f Compare April 15, 2025 10:35
@morrySnow
Copy link
Contributor Author

morrySnow commented Apr 15, 2025

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 15, 2025
@doris-robot
Copy link

doris-robot commented Apr 15, 2025

TPC-H: Total hot run time: 34163 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit efdd39fc91ac26262796f4c3d4337f1e2f9809d0, data reload: false

------ Round 1 ----------------------------------
q1	25981	5322	5122	5122
q2	2071	278	180	180
q3	10403	1230	697	697
q4	10219	997	522	522
q5	7513	2352	2396	2352
q6	184	166	132	132
q7	909	746	597	597
q8	9318	1220	1148	1148
q9	6863	5130	5078	5078
q10	6868	2323	1887	1887
q11	474	295	277	277
q12	354	359	221	221
q13	17777	3653	3088	3088
q14	228	239	211	211
q15	532	490	504	490
q16	620	616	589	589
q17	581	859	361	361
q18	7576	7141	7001	7001
q19	1858	989	570	570
q20	336	332	213	213
q21	3978	3558	2468	2468
q22	1074	1003	959	959
Total cold run time: 115717 ms
Total hot run time: 34163 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5306	5225	5204	5204
q2	240	329	236	236
q3	2153	2643	2299	2299
q4	1456	1810	1516	1516
q5	4460	4392	4380	4380
q6	228	181	127	127
q7	2008	1916	1790	1790
q8	2596	2521	2531	2521
q9	7292	7136	7081	7081
q10	2983	3167	2748	2748
q11	571	523	491	491
q12	689	764	623	623
q13	3544	3936	3394	3394
q14	287	301	265	265
q15	516	484	486	484
q16	649	678	645	645
q17	1191	1523	1377	1377
q18	7721	7635	7505	7505
q19	831	784	892	784
q20	1887	1952	1837	1837
q21	5286	4951	4808	4808
q22	1087	1052	1025	1025
Total cold run time: 52981 ms
Total hot run time: 51140 ms

@doris-robot
Copy link

doris-robot commented Apr 15, 2025

TPC-DS: Total hot run time: 193380 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit efdd39fc91ac26262796f4c3d4337f1e2f9809d0, data reload: false

query1	1413	1094	1076	1076
query2	6153	1889	1869	1869
query3	11010	4470	4468	4468
query4	51969	25625	23566	23566
query5	5134	571	459	459
query6	327	193	187	187
query7	4884	511	288	288
query8	319	266	234	234
query9	5518	2596	2601	2596
query10	435	306	259	259
query11	15138	14972	14851	14851
query12	159	113	105	105
query13	1043	520	392	392
query14	10214	6293	6294	6293
query15	214	203	172	172
query16	7095	641	479	479
query17	1066	741	582	582
query18	1592	407	313	313
query19	208	195	186	186
query20	128	127	120	120
query21	209	139	109	109
query22	4361	4391	4338	4338
query23	34229	33473	33777	33473
query24	6534	2416	2427	2416
query25	468	471	402	402
query26	680	264	146	146
query27	2220	501	352	352
query28	3148	2443	2397	2397
query29	650	568	432	432
query30	279	223	194	194
query31	843	874	784	784
query32	73	63	63	63
query33	455	363	319	319
query34	763	863	516	516
query35	794	848	782	782
query36	946	1008	896	896
query37	118	101	78	78
query38	4282	4297	4179	4179
query39	1526	1428	1451	1428
query40	227	126	136	126
query41	56	56	56	56
query42	124	106	114	106
query43	505	514	484	484
query44	1307	837	830	830
query45	177	182	169	169
query46	867	1032	652	652
query47	1824	1858	1780	1780
query48	399	406	307	307
query49	690	499	420	420
query50	682	695	413	413
query51	4289	4308	4256	4256
query52	115	112	99	99
query53	236	258	186	186
query54	593	584	551	551
query55	89	85	83	83
query56	310	280	288	280
query57	1193	1192	1165	1165
query58	265	262	260	260
query59	2599	2797	2592	2592
query60	329	308	319	308
query61	132	130	129	129
query62	736	723	702	702
query63	234	182	183	182
query64	1798	1057	739	739
query65	4304	4223	4245	4223
query66	740	403	299	299
query67	15877	15660	15304	15304
query68	6605	874	515	515
query69	552	287	269	269
query70	1170	1120	1124	1120
query71	476	317	299	299
query72	5806	4700	4937	4700
query73	1308	671	342	342
query74	9203	9144	9005	9005
query75	3380	3205	2730	2730
query76	3918	1168	742	742
query77	607	435	283	283
query78	9936	10043	9235	9235
query79	2604	801	591	591
query80	652	500	445	445
query81	477	254	225	225
query82	481	127	95	95
query83	313	257	233	233
query84	306	103	82	82
query85	778	359	320	320
query86	354	314	286	286
query87	4542	4513	4454	4454
query88	3389	2235	2249	2235
query89	392	307	282	282
query90	1640	212	215	212
query91	139	141	114	114
query92	74	63	55	55
query93	2154	953	573	573
query94	733	391	298	298
query95	369	294	288	288
query96	484	571	273	273
query97	3186	3205	3103	3103
query98	230	210	206	206
query99	1330	1377	1270	1270
Total cold run time: 294882 ms
Total hot run time: 193380 ms

@doris-robot
Copy link

doris-robot commented Apr 15, 2025

ClickBench: Total hot run time: 31.33 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit efdd39fc91ac26262796f4c3d4337f1e2f9809d0, data reload: false

query1	0.03	0.03	0.03
query2	0.12	0.10	0.12
query3	0.26	0.19	0.19
query4	1.59	0.19	0.19
query5	0.60	0.60	0.59
query6	1.19	0.72	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.52	0.50
query10	0.57	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.59	0.59
query14	2.66	2.83	2.83
query15	0.94	0.87	0.86
query16	0.38	0.39	0.39
query17	1.10	1.02	1.04
query18	0.21	0.20	0.20
query19	1.91	1.99	1.85
query20	0.01	0.01	0.02
query21	15.37	0.94	0.58
query22	0.76	1.26	0.66
query23	14.88	1.41	0.63
query24	6.96	1.55	0.85
query25	0.53	0.17	0.08
query26	0.59	0.16	0.15
query27	0.06	0.05	0.04
query28	9.71	0.93	0.44
query29	12.57	3.97	3.27
query30	0.26	0.09	0.07
query31	2.82	0.59	0.38
query32	3.23	0.54	0.46
query33	3.03	3.03	3.13
query34	15.73	5.10	4.48
query35	4.49	4.52	4.52
query36	0.66	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.05	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.04	0.03
Total cold run time: 105.27 s
Total hot run time: 31.33 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2025

PR approved by at least one committer and no changes requested.

@morrySnow morrySnow merged commit 11ba26c into apache:master Apr 18, 2025
26 of 27 checks passed
@morrySnow morrySnow deleted the sum_support_string branch April 21, 2025 03:18
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morrySnow @koarz
[opt](Nereids) aggregate function sum support string type as parameter (
43152a7 
apache#49954)

### What problem does this PR solve?

will cast string to double

### Release note

aggregate function sum and avg support string type as parameter
github-actions bot pushed a commit that referenced this pull request Jun 19, 2025
@morrySnow
[opt](Nereids) aggregate function sum support string type as parameter (
91290c4 
#49954)

### What problem does this PR solve?

will cast string to double

### Release note

aggregate function sum and avg support string type as parameter
@github-actions github-actions bot mentioned this pull request Jun 19, 2025
Merged
morrySnow added a commit that referenced this pull request Jun 20, 2025
@github-actions @morrySnow
branch-3.1: [opt](Nereids) aggregate function sum support string type…
e29aeb5 
… as parameter #49954 (#51963)

Cherry-picked from #49954

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
@morrySnow morrySnow added usercase Important user case type label dev/3.0.x labels Jul 15, 2025
github-actions bot pushed a commit that referenced this pull request Jul 15, 2025
@morrySnow
[opt](Nereids) aggregate function sum support string type as parameter (
ba4221f 
#49954)

### What problem does this PR solve?

will cast string to double

### Release note

aggregate function sum and avg support string type as parameter
@github-actions github-actions bot mentioned this pull request Jul 15, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jul 15, 2025
@github-actions @morrySnow
branch-3.0: [opt](Nereids) aggregate function sum support string type…
c24e6dd 
… as parameter #49954 (#53261)

Cherry-picked from #49954

Co-authored-by: morrySnow <zhangwenxin@selectdb.com>
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Sep 1, 2025
@morrySnow @starocean999 @gavinchou
[opt](Nereids) aggregate function sum support string type as parameter (
24edbfe 
apache#4137)

pick from apache#49954
picked to tmp branch tmp-selectdb-cloud-4.0.4.5-ave by apache#3936

Co-authored-by: starocean999 <lichi@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@924060929 924060929 924060929 approved these changes

@starocean999 starocean999 starocean999 approved these changes

@morningman morningman morningman left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged kind/behavior-changed reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morrySnow @hello-stephen @doris-robot @morningman @924060929 @starocean999 @dataroaring