[fix](agg) prevent core dump in ColumnArray::size_at when handling type mismatch in streaming_agg_serialize_to_column #50001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe mismatch in streaming_agg_serialize_to_column
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33528 ms |
TPC-DS: Total hot run time: 192691 ms |
ClickBench: Total hot run time: 30.93 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
cambyzju
reviewed
Apr 14, 2025
| col_src.get_nested_column()); | ||
| vec.insert_from(vec_src, i); | ||
| } else if constexpr (std::is_same_v<Data, AggregateFunctionArrayAggData<void>>) { | ||
| to_nested_col.insert_from(col_src.get_nested_column(), i); |
Contributor
There was a problem hiding this comment.
auto& vec = col_null->get_nested_column();
vec.insert_from(col_src.get_nested_column(), i);
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33939 ms |
TPC-DS: Total hot run time: 193317 ms |
ClickBench: Total hot run time: 31.19 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
felixwluo
force-pushed
the
fix-core-0412
branch
from
86e9c15 to
61ebb0e
Compare
Contributor
Author
|
run buildall |
felixwluo
force-pushed
the
fix-core-0412
branch
from
12185bb to
9aace24
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 35277 ms |
TPC-DS: Total hot run time: 186457 ms |
ClickBench: Total hot run time: 30.65 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run beut |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Gabriel39
approved these changes
Apr 16, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 16, 2025
…pe mismatch in streaming_agg_serialize_to_column (#50001) ### What problem does this PR solve? Problem Summary: core ``` *** is nereids: 1 *** *** tablet id: 0 *** *** Aborted at 1744342233 (unix time) try "date -d @1744342233" if you are using GNU date *** *** Current BE git commitID: 2503281 *** *** SIGSEGV unknown detail explain (@0x0) received by PID 681431 (TID 683727 OR 0x7fcd153a0700) from PID 0; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) in /usr/local/service/doris/lib/be/doris_be 1# os::Linux::chained_handler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 2# JVM_handle_linux_signal in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 3# signalHandler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 4# 0x00007FD26771E400 in /lib64/libc.so.6 5# doris::vectorized::ColumnArray::insert_from(doris::vectorized::IColumn const&, unsigned long) in /usr/local/service/doris/lib/be/doris_be 6# doris::vectorized::ColumnNullable::insert_from(doris::vectorized::IColumn const&, unsigned long) in /usr/local/service/doris/lib/be/doris_be 7# doris::vectorized::AggregateFunctionCollect<doris::vectorized::AggregateFunctionArrayAggData<void>, std::integral_constant<bool, false>, std::integral_constant<bool, true> >::streaming_agg_serialize_to_column(doris::vectorized::IColumn const**, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, unsigned long, doris::vectorized::Arena*) const in /usr/local/service/doris/lib/be/doris_be 8# doris::vectorized::AggFnEvaluator::streaming_agg_serialize_to_column(doris::vectorized::Block*, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, unsigned long, doris::vectorized::Arena*) in /usr/local/service/doris/lib/be/doris_be 9# _ZNSt8__detail9__variant17__gen_vtable_implINS0_12_Multi_arrayIPFNS0_21__deduce_visit_resultIN5doris6StatusEEEONS4_10vectorized8OverloadIJZNS4_8pipeline22StreamingAggLocalState28_pre_agg_with_serialized_keyEPNS7_5BlockESC_E3$_0ZNSA_28_pre_agg_with_serialized_keyESC_SC_E3$_1EEERSt7variantIJNS7_16MethodSerializedI9PHHashMapINS4_9StringRefEPc11DefaultHashISK_vELb0EEEENS7_15MethodOneNumberIhSJ_IhSL_SM_IhvELb0EEEENSQ_ItSJ_ItSL_SM_ItvELb0EEEENSQ_IjSJ_IjSL_9HashCRC32IjELb0EEEENSQ_ImSJ_ImSL_SX_ImELb0EEEENS7_19MethodStringNoCacheINS4_13StringHashMapISL_9AllocatorILb1ELb1ELb0E22DefaultMemoryAllocatorEEEEENSQ_INS7_7UInt128ESJ_IS1B_SL_SX_IS1B_ELb0EEEENSQ_IjSJ_IjSL_14HashMixWrapperIjSY_ELb0EEEENSQ_ImSJ_ImSL_S1F_ImS11_ELb0EEEENSQ_IS1B_SJ_IS1B_SL_S1F_IS1B_S1C_ELb0EEEENS7_26MethodSingleNullableColumnINSQ_IhNS7_15DataWithNullKeyISS_EEEEEENS1P_INSQ_ItNS1Q_ISV_EEEEEENS1P_INSQ_IjNS1Q_ISZ_EEEEEENS1P_INSQ_ImNS1Q_IS12_EEEEEENS1P_INSQ_IjNS1Q_IS1H_EEEEEENS1P_INSQ_ImNS1Q_IS1K_EEEEEENS1P_INSQ_IS1B_NS1Q_IS1D_EEEEEENS1P_INSQ_IS1B_NS1Q_IS1N_EEEEEENS1P_INS14_INS1Q_IS19_EEEEEENS7_15MethodKeysFixedIS12_Lb0EEENS2I_IS12_Lb1EEENS2I_IS1D_Lb0EEENS2I_IS1D_Lb1EEENS2I_ISJ_INS7_7UInt256ESL_SX_IS2N_ELb0EELb0EEENS2I_IS2P_Lb1EEENS2I_ISJ_INS7_7UInt136ESL_SX_IS2S_ELb0EELb0EEENS2I_IS2U_Lb1EEENS2I_IS1K_Lb0EEENS2I_IS1K_Lb1EEENS2I_IS1N_Lb0EEENS2I_IS1N_Lb1EEENS2I_ISJ_IS2N_SL_S1F_IS2N_S2O_ELb0EELb0EEENS2I_IS32_Lb1EEENS2I_ISJ_IS2S_SL_S1F_IS2S_S2T_ELb0EELb0EEENS2I_IS36_Lb1EEEEEEJEEESt16integer_sequenceImJLm0EEEE14__visit_invokeESG_S3A_ in /usr/local/service/doris/lib/be/doris_be 10# doris::pipeline::StreamingAggLocalState::_pre_agg_with_serialized_key(doris::vectorized::Block*, doris::vectorized::Block*) in /usr/local/service/doris/lib/be/doris_be 11# doris::pipeline::StreamingAggLocalState::do_pre_agg(doris::vectorized::Block*, doris::vectorized::Block*) in /usr/local/service/doris/lib/be/doris_be 12# doris::pipeline::StreamingAggOperatorX::push(doris::RuntimeState*, doris::vectorized::Block*, bool) const in /usr/local/service/doris/lib/be/doris_be 13# doris::pipeline::StatefulOperatorX<doris::pipeline::StreamingAggLocalState>::get_block(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be 14# doris::pipeline::OperatorXBase::get_block_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be 15# doris::pipeline::PipelineXTask::execute(bool*) in /usr/local/service/doris/lib/be/doris_be 16# doris::pipeline::TaskScheduler::_do_work(unsigned long) in /usr/local/service/doris/lib/be/doris_be 17# doris::ThreadPool::dispatch_thread() in /usr/local/service/doris/lib/be/doris_be 18# doris::Thread::supervise_thread(void*) in /usr/local/service/doris/lib/be/doris_be 19# start_thread in /lib64/libpthread.so.0 20# __clone in /lib64/libc.so.6 ```
felixwluo
added a commit
to felixwluo/doris
that referenced
this pull request
Apr 16, 2025
… handling type mismatch in streaming_agg_serialize_to_column apache#50001
This was referenced Apr 16, 2025
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Apr 17, 2025
…pe mismatch in streaming_agg_serialize_to_column (apache#50001) ### What problem does this PR solve? Problem Summary: core ``` *** is nereids: 1 *** *** tablet id: 0 *** *** Aborted at 1744342233 (unix time) try "date -d @1744342233" if you are using GNU date *** *** Current BE git commitID: 2503281 *** *** SIGSEGV unknown detail explain (@0x0) received by PID 681431 (TID 683727 OR 0x7fcd153a0700) from PID 0; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) in /usr/local/service/doris/lib/be/doris_be 1# os::Linux::chained_handler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 2# JVM_handle_linux_signal in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 3# signalHandler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 4# 0x00007FD26771E400 in /lib64/libc.so.6 5# doris::vectorized::ColumnArray::insert_from(doris::vectorized::IColumn const&, unsigned long) in /usr/local/service/doris/lib/be/doris_be 6# doris::vectorized::ColumnNullable::insert_from(doris::vectorized::IColumn const&, unsigned long) in /usr/local/service/doris/lib/be/doris_be 7# doris::vectorized::AggregateFunctionCollect<doris::vectorized::AggregateFunctionArrayAggData<void>, std::integral_constant<bool, false>, std::integral_constant<bool, true> >::streaming_agg_serialize_to_column(doris::vectorized::IColumn const**, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, unsigned long, doris::vectorized::Arena*) const in /usr/local/service/doris/lib/be/doris_be 8# doris::vectorized::AggFnEvaluator::streaming_agg_serialize_to_column(doris::vectorized::Block*, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, unsigned long, doris::vectorized::Arena*) in /usr/local/service/doris/lib/be/doris_be 9# _ZNSt8__detail9__variant17__gen_vtable_implINS0_12_Multi_arrayIPFNS0_21__deduce_visit_resultIN5doris6StatusEEEONS4_10vectorized8OverloadIJZNS4_8pipeline22StreamingAggLocalState28_pre_agg_with_serialized_keyEPNS7_5BlockESC_E3$_0ZNSA_28_pre_agg_with_serialized_keyESC_SC_E3$_1EEERSt7variantIJNS7_16MethodSerializedI9PHHashMapINS4_9StringRefEPc11DefaultHashISK_vELb0EEEENS7_15MethodOneNumberIhSJ_IhSL_SM_IhvELb0EEEENSQ_ItSJ_ItSL_SM_ItvELb0EEEENSQ_IjSJ_IjSL_9HashCRC32IjELb0EEEENSQ_ImSJ_ImSL_SX_ImELb0EEEENS7_19MethodStringNoCacheINS4_13StringHashMapISL_9AllocatorILb1ELb1ELb0E22DefaultMemoryAllocatorEEEEENSQ_INS7_7UInt128ESJ_IS1B_SL_SX_IS1B_ELb0EEEENSQ_IjSJ_IjSL_14HashMixWrapperIjSY_ELb0EEEENSQ_ImSJ_ImSL_S1F_ImS11_ELb0EEEENSQ_IS1B_SJ_IS1B_SL_S1F_IS1B_S1C_ELb0EEEENS7_26MethodSingleNullableColumnINSQ_IhNS7_15DataWithNullKeyISS_EEEEEENS1P_INSQ_ItNS1Q_ISV_EEEEEENS1P_INSQ_IjNS1Q_ISZ_EEEEEENS1P_INSQ_ImNS1Q_IS12_EEEEEENS1P_INSQ_IjNS1Q_IS1H_EEEEEENS1P_INSQ_ImNS1Q_IS1K_EEEEEENS1P_INSQ_IS1B_NS1Q_IS1D_EEEEEENS1P_INSQ_IS1B_NS1Q_IS1N_EEEEEENS1P_INS14_INS1Q_IS19_EEEEEENS7_15MethodKeysFixedIS12_Lb0EEENS2I_IS12_Lb1EEENS2I_IS1D_Lb0EEENS2I_IS1D_Lb1EEENS2I_ISJ_INS7_7UInt256ESL_SX_IS2N_ELb0EELb0EEENS2I_IS2P_Lb1EEENS2I_ISJ_INS7_7UInt136ESL_SX_IS2S_ELb0EELb0EEENS2I_IS2U_Lb1EEENS2I_IS1K_Lb0EEENS2I_IS1K_Lb1EEENS2I_IS1N_Lb0EEENS2I_IS1N_Lb1EEENS2I_ISJ_IS2N_SL_S1F_IS2N_S2O_ELb0EELb0EEENS2I_IS32_Lb1EEENS2I_ISJ_IS2S_SL_S1F_IS2S_S2T_ELb0EELb0EEENS2I_IS36_Lb1EEEEEEJEEESt16integer_sequenceImJLm0EEEE14__visit_invokeESG_S3A_ in /usr/local/service/doris/lib/be/doris_be 10# doris::pipeline::StreamingAggLocalState::_pre_agg_with_serialized_key(doris::vectorized::Block*, doris::vectorized::Block*) in /usr/local/service/doris/lib/be/doris_be 11# doris::pipeline::StreamingAggLocalState::do_pre_agg(doris::vectorized::Block*, doris::vectorized::Block*) in /usr/local/service/doris/lib/be/doris_be 12# doris::pipeline::StreamingAggOperatorX::push(doris::RuntimeState*, doris::vectorized::Block*, bool) const in /usr/local/service/doris/lib/be/doris_be 13# doris::pipeline::StatefulOperatorX<doris::pipeline::StreamingAggLocalState>::get_block(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be 14# doris::pipeline::OperatorXBase::get_block_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be 15# doris::pipeline::PipelineXTask::execute(bool*) in /usr/local/service/doris/lib/be/doris_be 16# doris::pipeline::TaskScheduler::_do_work(unsigned long) in /usr/local/service/doris/lib/be/doris_be 17# doris::ThreadPool::dispatch_thread() in /usr/local/service/doris/lib/be/doris_be 18# doris::Thread::supervise_thread(void*) in /usr/local/service/doris/lib/be/doris_be 19# start_thread in /lib64/libpthread.so.0 20# __clone in /lib64/libc.so.6 ```
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…pe mismatch in streaming_agg_serialize_to_column (apache#50001) ### What problem does this PR solve? Problem Summary: core ``` *** is nereids: 1 *** *** tablet id: 0 *** *** Aborted at 1744342233 (unix time) try "date -d @1744342233" if you are using GNU date *** *** Current BE git commitID: 2503281 *** *** SIGSEGV unknown detail explain (@0x0) received by PID 681431 (TID 683727 OR 0x7fcd153a0700) from PID 0; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t*, void*) in /usr/local/service/doris/lib/be/doris_be 1# os::Linux::chained_handler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 2# JVM_handle_linux_signal in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 3# signalHandler(int, siginfo*, void*) in /usr/local/jdk/jre/lib/amd64/server/libjvm.so 4# 0x00007FD26771E400 in /lib64/libc.so.6 5# doris::vectorized::ColumnArray::insert_from(doris::vectorized::IColumn const&, unsigned long) in /usr/local/service/doris/lib/be/doris_be 6# doris::vectorized::ColumnNullable::insert_from(doris::vectorized::IColumn const&, unsigned long) in /usr/local/service/doris/lib/be/doris_be 7# doris::vectorized::AggregateFunctionCollect<doris::vectorized::AggregateFunctionArrayAggData<void>, std::integral_constant<bool, false>, std::integral_constant<bool, true> >::streaming_agg_serialize_to_column(doris::vectorized::IColumn const**, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, unsigned long, doris::vectorized::Arena*) const in /usr/local/service/doris/lib/be/doris_be 8# doris::vectorized::AggFnEvaluator::streaming_agg_serialize_to_column(doris::vectorized::Block*, COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>&, unsigned long, doris::vectorized::Arena*) in /usr/local/service/doris/lib/be/doris_be 9# _ZNSt8__detail9__variant17__gen_vtable_implINS0_12_Multi_arrayIPFNS0_21__deduce_visit_resultIN5doris6StatusEEEONS4_10vectorized8OverloadIJZNS4_8pipeline22StreamingAggLocalState28_pre_agg_with_serialized_keyEPNS7_5BlockESC_E3$_0ZNSA_28_pre_agg_with_serialized_keyESC_SC_E3$_1EEERSt7variantIJNS7_16MethodSerializedI9PHHashMapINS4_9StringRefEPc11DefaultHashISK_vELb0EEEENS7_15MethodOneNumberIhSJ_IhSL_SM_IhvELb0EEEENSQ_ItSJ_ItSL_SM_ItvELb0EEEENSQ_IjSJ_IjSL_9HashCRC32IjELb0EEEENSQ_ImSJ_ImSL_SX_ImELb0EEEENS7_19MethodStringNoCacheINS4_13StringHashMapISL_9AllocatorILb1ELb1ELb0E22DefaultMemoryAllocatorEEEEENSQ_INS7_7UInt128ESJ_IS1B_SL_SX_IS1B_ELb0EEEENSQ_IjSJ_IjSL_14HashMixWrapperIjSY_ELb0EEEENSQ_ImSJ_ImSL_S1F_ImS11_ELb0EEEENSQ_IS1B_SJ_IS1B_SL_S1F_IS1B_S1C_ELb0EEEENS7_26MethodSingleNullableColumnINSQ_IhNS7_15DataWithNullKeyISS_EEEEEENS1P_INSQ_ItNS1Q_ISV_EEEEEENS1P_INSQ_IjNS1Q_ISZ_EEEEEENS1P_INSQ_ImNS1Q_IS12_EEEEEENS1P_INSQ_IjNS1Q_IS1H_EEEEEENS1P_INSQ_ImNS1Q_IS1K_EEEEEENS1P_INSQ_IS1B_NS1Q_IS1D_EEEEEENS1P_INSQ_IS1B_NS1Q_IS1N_EEEEEENS1P_INS14_INS1Q_IS19_EEEEEENS7_15MethodKeysFixedIS12_Lb0EEENS2I_IS12_Lb1EEENS2I_IS1D_Lb0EEENS2I_IS1D_Lb1EEENS2I_ISJ_INS7_7UInt256ESL_SX_IS2N_ELb0EELb0EEENS2I_IS2P_Lb1EEENS2I_ISJ_INS7_7UInt136ESL_SX_IS2S_ELb0EELb0EEENS2I_IS2U_Lb1EEENS2I_IS1K_Lb0EEENS2I_IS1K_Lb1EEENS2I_IS1N_Lb0EEENS2I_IS1N_Lb1EEENS2I_ISJ_IS2N_SL_S1F_IS2N_S2O_ELb0EELb0EEENS2I_IS32_Lb1EEENS2I_ISJ_IS2S_SL_S1F_IS2S_S2T_ELb0EELb0EEENS2I_IS36_Lb1EEEEEEJEEESt16integer_sequenceImJLm0EEEE14__visit_invokeESG_S3A_ in /usr/local/service/doris/lib/be/doris_be 10# doris::pipeline::StreamingAggLocalState::_pre_agg_with_serialized_key(doris::vectorized::Block*, doris::vectorized::Block*) in /usr/local/service/doris/lib/be/doris_be 11# doris::pipeline::StreamingAggLocalState::do_pre_agg(doris::vectorized::Block*, doris::vectorized::Block*) in /usr/local/service/doris/lib/be/doris_be 12# doris::pipeline::StreamingAggOperatorX::push(doris::RuntimeState*, doris::vectorized::Block*, bool) const in /usr/local/service/doris/lib/be/doris_be 13# doris::pipeline::StatefulOperatorX<doris::pipeline::StreamingAggLocalState>::get_block(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be 14# doris::pipeline::OperatorXBase::get_block_after_projects(doris::RuntimeState*, doris::vectorized::Block*, bool*) in /usr/local/service/doris/lib/be/doris_be 15# doris::pipeline::PipelineXTask::execute(bool*) in /usr/local/service/doris/lib/be/doris_be 16# doris::pipeline::TaskScheduler::_do_work(unsigned long) in /usr/local/service/doris/lib/be/doris_be 17# doris::ThreadPool::dispatch_thread() in /usr/local/service/doris/lib/be/doris_be 18# doris::Thread::supervise_thread(void*) in /usr/local/service/doris/lib/be/doris_be 19# start_thread in /lib64/libpthread.so.0 20# __clone in /lib64/libc.so.6 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
core
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)