Skip to content

branch-2.1: [fix](nereids) EliminateGroupByConstant should replace agg's group by after removing constant group by keys #49473 #50044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 16, 2025
Merged

branch-2.1: [fix](nereids) EliminateGroupByConstant should replace agg's group by after removing constant group by keys #49473 #50044

yiguolei merged 1 commit into from
Apr 16, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 15, 2025

Cherry-picked from #49473

@feiniaofeiafei
[fix](nereids) EliminateGroupByConstant should replace agg's group by…
bc015ef 
… after removing constant group by keys (#49473)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note
```sql
 SELECT
    IF(
        t.`gender` IN ('女'),
        (
            TIMESTAMPDIFF(
                YEAR,
                NOW(),
                NOW()
            )
        ),
        1
    ) AS x0,
    TIMESTAMPDIFF(
        YEAR,
        NOW(),
        NOW()
    ) AS x1
FROM
t1 AS t
GROUP BY
    x0,
    x1;
```
after EliminateGroupByConstant, this sql will be rewritten to
```sql
 SELECT
    IF(
        t.`gender` IN ('女'),
        0,
        1
    ) AS x0,
    0 AS x1
FROM
t1 AS t
GROUP BY
     IF(
        t.`gender` IN ('女'),
        (
            TIMESTAMPDIFF(
                YEAR,
                NOW(),
                NOW()
            )
        ),
        1
    ) ;
```
The select expression and the group by expression is different, and will
report error in normalizeagg.
This pr changes using the foldmap rewrite the group by expresssion, and
after change the sql after EliminateGroupByConstant become:
```sql
 SELECT
    IF(
        t.`gender` IN ('女'),
        0,
        1
    ) AS x0,
    0 AS x1
FROM
t1 AS t
GROUP BY
     IF(
        t.`gender` IN ('女'),
        0,
        1
    ) ;
```
the select expression and the group by expression becomes same.
@github-actions github-actions bot requested a review from yiguolei as a code owner April 15, 2025 03:30
@Thearas
Copy link
Contributor

Thearas commented Apr 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 15, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 15, 2025

run buildall

@yiguolei yiguolei merged commit bbdb057 into branch-2.1 Apr 16, 2025
20 checks passed
@github-actions github-actions bot deleted the auto-pick-49473-branch-2.1 branch April 16, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @yiguolei @dataroaring @feiniaofeiafei