Skip to content

[Improvement](memory) reduce some memtracker overhead #50063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 2 commits into from
Apr 16, 2025
Merged

[Improvement](memory) reduce some memtracker overhead #50063

BiteTheDDDDt merged 2 commits into from
Apr 16, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Apr 15, 2025 •
edited
Loading

What problem does this PR solve?

  1. some subcolumn will shared by multiple tasks, and do SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER at ctor/dtor, but some subcolumn from ColumnObject no need to do those things.
  2. Allocator::realloc_impl has some overhead coz doris::thread_context() ->thread_mem_tracker_mgr->limiter_mem_tracker(), add a shorcut to avoid this.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 15, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Apr 15, 2025

run buildall

eldenmoon
eldenmoon approved these changes Apr 15, 2025
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 15, 2025

PR approved by anyone and no changes requested.

xinyiZzz
xinyiZzz approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BiteTheDDDDt BiteTheDDDDt merged commit a45946d into apache:master Apr 16, 2025
30 of 32 checks passed
seawinde pushed a commit to seawinde/doris that referenced this pull request Apr 17, 2025
@BiteTheDDDDt @seawinde
[Improvement](memory) reduce some memtracker overhead (apache#50063)
9029bcf 
### What problem does this PR solve?
1. some subcolumn will shared by multiple tasks, and do
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER at ctor/dtor, but some
subcolumn from ColumnObject no need to do those things.
2. Allocator::realloc_impl has some overhead coz
`doris::thread_context()
->thread_mem_tracker_mgr->limiter_mem_tracker()`, add a shorcut to avoid
this.
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [x] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@wm1581066 wm1581066 added the usercase Important user case type label label May 20, 2025
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request May 20, 2025
@BiteTheDDDDt
[Improvement](memory) reduce some memtracker overhead (apache#50063)
3ecd294 
1. some subcolumn will shared by multiple tasks, and do
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER at ctor/dtor, but some
subcolumn from ColumnObject no need to do those things.
2. Allocator::realloc_impl has some overhead coz
`doris::thread_context()
->thread_mem_tracker_mgr->limiter_mem_tracker()`, add a shorcut to avoid
this.

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [x] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request May 20, 2025
Merged
BiteTheDDDDt added a commit that referenced this pull request May 21, 2025
@BiteTheDDDDt
[Improvement](memory) reduce some memtracker overhead (#50063) (#51068)
8bb8ec1 
pick from #50063
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@BiteTheDDDDt @koarz
[Improvement](memory) reduce some memtracker overhead (apache#50063)
2ed8869 
### What problem does this PR solve?
1. some subcolumn will shared by multiple tasks, and do
SCOPED_SWITCH_THREAD_MEM_TRACKER_LIMITER at ctor/dtor, but some
subcolumn from ColumnObject no need to do those things.
2. Allocator::realloc_impl has some overhead coz
`doris::thread_context()
->thread_mem_tracker_mgr->limiter_mem_tracker()`, add a shorcut to avoid
this.
### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [x] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xinyiZzz xinyiZzz xinyiZzz approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@BiteTheDDDDt @hello-stephen @xinyiZzz @eldenmoon @wm1581066