Skip to content

branch-2.1:[fix](nereids)Use utf-8 when convert string like literal to double. (#50085) #50155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 19, 2025
Merged

branch-2.1:[fix](nereids)Use utf-8 when convert string like literal to double. (#50085) #50155

yiguolei merged 1 commit into from
Apr 19, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Apr 18, 2025

backport: #50085

@Jibing-Li
[fix](nereids)Use utf-8 when convert string like literal to double. (a…
48e9329 
…pache#50085)

Use utf-8 when convert string like literal to double.
StringLike columns in Doris are all stored with utf-8 encoding. So we
need to use utf-8 encoding to read the column statistics min/max value.
Otherwise, Java will use the system default encoding. In this case,
doris may read wrong statistics min/max value.
@Jibing-Li Jibing-Li changed the title [fix](nereids)Use utf-8 when convert string like literal to double. (#50085) branch-2.1:[fix](nereids)Use utf-8 when convert string like literal to double. (#50085) Apr 18, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review April 18, 2025 02:31
@Jibing-Li Jibing-Li requested a review from yiguolei as a code owner April 18, 2025 02:31
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Apr 18, 2025

run buildall

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Apr 18, 2025

run feut

@yiguolei yiguolei merged commit 048537c into apache:branch-2.1 Apr 19, 2025
22 checks passed
@Jibing-Li Jibing-Li deleted the utf82.1 branch April 21, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jibing-Li @Thearas @yiguolei