-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](parquet)Fixed the problem that when Parquert reader use index to read files, there will be multiple threads modify same object #50161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o read files, there will be multiple threads modify same object
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34952 ms |
TPC-DS: Total hot run time: 185155 ms |
ClickBench: Total hot run time: 29.99 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
kaka11chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…o read files, there will be multiple threads modify same object (apache#50161) Related PR: apache#38432 Problem Summary: in pr apache#38432 , if parquet reader use index to reade file and file column name not eq table column name, reader will modify _colname_to_value_range . However, this object is held by multiple vfile scanners, and multi-threaded modification of this object will cause be core.
…o read files, there will be multiple threads modify same object (apache#50161) Related PR: apache#38432 Problem Summary: in pr apache#38432 , if parquet reader use index to reade file and file column name not eq table column name, reader will modify _colname_to_value_range . However, this object is held by multiple vfile scanners, and multi-threaded modification of this object will cause be core.
…o read files, there will be multiple threads modify same object (apache#50161) Related PR: apache#38432 Problem Summary: in pr apache#38432 , if parquet reader use index to reade file and file column name not eq table column name, reader will modify _colname_to_value_range . However, this object is held by multiple vfile scanners, and multi-threaded modification of this object will cause be core.
…o read files, there will be multiple threads modify same object (apache#50161) ### What problem does this PR solve? Related PR: apache#38432 Problem Summary: in pr apache#38432 , if parquet reader use index to reade file and file column name not eq table column name, reader will modify _colname_to_value_range . However, this object is held by multiple vfile scanners, and multi-threaded modification of this object will cause be core.
What problem does this PR solve?
Related PR: #38432
Problem Summary:
in pr #38432 , if parquet reader use index to reade file and file column name not eq table column name, reader will modify
_colname_to_value_range . However, this object is held by multiple vfile scanners, and multi-threaded modification of this object will cause be core.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)