Skip to content

[bugfix](hive) fix_hive_metastore_client_socket_timeout #50193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justfortaste wants to merge 0 commits into from
Closed

[bugfix](hive) fix_hive_metastore_client_socket_timeout #50193

justfortaste wants to merge 0 commits into from

Conversation

@justfortaste
Copy link
Contributor

@justfortaste justfortaste commented Apr 19, 2025 •
edited by liutang123
Loading

What problem does this PR solve?

bp #47378

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

liutang123
liutang123 approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@liutang123 liutang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

PR approved by anyone and no changes requested.

@liutang123
Copy link
Contributor

liutang123 commented Apr 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 21, 2025

TPC-H: Total hot run time: 40464 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 63a313af9a121b316fc3c17e2624b2d81120a04a, data reload: false

------ Round 1 ----------------------------------
q1	17601	6762	6648	6648
q2	2099	179	169	169
q3	10558	1060	1228	1060
q4	10711	760	675	675
q5	7756	2812	2813	2812
q6	225	137	134	134
q7	980	626	588	588
q8	9343	1980	1986	1980
q9	6607	6450	6413	6413
q10	7039	2288	2293	2288
q11	482	257	271	257
q12	401	220	210	210
q13	18019	3023	3046	3023
q14	249	210	212	210
q15	511	475	457	457
q16	684	598	579	579
q17	976	651	609	609
q18	7246	6698	6672	6672
q19	1423	1105	1140	1105
q20	566	216	221	216
q21	4718	3283	3470	3283
q22	1195	1097	1076	1076
Total cold run time: 109389 ms
Total hot run time: 40464 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6759	6677	6642	6642
q2	341	243	241	241
q3	3044	3104	3114	3104
q4	2165	1834	1873	1834
q5	5998	5920	5791	5791
q6	228	125	126	125
q7	2314	1845	1801	1801
q8	3365	3591	3539	3539
q9	8904	8823	8875	8823
q10	3565	3515	3509	3509
q11	604	496	495	495
q12	815	611	601	601
q13	13828	3103	3172	3103
q14	290	273	291	273
q15	505	462	453	453
q16	690	652	653	652
q17	1836	1611	1602	1602
q18	8243	7678	7657	7657
q19	1711	1560	1641	1560
q20	2047	1821	1827	1821
q21	5569	5442	5283	5283
q22	1133	1070	1004	1004
Total cold run time: 73954 ms
Total hot run time: 59913 ms

@doris-robot
Copy link

doris-robot commented Apr 21, 2025

TPC-DS: Total hot run time: 196706 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 63a313af9a121b316fc3c17e2624b2d81120a04a, data reload: false

query1	1270	911	876	876
query2	6351	1989	1965	1965
query3	10853	4196	4195	4195
query4	59980	29064	23525	23525
query5	5215	470	468	468
query6	409	180	189	180
query7	5520	321	301	301
query8	298	208	210	208
query9	8676	2602	2592	2592
query10	466	252	260	252
query11	17783	15145	15772	15145
query12	160	103	110	103
query13	1484	469	439	439
query14	9850	6989	7268	6989
query15	201	184	174	174
query16	7182	482	482	482
query17	1149	598	595	595
query18	1884	330	321	321
query19	206	169	159	159
query20	118	116	112	112
query21	208	106	107	106
query22	4543	4514	4668	4514
query23	34435	34004	34058	34004
query24	6295	2964	2960	2960
query25	533	436	422	422
query26	654	174	167	167
query27	1985	358	375	358
query28	4118	2444	2433	2433
query29	714	474	474	474
query30	253	166	171	166
query31	1005	806	812	806
query32	70	53	59	53
query33	470	286	282	282
query34	891	504	512	504
query35	828	755	725	725
query36	1069	931	959	931
query37	117	66	66	66
query38	4061	3988	3974	3974
query39	1511	1521	1466	1466
query40	211	102	101	101
query41	52	49	49	49
query42	116	101	102	101
query43	523	484	491	484
query44	1150	798	785	785
query45	185	173	169	169
query46	1143	733	722	722
query47	2038	1895	1886	1886
query48	494	381	388	381
query49	749	405	381	381
query50	823	430	432	430
query51	7384	7322	7153	7153
query52	102	90	89	89
query53	256	185	184	184
query54	580	462	465	462
query55	80	76	90	76
query56	286	273	254	254
query57	1314	1114	1161	1114
query58	237	211	225	211
query59	3168	3049	3030	3030
query60	291	269	254	254
query61	112	106	105	105
query62	796	659	681	659
query63	222	190	182	182
query64	1375	661	643	643
query65	3253	3178	3187	3178
query66	709	293	302	293
query67	15995	15559	15526	15526
query68	4218	587	581	581
query69	430	263	270	263
query70	1157	1096	1097	1096
query71	361	256	258	256
query72	6334	4049	3948	3948
query73	760	345	351	345
query74	10194	8974	9278	8974
query75	3388	2638	2645	2638
query76	2250	1095	973	973
query77	466	273	268	268
query78	10463	9636	9599	9599
query79	1813	583	590	583
query80	908	425	429	425
query81	521	238	238	238
query82	187	85	89	85
query83	170	148	142	142
query84	289	85	80	80
query85	946	321	284	284
query86	393	297	286	286
query87	4492	4217	4249	4217
query88	4623	2404	2365	2365
query89	410	290	296	290
query90	1981	183	182	182
query91	181	148	148	148
query92	60	48	50	48
query93	2128	556	548	548
query94	807	295	296	295
query95	355	257	249	249
query96	629	297	283	283
query97	3360	3144	3166	3144
query98	211	203	198	198
query99	1517	1281	1282	1281
Total cold run time: 312461 ms
Total hot run time: 196706 ms

@doris-robot
Copy link

doris-robot commented Apr 21, 2025

ClickBench: Total hot run time: 31.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 63a313af9a121b316fc3c17e2624b2d81120a04a, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.53	0.52	0.51
query6	1.14	0.73	0.73
query7	0.03	0.01	0.01
query8	0.04	0.04	0.05
query9	0.56	0.49	0.48
query10	0.55	0.56	0.55
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.61	0.60	0.59
query14	2.73	2.72	2.73
query15	0.90	0.83	0.82
query16	0.39	0.37	0.40
query17	1.01	1.01	1.06
query18	0.24	0.21	0.22
query19	1.84	1.77	2.06
query20	0.02	0.01	0.02
query21	15.37	0.60	0.57
query22	2.56	2.42	1.73
query23	17.14	0.88	1.00
query24	3.41	1.00	1.47
query25	0.32	0.05	0.16
query26	0.46	0.13	0.14
query27	0.05	0.04	0.05
query28	9.76	0.50	0.51
query29	12.57	3.22	3.26
query30	0.25	0.06	0.06
query31	2.87	0.38	0.38
query32	3.25	0.46	0.46
query33	3.00	3.03	3.01
query34	16.82	4.50	4.45
query35	4.51	4.49	4.46
query36	0.67	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.03
Total cold run time: 106.33 s
Total hot run time: 31.97 s

@liutang123 liutang123 closed this Apr 23, 2025
@liutang123 liutang123 force-pushed the fix_hive_metastore_client_socket_timeout_30 branch from 63a313a to ebbe891 Compare April 23, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liutang123 liutang123 liutang123 approved these changes

@dataroaring dataroaring Awaiting requested review from dataroaring

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@justfortaste @hello-stephen @liutang123 @doris-robot