Skip to content

Branch-3.0 Cherry-pick [Fix](Variant) fix variant cast to jsonb into wrong NULL values (#50180) #50234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 22, 2025
Merged

Branch-3.0 Cherry-pick [Fix](Variant) fix variant cast to jsonb into wrong NULL values (#50180) #50234

dataroaring merged 1 commit into from
Apr 22, 2025

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Apr 21, 2025

cherry-pick from #50180

@eldenmoon
[Fix](Variant) fix variant cast to jsonb into wrong NULL values (apac…
a49deff 
…he#50180)

1. implement cast to jsonb in `ConvertImplGenericFromVariant`
2. implement `DataTypeObjectSerDe::serialize_column_to_json`
@eldenmoon eldenmoon requested a review from dataroaring as a code owner April 21, 2025 07:48
@eldenmoon
Copy link
Member Author

eldenmoon commented Apr 21, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Apr 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Apr 21, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/11) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.13% (10514/26198)
Line Coverage 30.75% (88277/287065)
Region Coverage 29.86% (45504/152371)
Branch Coverage 26.22% (23061/87938)

dataroaring
dataroaring approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 415c2fc into apache:branch-3.0 Apr 22, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eldenmoon @Thearas @doris-robot @dataroaring