Skip to content

branch-2.1: [opt](hive) add option to get schema from table object #50038 #50269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 22, 2025
Merged

branch-2.1: [opt](hive) add option to get schema from table object #50038 #50269

yiguolei merged 1 commit into from
Apr 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 22, 2025

Cherry-picked from #50038

@morningman
[opt](hive) add option to get schema from table object (#50038)
5790f5b 
### What problem does this PR solve?

Sometimes user may meet error:
```
Storage schema reading not supported
```
when using hive catalog to query table.

Because there are some compatibility issue in hive metastore, see
trinodb/trino#2678.
So here we provide a catalog property:

`get_schema_from_table`.

Default is false, which will still get schema from hive metastore like
before.
If set to true, the schema will be got from `table` object directly, to
avoid above error.
But notice that if set to true, the default value of column will be
ignored because the `table` object
does not store this information.
@github-actions github-actions bot requested a review from yiguolei as a code owner April 22, 2025 02:31
@Thearas
Copy link
Contributor

Thearas commented Apr 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 22, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 22, 2025

run buildall

@yiguolei yiguolei merged commit 1efe62c into branch-2.1 Apr 22, 2025
20 checks passed
@github-actions github-actions bot deleted the auto-pick-50038-branch-2.1 branch April 22, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @yiguolei @dataroaring @morningman