Skip to content

branch-3.0: [Fix](compaction) Only print delete compaction log when there is a delete rowset #49953 #50291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Apr 23, 2025
Merged

branch-3.0: [Fix](compaction) Only print delete compaction log when there is a delete rowset #49953 #50291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions be/src/olap/cumulative_compaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,13 @@ Status CumulativeCompaction::pick_rowsets_to_compact() {
// plus 1 to skip the delete version.
// NOTICE: after that, the cumulative point may be larger than max version of this tablet, but it doesn't matter.
tablet()->set_cumulative_layer_point(_last_delete_version.first + 1);
LOG_INFO(
"cumulative compaction meet delete rowset, increase cumu point without "
"other "
"operation.")
.tag("tablet id:", tablet()->tablet_id())
.tag("after cumulative compaction, cumu point:",
tablet()->cumulative_layer_point());
return Status::Error<CUMULATIVE_NO_SUITABLE_VERSION>(
"_last_delete_version.first not equal to -1");
}
Expand Down
6 changes: 0 additions & 6 deletions be/src/olap/tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1722,12 +1722,6 @@ Status Tablet::prepare_compaction_and_calculate_permits(
// return OK if OLAP_ERR_CUMULATIVE_NO_SUITABLE_VERSION, so that we don't need to
// print too much useless logs.
// And because we set permits to 0, so even if we return OK here, nothing will be done.
LOG_INFO(
"cumulative compaction meet delete rowset, increase cumu point without other "
"operation.")
.tag("tablet id:", tablet->tablet_id())
.tag("after cumulative compaction, cumu point:",
tablet->cumulative_layer_point());
return Status::OK();
}
} else if (compaction_type == CompactionType::BASE_COMPACTION) {
Expand Down
Loading