Skip to content

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented Apr 22, 2025

What problem does this PR solve?

selectdb/ccr-syncer#599

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@koarz
Copy link
Contributor Author

koarz commented Apr 22, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33792 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8ed799c368444487af9d73759403824e19793c99, data reload: false

------ Round 1 ----------------------------------
q1	26079	5019	4977	4977
q2	2069	283	176	176
q3	10392	1249	668	668
q4	10213	982	538	538
q5	7506	2339	2345	2339
q6	172	161	129	129
q7	904	731	604	604
q8	9306	1291	1089	1089
q9	6915	5086	5078	5078
q10	6795	2315	1887	1887
q11	468	280	269	269
q12	353	352	218	218
q13	17761	3679	3036	3036
q14	228	226	210	210
q15	545	482	481	481
q16	444	453	405	405
q17	596	851	360	360
q18	7472	7314	7172	7172
q19	1221	939	533	533
q20	329	323	222	222
q21	3974	3311	2440	2440
q22	1028	1013	961	961
Total cold run time: 114770 ms
Total hot run time: 33792 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5040	5038	5050	5038
q2	234	326	231	231
q3	2109	2606	2214	2214
q4	1403	1782	1366	1366
q5	4380	4402	4360	4360
q6	213	168	129	129
q7	2002	1949	1765	1765
q8	2591	2619	2541	2541
q9	7266	7225	7006	7006
q10	3006	3186	2686	2686
q11	570	514	490	490
q12	660	772	619	619
q13	3436	3911	3236	3236
q14	281	292	270	270
q15	527	494	467	467
q16	477	499	460	460
q17	1133	1571	1331	1331
q18	7702	7457	7476	7457
q19	805	838	984	838
q20	2017	2037	1821	1821
q21	5166	4746	4796	4746
q22	1059	1066	1020	1020
Total cold run time: 52077 ms
Total hot run time: 50091 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191723 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8ed799c368444487af9d73759403824e19793c99, data reload: false

query1	1444	1120	1064	1064
query2	6231	1837	1860	1837
query3	11038	4478	4453	4453
query4	25865	23382	23017	23017
query5	3575	605	465	465
query6	289	194	190	190
query7	3977	484	275	275
query8	291	248	221	221
query9	8458	2564	2545	2545
query10	455	333	256	256
query11	15241	15101	14751	14751
query12	163	121	108	108
query13	1563	515	396	396
query14	8924	6308	6130	6130
query15	215	195	162	162
query16	7316	625	479	479
query17	1195	741	596	596
query18	1997	417	317	317
query19	189	188	163	163
query20	135	122	121	121
query21	209	128	110	110
query22	4716	4608	4655	4608
query23	34583	33517	33616	33517
query24	8604	2447	2465	2447
query25	527	450	395	395
query26	1217	269	152	152
query27	2785	504	339	339
query28	4669	2167	2118	2118
query29	708	562	441	441
query30	275	219	191	191
query31	900	876	777	777
query32	72	88	61	61
query33	549	365	302	302
query34	806	880	529	529
query35	805	844	775	775
query36	948	1010	883	883
query37	112	99	75	75
query38	4240	4118	4150	4118
query39	1468	1409	1458	1409
query40	229	124	107	107
query41	61	51	51	51
query42	128	107	107	107
query43	509	523	491	491
query44	1327	816	823	816
query45	176	174	167	167
query46	850	1031	642	642
query47	1795	1896	1817	1817
query48	384	416	313	313
query49	757	519	424	424
query50	653	702	399	399
query51	4246	4311	4222	4222
query52	116	108	98	98
query53	236	268	194	194
query54	588	593	508	508
query55	82	82	78	78
query56	320	294	303	294
query57	1159	1203	1138	1138
query58	289	263	258	258
query59	2741	2889	2744	2744
query60	332	316	295	295
query61	122	122	130	122
query62	796	751	695	695
query63	225	186	193	186
query64	4145	1055	666	666
query65	4437	4448	4328	4328
query66	1055	410	303	303
query67	15940	15653	15298	15298
query68	7812	877	508	508
query69	481	294	267	267
query70	1142	1166	1104	1104
query71	406	319	291	291
query72	5850	4670	4689	4670
query73	657	591	341	341
query74	9117	9166	8637	8637
query75	3200	3171	2687	2687
query76	3204	1191	746	746
query77	471	371	276	276
query78	9968	10118	9295	9295
query79	2792	812	572	572
query80	1020	493	432	432
query81	504	246	214	214
query82	422	123	100	100
query83	239	249	222	222
query84	245	146	81	81
query85	752	359	312	312
query86	380	297	300	297
query87	4397	4394	4253	4253
query88	3906	2164	2171	2164
query89	403	307	282	282
query90	1867	203	206	203
query91	139	137	110	110
query92	76	59	58	58
query93	2657	942	579	579
query94	749	375	305	305
query95	374	285	289	285
query96	481	563	265	265
query97	3094	3199	3096	3096
query98	234	203	200	200
query99	1332	1428	1317	1317
Total cold run time: 278823 ms
Total hot run time: 191723 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.15 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8ed799c368444487af9d73759403824e19793c99, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.11	0.11
query3	0.25	0.20	0.19
query4	1.59	0.20	0.18
query5	0.60	0.58	0.59
query6	1.22	0.70	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.56	0.51	0.51
query10	0.58	0.57	0.56
query11	0.16	0.11	0.11
query12	0.14	0.12	0.12
query13	0.61	0.60	0.59
query14	1.14	1.19	1.16
query15	0.86	0.84	0.84
query16	0.38	0.39	0.38
query17	1.00	1.02	1.03
query18	0.21	0.20	0.20
query19	1.90	1.74	1.82
query20	0.02	0.01	0.02
query21	15.40	0.89	0.53
query22	0.74	1.13	0.70
query23	14.96	1.31	0.60
query24	7.31	1.77	0.55
query25	0.44	0.16	0.09
query26	0.60	0.15	0.14
query27	0.05	0.06	0.04
query28	9.43	0.83	0.41
query29	12.55	3.91	3.31
query30	0.26	0.09	0.06
query31	2.83	0.57	0.40
query32	3.22	0.54	0.47
query33	3.03	3.10	3.04
query34	15.72	5.08	4.46
query35	4.54	4.48	4.50
query36	0.67	0.49	0.48
query37	0.08	0.07	0.06
query38	0.05	0.05	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.65 s
Total hot run time: 29.15 s

@koarz
Copy link
Contributor Author

koarz commented Apr 23, 2025

run feut

@koarz koarz closed this Apr 24, 2025
@koarz koarz deleted the fix_upsert_with_default_key branch April 28, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants