[feat](func) any function supports json #50311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34128 ms |
TPC-DS: Total hot run time: 186283 ms |
ClickBench: Total hot run time: 29.68 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run external |
yiguolei
reviewed
Apr 23, 2025
|
|
||
| /** For JSON values. Similar to SingleValueDataString but specifically for JSON binary format. | ||
| */ | ||
| struct SingleValueDataJsonb { |
| AggregateFunctionsSingleValue<Data<SingleValueDataString>>>(argument_types, | ||
| result_is_nullable); | ||
| } | ||
| if (which.idx == TypeIndex::JSONB) { |
Contributor
There was a problem hiding this comment.
min/max is also register by this create_aggregate_function_single_value function,
maybe have error for min/max?
| } | ||
| }; | ||
|
|
||
| /** For JSON values. Similar to SingleValueDataString but specifically for JSON binary format. |
Contributor
There was a problem hiding this comment.
SingleValueDataJsonb code seems is same with SingleValueDataString,
so if use SingleValueDataString for json type,
what problem is report?
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33889 ms |
TPC-DS: Total hot run time: 185289 ms |
ClickBench: Total hot run time: 29.54 s |
Contributor
Author
|
run p0 |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33997 ms |
TPC-DS: Total hot run time: 189739 ms |
ClickBench: Total hot run time: 30.02 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
yiguolei
previously approved these changes
Apr 27, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
Author
|
run cloud_p0 |
Contributor
Author
|
run p0 |
Contributor
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34116 ms |
TPC-DS: Total hot run time: 185467 ms |
ClickBench: Total hot run time: 29.32 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Apr 28, 2025
Contributor
BE Regression P0 && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
pushed a commit
that referenced
this pull request
Apr 29, 2025
dataroaring
pushed a commit
that referenced
this pull request
May 6, 2025
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Make any function support json.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)