[fix](iceberg)Use the correct schema for query #50376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33871 ms |
TPC-DS: Total hot run time: 192706 ms |
ClickBench: Total hot run time: 30.24 s |
morningman
force-pushed
the
fix-iceschema
branch
from
d22a8e2 to
7a7cd47
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 33756 ms |
TPC-DS: Total hot run time: 192072 ms |
ClickBench: Total hot run time: 29.3 s |
hubgeter
approved these changes
Apr 29, 2025
Contributor
|
PR approved by anyone and no changes requested. |
CalvinKirs
reviewed
Apr 29, 2025
| CREATE_TIME, | ||
| USE_META_CACHE); | ||
|
|
||
| protected static final int ICEBERG_CATALOG_EXECUTOR_THREAD_NUM = Runtime.getRuntime().availableProcessors(); |
Member
There was a problem hiding this comment.
Isn't it a bit of a luxury for each catalog to hold as many threads as the number of CPU cores?
Contributor
There was a problem hiding this comment.
Isn't it a bit of a luxury for each catalog to hold as many threads as the number of CPU cores?
Yes, it will be optimized later. This PR does not change the origin logic, just remove the code to a new place
suxiaogang223
approved these changes
Apr 29, 2025
morningman
approved these changes
Apr 29, 2025
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? Followup apache#49956 Problem Summary: When a snapshot is specified in the query, the corresponding schema should be used for parsing, otherwise the latest snapshot should be used for parsing. 1. When using the HMS type, you also need to initialize the executor pool. 2. Set the size of the thread pool to be equal to the number of cores of the current machine. 3. When no snapshot is specified, the latest schema is used. 4. When specifying a snapshot, you need to use the schema corresponding to the snapshot. 5. When generating a scannode, save the schema information and no longer obtain it from the cache to prevent the cache from being refreshed. 6. When refreshing the schema, you need to refresh all schemas of related tables.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 24, 2025
Followup apache#49956 Problem Summary: When a snapshot is specified in the query, the corresponding schema should be used for parsing, otherwise the latest snapshot should be used for parsing. 1. When using the HMS type, you also need to initialize the executor pool. 2. Set the size of the thread pool to be equal to the number of cores of the current machine. 3. When no snapshot is specified, the latest schema is used. 4. When specifying a snapshot, you need to use the schema corresponding to the snapshot. 5. When generating a scannode, save the schema information and no longer obtain it from the cache to prevent the cache from being refreshed. 6. When refreshing the schema, you need to refresh all schemas of related tables.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 25, 2025
Followup apache#49956 Problem Summary: When a snapshot is specified in the query, the corresponding schema should be used for parsing, otherwise the latest snapshot should be used for parsing. 1. When using the HMS type, you also need to initialize the executor pool. 2. Set the size of the thread pool to be equal to the number of cores of the current machine. 3. When no snapshot is specified, the latest schema is used. 4. When specifying a snapshot, you need to use the schema corresponding to the snapshot. 5. When generating a scannode, save the schema information and no longer obtain it from the cache to prevent the cache from being refreshed. 6. When refreshing the schema, you need to refresh all schemas of related tables.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 30, 2025
Followup apache#49956 Problem Summary: When a snapshot is specified in the query, the corresponding schema should be used for parsing, otherwise the latest snapshot should be used for parsing. 1. When using the HMS type, you also need to initialize the executor pool. 2. Set the size of the thread pool to be equal to the number of cores of the current machine. 3. When no snapshot is specified, the latest schema is used. 4. When specifying a snapshot, you need to use the schema corresponding to the snapshot. 5. When generating a scannode, save the schema information and no longer obtain it from the cache to prevent the cache from being refreshed. 6. When refreshing the schema, you need to refresh all schemas of related tables.
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 30, 2025
Followup apache#49956 Problem Summary: When a snapshot is specified in the query, the corresponding schema should be used for parsing, otherwise the latest snapshot should be used for parsing. 1. When using the HMS type, you also need to initialize the executor pool. 2. Set the size of the thread pool to be equal to the number of cores of the current machine. 3. When no snapshot is specified, the latest schema is used. 4. When specifying a snapshot, you need to use the schema corresponding to the snapshot. 5. When generating a scannode, save the schema information and no longer obtain it from the cache to prevent the cache from being refreshed. 6. When refreshing the schema, you need to refresh all schemas of related tables.
morningman
added a commit
that referenced
this pull request
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Followup #49956
Problem Summary:
When a snapshot is specified in the query, the corresponding schema should be used for parsing, otherwise the latest snapshot should be used for parsing.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)