-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improve](load) introduce black list of backend when load job fetch meta to avoid jitter #50587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33555 ms |
TPC-DS: Total hot run time: 192319 ms |
ClickBench: Total hot run time: 29.15 s |
|
run buildall |
TPC-H: Total hot run time: 33544 ms |
TPC-DS: Total hot run time: 191777 ms |
ClickBench: Total hot run time: 29.05 s |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 33676 ms |
TPC-DS: Total hot run time: 192259 ms |
ClickBench: Total hot run time: 29.22 s |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 33884 ms |
TPC-DS: Total hot run time: 194463 ms |
ClickBench: Total hot run time: 29.39 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34042 ms |
TPC-DS: Total hot run time: 194342 ms |
ClickBench: Total hot run time: 29.36 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…eta to avoid jitter (#50587) ### What problem does this PR solve? Introduce black list of backend when load job fetch meta to avoid jitter: 1. Fetching meta operation would select one node randomly, If one node abnormal continuously, fetching meta operation will timeout and cause load speed jitter. 2. When will one backend added to the blacklist: - Fetch meta RPC failed. - Retry to other backend success. 3. When will one backend removed to the blacklist: - Two minutes automatic expiration. Other improvement of fetching meta retry: will not choose be failed in the same request.
…eta to avoid jitter (apache#50587) ### What problem does this PR solve? Introduce black list of backend when load job fetch meta to avoid jitter: 1. Fetching meta operation would select one node randomly, If one node abnormal continuously, fetching meta operation will timeout and cause load speed jitter. 2. When will one backend added to the blacklist: - Fetch meta RPC failed. - Retry to other backend success. 3. When will one backend removed to the blacklist: - Two minutes automatic expiration. Other improvement of fetching meta retry: will not choose be failed in the same request.
What problem does this PR solve?
Introduce black list of backend when load job fetch meta to avoid jitter:
Fetching meta operation would select one node randomly, If one node abnormal continuously, fetching meta operation will timeout and cause load speed jitter.
When will one backend added to the blacklist:
Other improvement of fetching meta retry: will not choose be failed in the same request.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)