-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](cloud) support param to drop fe cluster not in safe time #50680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
run buildall |
33eae59 to
98259ef
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34056 ms |
TPC-DS: Total hot run time: 192751 ms |
ClickBench: Total hot run time: 29.52 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run p0 |
|
run external |
1 similar comment
|
run external |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
@xy720 这个pr怎么没推进合入啊? |
|
We're closing this PR because it hasn't been updated in a while. |
What problem does this PR solve?
related pr: #45255
Currently, when the MS drop node/drop cluster api is called to the drop sql node/sql cluster, there is a 5 minute safe drop protection mechanism, but it is not necessary when destroying a newly created doris instance.
Allow bypassing the safe-time-check when calling the drop cluster api of meta service by setting the safe_derop_on_sql_cluster param to false
Add a configuration for the safe-time-check (default 5 minutes) to adjust this value
Api call example:
curl -X POST -H "Content-Type: text/plain" -d '{"instance_id": "123333", "cluster": {"cluster_name": "RESERVED_CLUSTER_NAME_FOR_SQL_SERVER", "cluster_id": "RESERVED_CLUSTER_ID_FOR_SQL_SERVER"}, "safe_drop_on_sql_cluster": "false"}' http://127.0.0.1:5000/MetaService/http/drop_cluster?token=xxxxxxxx
reopen #50535
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)