Skip to content

[fix](iceberg)Table operations are not supported for catalogs of the dlf type. #50696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
May 15, 2025
Merged

[fix](iceberg)Table operations are not supported for catalogs of the dlf type. #50696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/IcebergDLFExternalCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,17 @@

package org.apache.doris.datasource.iceberg;

import org.apache.doris.analysis.CreateDbStmt;
import org.apache.doris.analysis.CreateTableStmt;
import org.apache.doris.analysis.DropTableStmt;
import org.apache.doris.analysis.TruncateTableStmt;
import org.apache.doris.common.DdlException;
import org.apache.doris.common.UserException;
import org.apache.doris.datasource.CatalogProperty;
import org.apache.doris.datasource.iceberg.dlf.DLFCatalog;
import org.apache.doris.datasource.property.PropertyConverter;
import org.apache.doris.datasource.property.constants.HMSProperties;
import org.apache.doris.nereids.exceptions.NotSupportedException;

import java.util.Map;

Expand All @@ -45,4 +52,35 @@ protected void initCatalog() {
dlfCatalog.initialize(catalogName, catalogProperties);
catalog = dlfCatalog;
}

@Override
public void createDb(CreateDbStmt stmt) throws DdlException {
throw new NotSupportedException("iceberg catalog with dlf type not supports 'create database'");
}

@Override
public void dropDb(String dbName, boolean ifExists, boolean force) throws DdlException {
throw new NotSupportedException("iceberg catalog with dlf type not supports 'drop database'");
}

@Override
public boolean createTable(CreateTableStmt stmt) throws UserException {
throw new NotSupportedException("iceberg catalog with dlf type not supports 'create table'");
}

@Override
public void dropTable(DropTableStmt stmt) throws DdlException {
throw new NotSupportedException("iceberg catalog with dlf type not supports 'drop table'");
}

@Override
public void dropTable(String dbName, String tableName, boolean isView, boolean isMtmv, boolean ifExists,
boolean force) throws DdlException {
throw new NotSupportedException("iceberg catalog with dlf type not supports 'drop table'");
}

@Override
public void truncateTable(TruncateTableStmt stmt) throws DdlException {
throw new NotSupportedException("iceberg catalog with dlf type not supports 'truncate table'");
}
}
15 changes: 15 additions & 0 deletions ...st/java/org/apache/doris/datasource/iceberg/dlf/client/IcebergDLFExternalCatalogTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@

package org.apache.doris.datasource.iceberg.dlf.client;

import org.apache.doris.datasource.iceberg.IcebergDLFExternalCatalog;
import org.apache.doris.nereids.exceptions.NotSupportedException;

import org.apache.hadoop.conf.Configuration;
import org.junit.Assert;
import org.junit.Test;
Expand All @@ -38,4 +41,16 @@ public void testDatabaseList() {
Assert.assertNotSame(dlfClientPool1, dlfClientPool2);

}

@Test
public void testNotSupportOperation() {
HashMap<String, String> props = new HashMap<>();
IcebergDLFExternalCatalog catalog = new IcebergDLFExternalCatalog(1, "test", "test", props, "test");
Assert.assertThrows(NotSupportedException.class, () -> catalog.createDb(null));
Assert.assertThrows(NotSupportedException.class, () -> catalog.dropDb("", true, true));
Assert.assertThrows(NotSupportedException.class, () -> catalog.createTable(null));
Assert.assertThrows(NotSupportedException.class, () -> catalog.dropTable(null));
Assert.assertThrows(NotSupportedException.class, () -> catalog.dropTable("", "", true, true, true, true));
Assert.assertThrows(NotSupportedException.class, () -> catalog.truncateTable(null));
}
}
Loading