Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented May 8, 2025

What problem does this PR solve?

#46748 should also be in rollup tasks.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented May 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented May 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33869 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1889db28951d4c454d0c81f2844230d294b45645, data reload: false

------ Round 1 ----------------------------------
q1	26282	5097	5017	5017
q2	2075	290	185	185
q3	10416	1272	708	708
q4	10236	998	558	558
q5	7706	2421	2274	2274
q6	187	164	131	131
q7	925	751	626	626
q8	9320	1356	1109	1109
q9	6883	5088	5134	5088
q10	6815	2301	1941	1941
q11	475	274	264	264
q12	363	342	212	212
q13	17775	3707	3082	3082
q14	228	223	206	206
q15	536	470	474	470
q16	414	422	373	373
q17	600	857	378	378
q18	7694	7167	7055	7055
q19	1211	974	562	562
q20	329	338	218	218
q21	3882	3329	2450	2450
q22	1026	1008	962	962
Total cold run time: 115378 ms
Total hot run time: 33869 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5100	5116	5077	5077
q2	237	324	225	225
q3	2135	2673	2268	2268
q4	1399	1788	1334	1334
q5	4584	4414	4409	4409
q6	219	166	127	127
q7	2037	1974	1730	1730
q8	2595	2592	2507	2507
q9	7274	7118	7091	7091
q10	2967	3157	2712	2712
q11	585	511	482	482
q12	720	803	638	638
q13	3453	3989	3230	3230
q14	303	312	264	264
q15	525	480	464	464
q16	435	478	459	459
q17	1161	1585	1369	1369
q18	7660	7414	7421	7414
q19	834	775	833	775
q20	1957	2068	1873	1873
q21	5289	4499	4474	4474
q22	1031	1018	994	994
Total cold run time: 52500 ms
Total hot run time: 49916 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185923 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1889db28951d4c454d0c81f2844230d294b45645, data reload: false

query1	999	464	483	464
query2	6566	1794	1765	1765
query3	6744	231	230	230
query4	26764	23577	23535	23535
query5	4363	673	450	450
query6	293	194	194	194
query7	4616	481	274	274
query8	289	244	224	224
query9	8631	2532	2553	2532
query10	502	331	268	268
query11	15370	15055	14870	14870
query12	160	111	111	111
query13	1662	504	401	401
query14	8633	6072	6130	6072
query15	225	197	167	167
query16	7136	631	460	460
query17	1215	744	586	586
query18	1980	413	311	311
query19	195	189	163	163
query20	120	121	118	118
query21	214	126	109	109
query22	4238	4248	4194	4194
query23	33919	33041	32928	32928
query24	8456	2373	2367	2367
query25	526	444	414	414
query26	1247	263	154	154
query27	2765	492	321	321
query28	4386	2067	2046	2046
query29	776	550	423	423
query30	285	215	186	186
query31	911	857	757	757
query32	89	66	61	61
query33	552	359	313	313
query34	792	906	503	503
query35	768	803	734	734
query36	955	987	899	899
query37	112	99	83	83
query38	4196	4170	4082	4082
query39	1516	1404	1400	1400
query40	214	116	104	104
query41	59	53	55	53
query42	115	109	109	109
query43	476	487	473	473
query44	1312	804	801	801
query45	183	176	167	167
query46	828	1001	616	616
query47	1753	1774	1725	1725
query48	377	412	286	286
query49	788	489	416	416
query50	652	674	395	395
query51	4083	4156	4043	4043
query52	103	104	93	93
query53	213	252	183	183
query54	580	555	491	491
query55	81	77	85	77
query56	300	287	291	287
query57	1158	1189	1095	1095
query58	255	252	252	252
query59	2613	2658	2586	2586
query60	330	307	308	307
query61	126	125	124	124
query62	833	757	667	667
query63	227	186	188	186
query64	4402	1027	721	721
query65	4352	4279	4233	4233
query66	1139	399	314	314
query67	15621	15590	15263	15263
query68	7970	877	496	496
query69	465	312	264	264
query70	1137	1077	1105	1077
query71	482	372	309	309
query72	5730	4730	4737	4730
query73	646	611	346	346
query74	9184	9017	8944	8944
query75	3833	3202	2682	2682
query76	3562	1185	743	743
query77	792	373	278	278
query78	9988	10065	9317	9317
query79	2434	805	550	550
query80	610	514	451	451
query81	494	253	213	213
query82	467	133	96	96
query83	251	253	228	228
query84	252	110	88	88
query85	856	347	317	317
query86	385	314	314	314
query87	4390	4433	4335	4335
query88	3746	2250	2207	2207
query89	389	315	282	282
query90	1838	216	233	216
query91	146	140	119	119
query92	71	60	58	58
query93	1978	926	563	563
query94	660	407	309	309
query95	372	297	289	289
query96	482	572	272	272
query97	3135	3212	3128	3128
query98	260	198	218	198
query99	1379	1433	1268	1268
Total cold run time: 274723 ms
Total hot run time: 185923 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.68 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1889db28951d4c454d0c81f2844230d294b45645, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.26	0.20	0.19
query4	1.60	0.20	0.18
query5	0.61	0.58	0.60
query6	1.26	0.72	0.73
query7	0.03	0.02	0.02
query8	0.04	0.04	0.03
query9	0.59	0.53	0.51
query10	0.56	0.59	0.57
query11	0.15	0.11	0.11
query12	0.16	0.11	0.12
query13	0.61	0.59	0.60
query14	0.78	0.78	0.83
query15	0.87	0.85	0.83
query16	0.40	0.39	0.39
query17	1.01	1.05	1.03
query18	0.21	0.20	0.20
query19	1.99	1.80	1.79
query20	0.02	0.00	0.01
query21	15.41	0.91	0.55
query22	0.76	1.17	0.64
query23	14.94	1.39	0.62
query24	7.38	2.01	0.39
query25	0.45	0.11	0.07
query26	0.73	0.17	0.14
query27	0.06	0.05	0.05
query28	9.10	0.89	0.43
query29	12.55	3.97	3.28
query30	0.25	0.08	0.07
query31	2.82	0.61	0.37
query32	3.23	0.55	0.47
query33	3.12	3.14	3.05
query34	15.75	5.17	4.48
query35	4.50	4.54	4.52
query36	0.66	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.07	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 103.49 s
Total hot run time: 28.68 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented May 9, 2025

run cloud_p0

Copy link
Collaborator

@Hastyshell Hastyshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit d6f7e50 into apache:master May 13, 2025
32 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request May 13, 2025
…in cloud mode (#50705)

### What problem does this PR solve?

#46748 should also be in rollup
tasks.
dataroaring pushed a commit that referenced this pull request May 13, 2025
…XN_CONFILCT in cloud mode #50705 (#50836)

Cherry-picked from #50705

Co-authored-by: bobhan1 <baohan@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…in cloud mode (apache#50705)

### What problem does this PR solve?

apache#46748 should also be in rollup
tasks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants