-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Refactor] Refactor ConnectContext.getCluster #50783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
a994586 to
1a5b229
Compare
|
run buildall |
TPC-H: Total hot run time: 33923 ms |
TPC-DS: Total hot run time: 194684 ms |
ClickBench: Total hot run time: 29.12 s |
|
run buildall |
TPC-H: Total hot run time: 33988 ms |
TPC-DS: Total hot run time: 193918 ms |
ClickBench: Total hot run time: 28.78 s |
|
run buildall |
TPC-H: Total hot run time: 33948 ms |
TPC-DS: Total hot run time: 185927 ms |
ClickBench: Total hot run time: 29.14 s |
|
run buildall |
TPC-H: Total hot run time: 33713 ms |
TPC-DS: Total hot run time: 193081 ms |
ClickBench: Total hot run time: 29.07 s |
|
run buildall |
TPC-H: Total hot run time: 35046 ms |
TPC-DS: Total hot run time: 186844 ms |
TPC-H: Total hot run time: 33704 ms |
TPC-DS: Total hot run time: 194706 ms |
ClickBench: Total hot run time: 28.92 s |
| } | ||
|
|
||
| UserIdentity currentUid = context.getCurrentUserIdentity(); | ||
| if (currentUid != null && !StringUtils.isEmpty(currentUid.getQualifiedUser())) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为什么要判断userid 是不是为null?
|
run buildall |
TPC-H: Total hot run time: 33736 ms |
TPC-DS: Total hot run time: 193578 ms |
ClickBench: Total hot run time: 29.74 s |
|
run buildall |
TPC-H: Total hot run time: 33825 ms |
TPC-DS: Total hot run time: 186713 ms |
ClickBench: Total hot run time: 28.95 s |
|
run buildall |
TPC-H: Total hot run time: 33773 ms |
TPC-DS: Total hot run time: 191964 ms |
ClickBench: Total hot run time: 28.7 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xinyiZzz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)