-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](refactor-param)Integrate New Storage System Support for BACKUP/RESTORE/LOAD/TVF #50849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
morningman
merged 59 commits into
apache:master
from
CalvinKirs:master-refactor-params-non-ctl
May 22, 2025
Merged
[feat](refactor-param)Integrate New Storage System Support for BACKUP/RESTORE/LOAD/TVF #50849
morningman
merged 59 commits into
apache:master
from
CalvinKirs:master-refactor-params-non-ctl
May 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…P/RESTORE/LOAD/TVF #### Key Changes Enhanced core functionalities (BACKUP, RESTORE, LOAD, TVF) to support new storage parameters Unified storage path and parameter parsing logic across modules to enable compatibility with multiple storage backends (S3, OSS, COS, etc.). #### Details Refactored the storage parameter handling logic to automatically detect the schema and route to the corresponding storage system implementation. Each operation (BACKUP/RESTORE/LOAD/TVF) now uses a unified file system interface to ensure consistent behavior and extensibility. Maintains full backward compatibility with existing storage formats such as HDFS and local file systems. #### Tests Added comprehensive unit and integration tests covering: Storage parameter parsing across different systems Execution flow for each operation under new storage systems Edge cases including invalid parameters, permission errors, and non-existent paths
Member
Author
|
run buildall |
TPC-H: Total hot run time: 33822 ms |
TPC-DS: Total hot run time: 186177 ms |
ClickBench: Total hot run time: 29.18 s |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 33581 ms |
TPC-DS: Total hot run time: 192826 ms |
ClickBench: Total hot run time: 29.23 s |
Member
Author
|
run feut |
Contributor
|
run buildall |
TPC-H: Total hot run time: 34636 ms |
TPC-DS: Total hot run time: 192184 ms |
ClickBench: Total hot run time: 29.27 s |
morningman
approved these changes
May 22, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
May 22, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…/RESTORE/LOAD/TVF (apache#50849) Issue Number: apache#50238 #### Key Changes Enhanced core functionalities (BACKUP, RESTORE, LOAD, TVF) to support new storage parameters Unified storage path and parameter parsing logic across modules to enable compatibility with multiple storage backends (S3, OSS, COS, etc.). #### Details Refactored the storage parameter handling logic to automatically detect the schema and route to the corresponding storage system implementation. Each operation (BACKUP/RESTORE/LOAD/TVF) now uses a unified file system interface to ensure consistent behavior and extensibility. Maintains full backward compatibility with existing storage formats such as HDFS and local file systems. #### Tests Added comprehensive unit and integration tests covering: Storage parameter parsing across different systems Execution flow for each operation under new storage systems Edge cases including invalid parameters, permission errors, and non-existent paths
CalvinKirs
added a commit
to CalvinKirs/incubator-doris
that referenced
this pull request
Jun 30, 2025
…t for BACKUP/RESTORE/LOAD/TVF (apache#50849) apache#50849
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number: #50238
Key Changes
Enhanced core functionalities (BACKUP, RESTORE, LOAD, TVF) to support new storage parameters
Unified storage path and parameter parsing logic across modules to enable compatibility with multiple storage backends (S3, OSS, COS, etc.).
Details
Refactored the storage parameter handling logic to automatically detect the schema and route to the corresponding storage system implementation.
Each operation (BACKUP/RESTORE/LOAD/TVF) now uses a unified file system interface to ensure consistent behavior and extensibility.
Maintains full backward compatibility with existing storage formats such as HDFS and local file systems.
Tests
Added comprehensive unit and integration tests covering:
Storage parameter parsing across different systems
Execution flow for each operation under new storage systems
Edge cases including invalid parameters, permission errors, and non-existent paths
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)